)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d7e231778d510542ebe83cb82f03e9142d7e837a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0dd001e2_2d1a4b12","updated":"2023-04-09 10:41:11.000000000","message":"We had a discussion about this last week - I\u0027m not sure this is worth the trouble. \n\nI see the current way to produce derivations as one historical way to do so (which we might replace some day), and we don\u0027t gain much by refactoring this to use StorePath inside.\n\nA new output path hashing method will likely come with a different implementation of builtins.derivation[Strict], which might emit something else than `nix_compat::derivation::Derivation` alltogether.","commit_id":"4713c96cf5bbe7282163b48b0a99a37b4ef68cd5"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2f1b9824c87fa51140fe65414fdd86b35de39278","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd650697_5ac98eb1","updated":"2023-05-18 13:22:42.000000000","message":"I thought about this again, and especially during https://cl.tvl.fyi/c/depot/+/8561.\n\n`StorePath` is in `nix_compat`, as is `Derivation`, and there\u0027s been one or two occurences where having the calculated derivation output paths being strings became annoying.\n\nWould you be up to rebase this and get CI to pass?","commit_id":"3924b05c29404ce4b07fc0d4993d2a43ef70950e"},{"author":{"_account_id":1000075,"name":"John Ericson","email":"git@johnericson.me","username":"ericson2314"},"change_message_id":"3d235ed5bca0f28d58a024eb893ecfd73a67f7f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9f48e1c_f806c87d","in_reply_to":"bd650697_5ac98eb1","updated":"2023-05-18 23:20:48.000000000","message":"Yay! Rebased, and finally got it working locally!","commit_id":"3924b05c29404ce4b07fc0d4993d2a43ef70950e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0b02a6dd45c914eba181f77f3fd57214d336ba49","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"000ca29b_8164718d","updated":"2023-05-19 05:23:05.000000000","message":"This seems to change the hashing, see the stdenv eval test failing:\n\nTvix output: \u003d\u003e \"/nix/store/616shvq9qkr39vl3073ia7ybh5jcwn7w-stdenv-linux.drv\" :: string\nCorrect would have been \u003d\u003e \"/nix/store/9b7i54zkd41vp7ij79gnlzqy6qa7hsn4-stdenv-linux.drv\" :: string","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"49e839aac98c56c7d7c0ca4076f32e5e5a78e25a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a001d649_eb38388c","updated":"2024-02-27 09:18:41.000000000","message":"with cl/11001 and parents, this can be abandoned.","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"}],"tvix/nix-compat/src/derivation/output.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54aafceb2321e08f11f0fa538a8062c05e87f84c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"#[derive(Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]"},{"line_number":7,"context_line":"pub struct Output {"},{"line_number":8,"context_line":"    // TODO should be `StorePath` for `Derivation`, and `()` (always empty string) for"},{"line_number":9,"context_line":"    // `PreDerivation`."},{"line_number":10,"context_line":"    pub path: String,"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    #[serde(flatten)]"}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"1f896cf3_cf99d09f","line":9,"updated":"2023-05-19 04:57:43.000000000","message":"I need to digest the PreDerivation a bit more.\n\nMaybe the output_paths test, supposed to showcase how to calculate output paths, should be extended with some more comments, or we document this elsewhere in some prose?","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"}],"tvix/nix-compat/src/derivation/tests/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54aafceb2321e08f11f0fa538a8062c05e87f84c","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            \u0026\u0026 ((drv_path \u003d\u003d \"4wvvbi4jwn0prsdxb7vs673qa5h9gr7x-foo.drv\""},{"line_number":133,"context_line":"                \u0026\u0026 parent_drv_path"},{"line_number":134,"context_line":"                    \u003d\u003d \u0026StorePath::from_absolute_path("},{"line_number":135,"context_line":"                        \"/nix/store/0hm2f1psjpcwg8fijsmr4wwxrx59s092-bar.drv\","},{"line_number":136,"context_line":"                    )"},{"line_number":137,"context_line":"                    .expect(\"valid drv path\"))"},{"line_number":138,"context_line":"                || (drv_path \u003d\u003d \"ch49594n9avinrf8ip0aslidkc4lxkqv-foo.drv\""}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"1924719c_2a63426e","line":135,"updated":"2023-05-19 04:57:43.000000000","message":"mmmh, this becomes a bit cluttered. could we move the construction of these two \"expected\" StorePath before the if, right after the comment?","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54aafceb2321e08f11f0fa538a8062c05e87f84c","unresolved":true,"context_lines":[{"line_number":149,"context_line":"            let data \u003d read_file(\u0026format!("},{"line_number":150,"context_line":"                \"{}/{}.json\","},{"line_number":151,"context_line":"                RESOURCES_PATHS,"},{"line_number":152,"context_line":"                Path::new(\u0026parent_drv_path.to_absolute_path())"},{"line_number":153,"context_line":"                    .file_name()"},{"line_number":154,"context_line":"                    .unwrap()"},{"line_number":155,"context_line":"                    .to_string_lossy()"}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"09dd5cd7_96952804","line":152,"updated":"2023-05-19 04:57:43.000000000","message":"This is just to extract the fixture name, we can just use parent_drv_path.to_string() here, which will get the file name, no?","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"}],"tvix/nix-compat/src/derivation/validate.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54aafceb2321e08f11f0fa538a8062c05e87f84c","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        // Validate all input_sources"},{"line_number":92,"context_line":"        for _input_source in self.input_sources.iter() {"},{"line_number":93,"context_line":"            // Nothing to do"},{"line_number":94,"context_line":"        }"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"3a0c20a6_12989164","line":92,"updated":"2023-05-19 04:57:43.000000000","message":"I guess we can remove the loop entirely :-)","commit_id":"ef2d9b452b5da4ec30cf9b798e046da4b1fa7839"}]}