)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d26318c8329036a04020b2e37861d1638a90334b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nixery): allow references to packages starting with numbers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These packages are invalid in Nix, and worked around in nixpkgs with"},{"line_number":10,"context_line":"underscores, but the underscores are invalid in the Docker registry"},{"line_number":11,"context_line":"protocol."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c99d9ff6_14417ab9","line":9,"updated":"2023-04-28 14:38:59.000000000","message":"This comment is misleading. Actually it is possible to have them called starting with numbers, they just need to be double quoted, and nixpkgs usually doesn\u0027t do it, but it\u0027d perfectly fine accept a \"1password\" as a key.\n\nI\u0027m not objecting the change/workaround per se, but it should be documented properly.\n\nOut of interest, does this mean other package names with underscores are also not usable?","commit_id":"0c19d3d70188795a00c9a95201f87bfcf135c8e7"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"cb516988bf3643501ebeba60a9ba4bd380c5b09c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nixery): allow references to packages starting with numbers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These packages are invalid in Nix, and worked around in nixpkgs with"},{"line_number":10,"context_line":"underscores, but the underscores are invalid in the Docker registry"},{"line_number":11,"context_line":"protocol."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"16f3e1dc_39c6fef9","line":9,"in_reply_to":"00a49b56_d037eb79","updated":"2023-04-29 11:45:57.000000000","message":"Done","commit_id":"0c19d3d70188795a00c9a95201f87bfcf135c8e7"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"a442bb0bd376e680aabceed817519434fff2efae","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nixery): allow references to packages starting with numbers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These packages are invalid in Nix, and worked around in nixpkgs with"},{"line_number":10,"context_line":"underscores, but the underscores are invalid in the Docker registry"},{"line_number":11,"context_line":"protocol."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d2373d2d_5abb7ea5","line":9,"in_reply_to":"c99d9ff6_14417ab9","updated":"2023-04-28 14:47:26.000000000","message":"The Docker protocol only bans the underscores in prefix position, so a package like `foo_bar` is fine.\n\nAs for the other note, yes, but then you also have to quote each identifier access (e.g. `pkgs.\"1password\"` etc.), and you get broken autocomplete-suggestions from the REPL. If you do the same with a `let` binding, you create inaccessible (except through the `inherit`-trick) identifiers. It seems reasonable to say that it\u0027s not really allowed.","commit_id":"0c19d3d70188795a00c9a95201f87bfcf135c8e7"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"675d364f5adfeb3be9e634fd3cc6c720cdd39ddc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nixery): allow references to packages starting with numbers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These packages are invalid in Nix, and worked around in nixpkgs with"},{"line_number":10,"context_line":"underscores, but the underscores are invalid in the Docker registry"},{"line_number":11,"context_line":"protocol."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"00a49b56_d037eb79","line":9,"in_reply_to":"d2373d2d_5abb7ea5","updated":"2023-04-28 14:48:12.000000000","message":"yeah, let\u0027s slowly amend the comment/commit message and get this in.","commit_id":"0c19d3d70188795a00c9a95201f87bfcf135c8e7"}]}