)]}'
{"id":"depot~8546","triplet_id":"depot~canon~I843be331682b731af6ae02a4648ba1c64aaf59a5","project":"depot","branch":"canon","hashtags":[],"change_id":"I843be331682b731af6ae02a4648ba1c64aaf59a5","subject":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs","status":"MERGED","created":"2023-05-01 16:10:49.000000000","updated":"2023-05-01 16:17:20.000000000","submitted":"2023-05-01 16:17:20.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8546","meta_rev_id":"4128d91b24930ced5d722289d448919e5b0cbc44","_number":8546,"virtual_id_number":8546,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-01 16:17:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-01 16:17:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-01 16:17:20.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-01 16:10:52.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-01 16:13:38.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-01 16:17:20.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"331ba01389eec3fb330a822b046102dcf8b16abd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-01 16:10:49.000000000","message":"Uploaded patch set 1: Autosubmit+1 Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"ab01b3eb9dae717dbde0e8a324408479868793c5","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-01 16:10:52.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24265","accounts_in_message":[],"_revision_number":1},{"id":"bafaccfd74770de6c1761b06390573f9da42d8ff","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-01 16:13:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/24265","accounts_in_message":[],"_revision_number":1},{"id":"783f6b6ddd31c7cadf5e27a350977a9a8b9105c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-01 16:13:53.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ed9904795f20b29fc3a390a7ecf5e0f6f27a5efd","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-01 16:13:56.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/24266","accounts_in_message":[],"_revision_number":2},{"id":"e81feada0ebe6539b174f5176f1b58da56c692f2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-01 16:16:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/24266","accounts_in_message":[],"_revision_number":2},{"id":"4128d91b24930ced5d722289d448919e5b0cbc44","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-05-01 16:17:20.000000000","message":"Change has been successfully rebased and submitted as 1e4b73ac957f30b57800533276a1f571d06f4f62\n\n1 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: third_party/lisp/mime4cl/test/mime.lisp\nInsertions: 1, Deletions: 1.\n\n@@ -1,7 +1,7 @@\n ;;; mime.lisp --- MIME regression tests\n \n ;;; Copyright (C) 2012 by Walter C. Pelissero\n-;;; Copyright (C) 2021-2022 by the TVL Authors\n+;;; Copyright (C) 2021-2023 by the TVL Authors\n \n ;;; Author: Walter C. Pelissero \u003cwalter@pelissero.de\u003e\n ;;; Project: mime4cl\n```\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"1e4b73ac957f30b57800533276a1f571d06f4f62","revisions":{"464af32d27c987d1ca804b7f39d00edf412c2301":{"kind":"REWORK","_number":1,"created":"2023-05-01 16:10:49.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/46/8546/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/46/8546/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/46/8546/1"}}},"commit":{"parents":[{"commit":"e0c2f8b10ab879c265a0307e11085e5ba7a4e23d","subject":"feat(sterni/emacs): allow refiling to all agenda files","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de0c2f8b10ab879c265a0307e11085e5ba7a4e23d"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-01 16:06:18.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-01 16:10:32.000000000","tz":120},"subject":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs","message":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs\n\nFor whatever reason, there were two sort of identical tests, mime.1 and\nmime.2, in the mime4cl test suite: The former tested *sample1-file* and\nthe latter all messages *samples-directory*—in the same way, parsing the\noriginal and a re-rendered version of the message to check if they were\nequal.\n\nWe can just move sample1.msg into *samples-directory*, get rid\nof *sample1-file* and thus pave the way for more test messages in the\nfuture.\n\nChange-Id: I843be331682b731af6ae02a4648ba1c64aaf59a5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d464af32d27c987d1ca804b7f39d00edf412c2301"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d464af32d27c987d1ca804b7f39d00edf412c2301"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e0c2f8b10ab879c265a0307e11085e5ba7a4e23d","is_merged_in_target_branch":false,"change_id":"I78eb4a6d21117784d7684e05d4cc92a92e43e482","change_number":8545,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8522f7ff44c74ce453e68f265f21157509e90b88":{"kind":"REWORK","_number":2,"created":"2023-05-01 16:13:53.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/46/8546/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/46/8546/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/46/8546/2"}}},"commit":{"parents":[{"commit":"e0c2f8b10ab879c265a0307e11085e5ba7a4e23d","subject":"feat(sterni/emacs): allow refiling to all agenda files","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de0c2f8b10ab879c265a0307e11085e5ba7a4e23d"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-01 16:06:18.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-01 16:13:48.000000000","tz":120},"subject":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs","message":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs\n\nFor whatever reason, there were two sort of identical tests, mime.1 and\nmime.2, in the mime4cl test suite: The former tested *sample1-file* and\nthe latter all messages *samples-directory*—in the same way, parsing the\noriginal and a re-rendered version of the message to check if they were\nequal.\n\nWe can just move sample1.msg into *samples-directory*, get rid\nof *sample1-file* and thus pave the way for more test messages in the\nfuture.\n\nChange-Id: I843be331682b731af6ae02a4648ba1c64aaf59a5\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8522f7ff44c74ce453e68f265f21157509e90b88"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8522f7ff44c74ce453e68f265f21157509e90b88"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e0c2f8b10ab879c265a0307e11085e5ba7a4e23d","is_merged_in_target_branch":false,"change_id":"I78eb4a6d21117784d7684e05d4cc92a92e43e482","change_number":8545,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1e4b73ac957f30b57800533276a1f571d06f4f62":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-05-01 16:17:20.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/46/8546/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/46/8546/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/46/8546/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/46/8546/3"}}},"commit":{"parents":[{"commit":"93a6d3d9208197c9d8ce419747ec5c34a9d8d8d1","subject":"feat(sterni/emacs): allow refiling to all agenda files","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93a6d3d9208197c9d8ce419747ec5c34a9d8d8d1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-01 16:06:18.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-05-01 16:17:20.000000000","tz":0},"subject":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs","message":"refactor(3p/lisp/mime4cl): unify test mechanism for sample msgs\n\nFor whatever reason, there were two sort of identical tests, mime.1 and\nmime.2, in the mime4cl test suite: The former tested *sample1-file* and\nthe latter all messages *samples-directory*—in the same way, parsing the\noriginal and a re-rendered version of the message to check if they were\nequal.\n\nWe can just move sample1.msg into *samples-directory*, get rid\nof *sample1-file* and thus pave the way for more test messages in the\nfuture.\n\nChange-Id: I843be331682b731af6ae02a4648ba1c64aaf59a5\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8546\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e4b73ac957f30b57800533276a1f571d06f4f62"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1e4b73ac957f30b57800533276a1f571d06f4f62"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93a6d3d9208197c9d8ce419747ec5c34a9d8d8d1","is_merged_in_target_branch":true,"change_id":"I78eb4a6d21117784d7684e05d4cc92a92e43e482","change_number":8545,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}