)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"dd6283f58b50c105b66d2cba902e6cc7f0fb3e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"bf631851_668831c5","updated":"2023-05-17 15:05:21.000000000","message":"Rewriting this without recursion should be fairly easy to do.","commit_id":"7c27928859976f693a7a1fcc0fd1b1f4d45f9391"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a5d013cb6b3225e2ae7cdc6bbc4552b079c8fc8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3dea0c99_2a022fd2","in_reply_to":"bf631851_668831c5","updated":"2023-05-18 06:25:33.000000000","message":"b/270","commit_id":"7c27928859976f693a7a1fcc0fd1b1f4d45f9391"}],"tvix/store/src/directoryservice/traverse.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"cbd102c741e1d428cb557f759508556ed023ee06","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"/// This traverses from a (root) node to the given (sub)path, returning the Node"},{"line_number":9,"context_line":"/// at that path, or none, if there\u0027s nothing at that path."},{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"16adeb1b_fe0a28b0","line":10,"updated":"2023-05-14 18:32:27.000000000","message":"I\u0027d leave this to a followup CL.","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"dd6283f58b50c105b66d2cba902e6cc7f0fb3e42","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"/// This traverses from a (root) node to the given (sub)path, returning the Node"},{"line_number":9,"context_line":"/// at that path, or none, if there\u0027s nothing at that path."},{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"4950fb14_8ac2a777","line":10,"in_reply_to":"16adeb1b_fe0a28b0","updated":"2023-05-17 15:05:21.000000000","message":"Ack","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a5d013cb6b3225e2ae7cdc6bbc4552b079c8fc8f","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"/// This traverses from a (root) node to the given (sub)path, returning the Node"},{"line_number":9,"context_line":"/// at that path, or none, if there\u0027s nothing at that path."},{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"40b5e1c6_c62f99d5","line":10,"in_reply_to":"4950fb14_8ac2a777","updated":"2023-05-18 06:25:33.000000000","message":"b/270","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"cbd102c741e1d428cb557f759508556ed023ee06","unresolved":true,"context_lines":[{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"},{"line_number":14,"context_line":"/// clearly distinguish it from the BFS traversers."},{"line_number":15,"context_line":"pub fn traverse_to\u003cDS: DirectoryService\u003e("},{"line_number":16,"context_line":"    directory_service: \u0026mut DS,"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"0343f25a_542f7f44","line":13,"updated":"2023-05-14 18:32:27.000000000","message":"@tazjin any proposals?","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"dd6283f58b50c105b66d2cba902e6cc7f0fb3e42","unresolved":true,"context_lines":[{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"},{"line_number":14,"context_line":"/// clearly distinguish it from the BFS traversers."},{"line_number":15,"context_line":"pub fn traverse_to\u003cDS: DirectoryService\u003e("},{"line_number":16,"context_line":"    directory_service: \u0026mut DS,"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"8420b479_6ebeb2c2","line":13,"in_reply_to":"0343f25a_542f7f44","updated":"2023-05-17 15:05:21.000000000","message":"I don\u0027t have enough context of the other traversers etc., I think the naming should become more obvious once this has real callsites.","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a5d013cb6b3225e2ae7cdc6bbc4552b079c8fc8f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"/// TODO: Do we want to rewrite this in a non-recursing fashion, and use"},{"line_number":11,"context_line":"/// [DirectoryService.get_recursive] to do less lookups?"},{"line_number":12,"context_line":"/// Or do we consider this to be a non-issue due to store composition and local caching?"},{"line_number":13,"context_line":"/// TODO: the name of this function (and mod) is a bit bad, because it doesn\u0027t"},{"line_number":14,"context_line":"/// clearly distinguish it from the BFS traversers."},{"line_number":15,"context_line":"pub fn traverse_to\u003cDS: DirectoryService\u003e("},{"line_number":16,"context_line":"    directory_service: \u0026mut DS,"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"813ef9f3_1ea90eae","line":13,"in_reply_to":"8420b479_6ebeb2c2","updated":"2023-05-18 06:25:33.000000000","message":"b/270","commit_id":"0e395ea457ea9095118888abce233913b5c48a7d"}]}