)]}'
{"id":"depot~859","triplet_id":"depot~canon~Idfd0e67752880a37dce0b400a3c1cfc53fac2912","project":"depot","branch":"canon","hashtags":[],"change_id":"Idfd0e67752880a37dce0b400a3c1cfc53fac2912","subject":"fix(gerrit): return HTML titles in more cases","status":"MERGED","created":"2020-07-02 22:30:29.000000000","updated":"2020-07-03 18:19:07.000000000","submitted":"2020-07-03 18:18:42.000000000","submitter":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"859","meta_rev_id":"5c4e502faaab5f3b1fc9a62b7edfa0b0a89ecbab","_number":859,"virtual_id_number":859,"owner":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-03 18:18:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-03 18:18:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-03 18:18:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-02 22:32:05.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-02 22:33:14.000000000","updated_by":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"c53cf578435d281161a3e11b8cb94262818fa2df","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-07-02 22:30:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8e5c8ba0b2e85fedc9db3c69fcac4be9623a608","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-02 22:32:05.000000000","message":"Patch Set 1: Verified+1 Code-Review+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/416","accounts_in_message":[],"_revision_number":1},{"id":"05a9c544bc07ab832e84eca330e51885fb64f316","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-07-02 22:33:14.000000000","message":"Patch Set 1:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"997b8120c04fb089c78667cb24d94a63ff92c670","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-03 14:14:54.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9d307dfb2a6804223bd0f8ae3d32f2e2ce8c81f3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"date":"2020-07-03 18:18:42.000000000","message":"Change has been successfully rebased and submitted as 3f6518ce99de8d8fa330ae551b2dc49b2094c712 by lukegb","accounts_in_message":[],"_revision_number":2},{"id":"5c4e502faaab5f3b1fc9a62b7edfa0b0a89ecbab","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-03 18:19:07.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/513","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3f6518ce99de8d8fa330ae551b2dc49b2094c712","revisions":{"ab5797a7bf046306fbdb29ecd449e63c7c14ed75":{"kind":"REWORK","_number":1,"created":"2020-07-02 22:30:29.000000000","uploader":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"ref":"refs/changes/59/859/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/59/859/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/59/859/1"}}},"commit":{"parents":[{"commit":"6fd3371e94fa529e39a9c047f2eef81f3b4ec43c","subject":"feat(tvldb): prohibit infinite recursion","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fd3371e94fa529e39a9c047f2eef81f3b4ec43c"}]}],"author":{"name":"Luke Granger-Brown","email":"git@lukegb.com","date":"2020-07-02 22:28:39.000000000","tz":60},"committer":{"name":"Luke Granger-Brown","email":"git@lukegb.com","date":"2020-07-02 22:28:39.000000000","tz":60},"subject":"fix(gerrit): return HTML titles in more cases","message":"fix(gerrit): return HTML titles in more cases\n\nAt present, we don\u0027t return HTML titles if there\u0027s a trailing slash,\nor a patchset. Instead, just consume the / and anything after it.\n\nThis also fixes /123, because this is HTTP redirected to the full path\n*with a trailing slash* which otherwise wouldn\u0027t get the title\ninjected.\n\nChange-Id: Idfd0e67752880a37dce0b400a3c1cfc53fac2912\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dab5797a7bf046306fbdb29ecd449e63c7c14ed75"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dab5797a7bf046306fbdb29ecd449e63c7c14ed75"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fd3371e94fa529e39a9c047f2eef81f3b4ec43c","is_merged_in_target_branch":true,"change_id":"I63b54e937f4c4fdb823f2e2e91a5a5d8af071a42","change_number":855,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3f6518ce99de8d8fa330ae551b2dc49b2094c712":{"kind":"REWORK","_number":2,"created":"2020-07-03 18:18:42.000000000","uploader":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"},"ref":"refs/changes/59/859/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/59/859/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/59/859/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/59/859/2"}}},"commit":{"parents":[{"commit":"26bb34823d884a619985cf91262f180e0ad4d207","subject":"fix(xan): Don\u0027t allow looking at invisible things","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d26bb34823d884a619985cf91262f180e0ad4d207"}]}],"author":{"name":"Luke Granger-Brown","email":"git@lukegb.com","date":"2020-07-02 22:28:39.000000000","tz":60},"committer":{"name":"lukegb","email":"lukegb@tvl.fyi","date":"2020-07-03 18:18:42.000000000","tz":0},"subject":"fix(gerrit): return HTML titles in more cases","message":"fix(gerrit): return HTML titles in more cases\n\nAt present, we don\u0027t return HTML titles if there\u0027s a trailing slash,\nor a patchset. Instead, just consume the / and anything after it.\n\nThis also fixes /123, because this is HTTP redirected to the full path\n*with a trailing slash* which otherwise wouldn\u0027t get the title\ninjected.\n\nChange-Id: Idfd0e67752880a37dce0b400a3c1cfc53fac2912\nReviewed-on: https://cl.tvl.fyi/c/depot/+/859\nReviewed-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3f6518ce99de8d8fa330ae551b2dc49b2094c712"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3f6518ce99de8d8fa330ae551b2dc49b2094c712"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"26bb34823d884a619985cf91262f180e0ad4d207","is_merged_in_target_branch":true,"change_id":"I1ec86211c2fcbd984dd52338fb5631667c22c723","change_number":903,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000000,"name":"lukegb","email":"lukegb@tvl.fyi","username":"lukegb","status":"zzz"}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}