)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"740312f7e36662b535abd2258aed7cd89090c224","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cfa0354d_4595f518","updated":"2023-05-19 08:54:24.000000000","message":"What is the motivation for this? It makes some things less readable (especially the return type change), and increases the in-memory size of the error type, but I don\u0027t see what we gain from it?","commit_id":"f2113fe75594b4f65f71b857d2743be9f16d1f08"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"f4e87388bb074ddbfd8afeb9f9e9c8017e5eba98","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"238e0214_d981b56a","in_reply_to":"0adf6b7a_69b3bfa8","updated":"2023-05-22 07:42:49.000000000","message":"If you\u0027re introducing this B3Digest type now, it makes more sense to write a CL like this one afterwards which makes use of this type.","commit_id":"f2113fe75594b4f65f71b857d2743be9f16d1f08"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"09fd9cfdd40cca7a97977aaf83292bb0103eaa81","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e14d76e9_cfc698eb","in_reply_to":"238e0214_d981b56a","updated":"2023-05-22 09:44:03.000000000","message":"I\u0027ll update this PR with the `B3Digest` version of it.","commit_id":"f2113fe75594b4f65f71b857d2743be9f16d1f08"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"45053aabb4aa606022ada6af6af1e5df51984dd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0adf6b7a_69b3bfa8","in_reply_to":"cfa0354d_4595f518","updated":"2023-05-19 09:00:54.000000000","message":"This is in the same spirit, and should get the same treatment as things in https://b.tvl.fyi/issues/268.\n\nI don\u0027t want to pass around `Vec\u003cu8\u003e` of an arbitrary size, but want to be more explicit.\n\nIn another followup, we can probably have some newtype here that still keeps a Vec\u003cu8\u003e inside, but rejects wrong digest sizes.","commit_id":"f2113fe75594b4f65f71b857d2743be9f16d1f08"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"48585daeb7d4db9c5a00396816fa70edee5091f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fcf50c98_7b270511","in_reply_to":"e14d76e9_cfc698eb","updated":"2023-05-22 11:47:28.000000000","message":"Done","commit_id":"f2113fe75594b4f65f71b857d2743be9f16d1f08"}],"tvix/store/src/nar/non_caching_calculation_service.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"9b3f45bd90faae4ca58bd0288c98cf50ac93f126","unresolved":true,"context_lines":[{"line_number":26,"context_line":"impl\u003cBS: BlobService, DS: DirectoryService\u003e NARCalculationService"},{"line_number":27,"context_line":"    for NonCachingNARCalculationService\u003cBS, DS\u003e"},{"line_number":28,"context_line":"{"},{"line_number":29,"context_line":"    fn calculate_nar(\u0026self, root_node: \u0026proto::node::Node) -\u003e Result\u003c(u64, [u8; 32]), RenderError\u003e {"},{"line_number":30,"context_line":"        let h \u003d Sha256::new();"},{"line_number":31,"context_line":"        let mut cw \u003d CountWrite::from(h);"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"fd124011_a117a32b","line":29,"updated":"2023-05-22 11:49:01.000000000","message":"This could now also use B3Digest here.","commit_id":"3bffc469c6dc65d4552bc221c0860c13fcfc2493"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4521d510e99176182aa4d2d7f3032821944f51a5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"impl\u003cBS: BlobService, DS: DirectoryService\u003e NARCalculationService"},{"line_number":27,"context_line":"    for NonCachingNARCalculationService\u003cBS, DS\u003e"},{"line_number":28,"context_line":"{"},{"line_number":29,"context_line":"    fn calculate_nar(\u0026self, root_node: \u0026proto::node::Node) -\u003e Result\u003c(u64, [u8; 32]), RenderError\u003e {"},{"line_number":30,"context_line":"        let h \u003d Sha256::new();"},{"line_number":31,"context_line":"        let mut cw \u003d CountWrite::from(h);"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"c95225e4_d58af20e","line":29,"in_reply_to":"fd124011_a117a32b","updated":"2023-05-22 12:49:50.000000000","message":"Ah no, it cannot, because it\u0027s sha256 here, not blake3.","commit_id":"3bffc469c6dc65d4552bc221c0860c13fcfc2493"}]}