)]}'
{"id":"depot~8654","triplet_id":"depot~canon~I640a5827b963f5b9d0f86fa2142e75e3a6bbee78","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-05-29 12:44:08.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-05-29 12:36:00.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I640a5827b963f5b9d0f86fa2142e75e3a6bbee78","subject":"fix(tvix/eval): thunk unary operator applications","status":"MERGED","created":"2023-05-27 12:00:45.000000000","updated":"2023-05-29 12:44:08.000000000","submitted":"2023-05-29 12:44:08.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8654","meta_rev_id":"5b0f32cee099ac3ab2611e5967f7cc23321ab721","_number":8654,"virtual_id_number":8654,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-29 12:44:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-29 12:44:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-29 12:44:08.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-27 12:00:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-27 12:00:58.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-05-27 12:04:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-29 12:44:08.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ffd2afa220596cd9dda2188b4bcf6d600fa5f80d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:00:45.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"75617e08996f8b7806eb90b21ec1828ac1efe972","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:00:46.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24741","accounts_in_message":[],"_revision_number":1},{"id":"034bf953b8d485ccd22a2078aa9810aece055030","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:00:58.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/compiler/mod.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"4fcdaedee07a8b3106a60e428b776e1e67781413","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:04:04.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a43c748bf4e0137abd89bc1073a407da3e11727b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:04:05.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/24742","accounts_in_message":[],"_revision_number":2},{"id":"fe63986295e92cb1bfcee4fd7e17da72fe953a79","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:04:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/24741","accounts_in_message":[],"_revision_number":1},{"id":"c4cc99996ee8f55b45b9b9b2dfcb23aa0f23253d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:05:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/24742","accounts_in_message":[],"_revision_number":2},{"id":"b1144ecedc9b99426bcd6ad20179cde054004e0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:05:55.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"043cafbe2d8644bfde20291c0543a653545be209","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:05:56.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/24743","accounts_in_message":[],"_revision_number":3},{"id":"95f26150df1232302376aefa7a0d14a903208cc4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:10:07.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/24743","accounts_in_message":[],"_revision_number":3},{"id":"d951ff7322330184bf59be1813c9dffb9c60dc97","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:18:32.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"32f9b20d332bef1af0b649a16f19595ca7e1c0bb","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:18:33.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/24744","accounts_in_message":[],"_revision_number":4},{"id":"4070c3cd3b67f0c541ac227aef42d76a588379a7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:21:37.000000000","message":"Patch Set 4: Verified-1\n\nBuild of patchset 4 failed: https://buildkite.com/tvl/depot/builds/24744","accounts_in_message":[],"_revision_number":4},{"id":"aa0a28494868ca28232d6fe0abca1557359a533f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 12:24:11.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"cfa5c6dbce1540d13a8e76656c58b48370ee1fd5","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:24:12.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/24745","accounts_in_message":[],"_revision_number":5},{"id":"e280641b41d34592d3edd4a40887098f4459013a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 12:27:16.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/24745","accounts_in_message":[],"_revision_number":5},{"id":"4033b1fce7f0bd56b0c705c5c2483e93c4b05da3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-27 14:07:41.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"b4760448024d973adadedcba9fadd0b601e2b211","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 14:07:42.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/24746","accounts_in_message":[],"_revision_number":6},{"id":"db48ed4f7163e222a78794cdecebed6710f7cc9f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-27 14:11:39.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/24746","accounts_in_message":[],"_revision_number":6},{"id":"d4c4be409893b2c61825789af9cc55d8ea61fc32","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-05-29 12:36:00.000000000","message":"Patch Set 6: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/cli/default.nix\n* tvix/eval/src/compiler/mod.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":6},{"id":"78393b5e4726ef548a4c652e86259c19fda8f33d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-05-29 12:37:05.000000000","message":"Patch Set 7: Patch Set 6 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"545656d4320273e3b7e6de7177382d2dbec1cca2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-29 12:37:06.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/24798","accounts_in_message":[],"_revision_number":7},{"id":"1f9509e79cd1bc69b228cd591a1a9a1261e5f3b8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-29 12:43:11.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/24798","accounts_in_message":[],"_revision_number":7},{"id":"5b0f32cee099ac3ab2611e5967f7cc23321ab721","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-05-29 12:44:08.000000000","message":"Change has been successfully rebased and submitted as 385c7978841af20da9bd47a829dd1f2d3f6cdd2e\n\n6 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"385c7978841af20da9bd47a829dd1f2d3f6cdd2e","revisions":{"6597aac156c544bdd2837d962aa0cf80b2056c07":{"kind":"REWORK","_number":1,"created":"2023-05-27 12:00:45.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/1"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6597aac156c544bdd2837d962aa0cf80b2056c07"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6597aac156c544bdd2837d962aa0cf80b2056c07"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7e1c1f9824a3c21d76a0f2ef342fea603d73017a":{"kind":"REWORK","_number":2,"created":"2023-05-27 12:04:04.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/2"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 12:03:55.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e1c1f9824a3c21d76a0f2ef342fea603d73017a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e1c1f9824a3c21d76a0f2ef342fea603d73017a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"cc1e908ffbf2a7e738424cdd8c792a83d518d94c":{"kind":"REWORK","_number":3,"created":"2023-05-27 12:05:55.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/3"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 12:05:51.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc1e908ffbf2a7e738424cdd8c792a83d518d94c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcc1e908ffbf2a7e738424cdd8c792a83d518d94c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"194988cf6b07a820c98c31cb48785eba3797a8ad":{"kind":"REWORK","_number":4,"created":"2023-05-27 12:18:32.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/4"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 12:18:29.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d194988cf6b07a820c98c31cb48785eba3797a8ad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d194988cf6b07a820c98c31cb48785eba3797a8ad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"80f1fc4ff581a352552a1bf7ebda23dfff3e8880":{"kind":"REWORK","_number":5,"created":"2023-05-27 12:24:11.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/5"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 12:24:06.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80f1fc4ff581a352552a1bf7ebda23dfff3e8880"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80f1fc4ff581a352552a1bf7ebda23dfff3e8880"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"544906b78beda32451d0ec6df76dbb688b6981bb":{"kind":"REWORK","_number":6,"created":"2023-05-27 14:07:41.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/54/8654/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/6"}}},"commit":{"parents":[{"commit":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","subject":"fix(tvix): don\u0027t call function eagerly in genList, map \u0026 mapAttrs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 14:07:31.000000000","tz":120},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d544906b78beda32451d0ec6df76dbb688b6981bb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d544906b78beda32451d0ec6df76dbb688b6981bb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3b33c19a9c43cf66c2d28ffa3d49bb6e8757d9b1","is_merged_in_target_branch":true,"change_id":"I1fa53f744bcffc035da84c1f97ed25d146830446","change_number":8651,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8abb8e75408a18f2d483ec0dcdbde0e24527bb4d":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2023-05-29 12:37:05.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/54/8654/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/7"}}},"commit":{"parents":[{"commit":"93fa47f2ae868e9476f1dd33572022ef0bed4dbf","subject":"feat(tvix/cli): add --no-warnings argument","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93fa47f2ae868e9476f1dd33572022ef0bed4dbf"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-05-29 12:37:05.000000000","tz":0},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8abb8e75408a18f2d483ec0dcdbde0e24527bb4d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8abb8e75408a18f2d483ec0dcdbde0e24527bb4d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93fa47f2ae868e9476f1dd33572022ef0bed4dbf","is_merged_in_target_branch":true,"change_id":"I15381396f86573484bdd1a73d09034a665638e35","change_number":8646,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"385c7978841af20da9bd47a829dd1f2d3f6cdd2e":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2023-05-29 12:44:08.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/54/8654/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/54/8654/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/54/8654/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/54/8654/8"}}},"commit":{"parents":[{"commit":"93fa47f2ae868e9476f1dd33572022ef0bed4dbf","subject":"feat(tvix/cli): add --no-warnings argument","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93fa47f2ae868e9476f1dd33572022ef0bed4dbf"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-27 11:45:56.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-05-29 12:44:08.000000000","tz":0},"subject":"fix(tvix/eval): thunk unary operator applications","message":"fix(tvix/eval): thunk unary operator applications\n\nUnary operator applications are thunked which can easily be observed by\n\n  nix-instantiate --eval -E \u0027[ (!true) (-1) ]\u0027\n\nUnfortunately, there are few simple expressions where this makes a\ndifference in the end result. Thus it only cropped up when using nixpkgs\nfor cross compilation: Here we would compile the expression\n\n  !(stdenv.cc.isGNU or false)\n\nto assemble python3Minimal\u0027s passthru attribute set (at least this seems\nto be the most likely explanation from the backtraces I\u0027ve studied).\nThis means that an unthunked\n\n    \u003cstdenv.cc.isGNU or false\u003e\n    OpForce\n    OpInvert\n\nwould be performed in order to assemble this attribute set, causing\nstdenv.cc to be evaluated too early, causing an infinite recursion.\n\nResolves b/273.\n\nIt seems that having a test suite that doesn\u0027t use --strict and relies\non thunks rendered as \u003cCODE\u003e would be beneficial for catching such\nissues. I\u0027ve not been able to find a test case with --strict that\ndemonstrates the problem fixed in this CL.\n\nChange-Id: I640a5827b963f5b9d0f86fa2142e75e3a6bbee78\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8654\nTested-by: BuildkiteCI\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d385c7978841af20da9bd47a829dd1f2d3f6cdd2e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d385c7978841af20da9bd47a829dd1f2d3f6cdd2e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93fa47f2ae868e9476f1dd33572022ef0bed4dbf","is_merged_in_target_branch":true,"change_id":"I15381396f86573484bdd1a73d09034a665638e35","change_number":8646,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}