)]}'
{"id":"depot~8689","triplet_id":"depot~canon~Ifa5327f846a903e07607b21f8eedbc32fc36f758","project":"depot","branch":"canon","hashtags":[],"change_id":"Ifa5327f846a903e07607b21f8eedbc32fc36f758","subject":"chore: remove comments formerly meant for alignment","status":"MERGED","created":"2023-05-31 10:49:18.000000000","updated":"2023-05-31 10:55:07.000000000","submitted":"2023-05-31 10:55:07.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8689","meta_rev_id":"b53e44c486a3e226f26769a832258afaedc293b6","_number":8689,"virtual_id_number":8689,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-05-31 10:55:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-31 10:55:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-05-31 10:55:07.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-05-31 10:49:20.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-05-31 10:51:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-05-31 10:55:07.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ff9d41fd3ff1b875bcd9ac1239bde93e36f0211","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-05-31 10:49:18.000000000","message":"Uploaded patch set 1: Autosubmit+1 Code-Review+2.","accounts_in_message":[],"_revision_number":1},{"id":"21072e4c22603000d595213cd2cc1114d79b376a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-31 10:49:20.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24865","accounts_in_message":[],"_revision_number":1},{"id":"0e82aba221a2a981a0af3dc32d96e9afff173bbe","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-31 10:51:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/24865","accounts_in_message":[],"_revision_number":1},{"id":"bd5c547230bcaa079dceb0a5b007bc9fd318b01f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-05-31 10:52:06.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"fd239589e4e98c2777f7e5410bb0686084027b65","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-31 10:52:08.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/24866","accounts_in_message":[],"_revision_number":2},{"id":"62a3ebc7671b306087e8d86f560e36a49e3ea872","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-05-31 10:54:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/24866","accounts_in_message":[],"_revision_number":2},{"id":"b53e44c486a3e226f26769a832258afaedc293b6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-05-31 10:55:07.000000000","message":"Change has been successfully rebased and submitted as 830bc9961af0947a5e14948808f19145afa7ddc7\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"830bc9961af0947a5e14948808f19145afa7ddc7","revisions":{"680354dd44a046fd5d9236e78244add08e5e4002":{"kind":"REWORK","_number":1,"created":"2023-05-31 10:49:18.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/89/8689/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/89/8689/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/89/8689/1"}}},"commit":{"parents":[{"commit":"e3c5eb331315c9c252bf27e259ea98c6fb51003b","subject":"chore(3p/sources): bump nixpkgs channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de3c5eb331315c9c252bf27e259ea98c6fb51003b"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-31 10:48:04.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-31 10:48:04.000000000","tz":120},"subject":"chore: remove comments formerly meant for alignment","message":"chore: remove comments formerly meant for alignment\n\n/**/ is a nice way to align if statements which doesn\u0027t work with\nnixpkgs-fmt, since it\u0027ll reflow the comment to the line preceding the\nif. Consequently, we can delete these comments now.\n\nChange-Id: Ifa5327f846a903e07607b21f8eedbc32fc36f758\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d680354dd44a046fd5d9236e78244add08e5e4002"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d680354dd44a046fd5d9236e78244add08e5e4002"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e3c5eb331315c9c252bf27e259ea98c6fb51003b","is_merged_in_target_branch":true,"change_id":"I0eea99ec98f4e73e615c012ffae1d0e37122e73b","change_number":8585,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"23c170813f14385fc4d32b63c1bbd7f82a815bcb":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-05-31 10:52:06.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/89/8689/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/89/8689/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/89/8689/2"}}},"commit":{"parents":[{"commit":"2b0b4cadbd67d768419e71e918c105b26eb57ca7","subject":"feat(tvix/store/bin): use sled for daemon, grpc for import cmd","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b0b4cadbd67d768419e71e918c105b26eb57ca7"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-31 10:48:04.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-05-31 10:52:06.000000000","tz":0},"subject":"chore: remove comments formerly meant for alignment","message":"chore: remove comments formerly meant for alignment\n\n/**/ is a nice way to align if statements which doesn\u0027t work with\nnixpkgs-fmt, since it\u0027ll reflow the comment to the line preceding the\nif. Consequently, we can delete these comments now.\n\nChange-Id: Ifa5327f846a903e07607b21f8eedbc32fc36f758\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d23c170813f14385fc4d32b63c1bbd7f82a815bcb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d23c170813f14385fc4d32b63c1bbd7f82a815bcb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2b0b4cadbd67d768419e71e918c105b26eb57ca7","is_merged_in_target_branch":true,"change_id":"I72351fcf0e83a013b6aa67a90b64c108cbb01ffd","change_number":8619,"patch_set_number":20,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"830bc9961af0947a5e14948808f19145afa7ddc7":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-05-31 10:55:07.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/89/8689/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/89/8689/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/89/8689/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/89/8689/3"}}},"commit":{"parents":[{"commit":"2b0b4cadbd67d768419e71e918c105b26eb57ca7","subject":"feat(tvix/store/bin): use sled for daemon, grpc for import cmd","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b0b4cadbd67d768419e71e918c105b26eb57ca7"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-05-31 10:48:04.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-05-31 10:55:07.000000000","tz":0},"subject":"chore: remove comments formerly meant for alignment","message":"chore: remove comments formerly meant for alignment\n\n/**/ is a nice way to align if statements which doesn\u0027t work with\nnixpkgs-fmt, since it\u0027ll reflow the comment to the line preceding the\nif. Consequently, we can delete these comments now.\n\nChange-Id: Ifa5327f846a903e07607b21f8eedbc32fc36f758\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8689\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d830bc9961af0947a5e14948808f19145afa7ddc7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d830bc9961af0947a5e14948808f19145afa7ddc7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2b0b4cadbd67d768419e71e918c105b26eb57ca7","is_merged_in_target_branch":true,"change_id":"I72351fcf0e83a013b6aa67a90b64c108cbb01ffd","change_number":8619,"patch_set_number":20,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}