)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"64e1394f50c44c9ff20b58bae87d3587e6ba6c20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba264b42_f892466c","updated":"2023-06-02 13:07:43.000000000","message":"Considering people now rely on this - Can we open a bug in nix to properly document this, and maybe have it added to their test suite?","commit_id":"1882133cdb0d20b7c11a1a23e9995c5a54572a17"},{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"265a26b8489bacd2f2346d76d0129161779a7713","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40ff028e_de22844e","updated":"2023-06-02 12:59:23.000000000","message":"Good find, although I\u0027m not sure how to feel about it. It technically falls under our credo of “used in nixpkgs”, but the implementation in C++ Nix is unsatisfactory—so should we remove it in nixpkgs or fix the implementation in C++ Nix?","commit_id":"1882133cdb0d20b7c11a1a23e9995c5a54572a17"},{"author":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"change_message_id":"baf122e6f94edfc2d8783498088edcac39dd006d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c42079d7_5cf2ccbf","in_reply_to":"40ff028e_de22844e","updated":"2023-06-11 20:52:37.000000000","message":"(imho) changing nixpkgs to fulfill that criterion doesn\u0027t make much sense -- part of what\u0027s so great about the Nix ecosystem overall is being able to go so far back in time, and it would be a bit of a disappointment if tvix could only evaluate nixpkgs from 2023 and later. Changing Nix doesn\u0027t make sense for the same reason.","commit_id":"1882133cdb0d20b7c11a1a23e9995c5a54572a17"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"719b5daf6f5fe6fc8f6e9af5dcd9ef8004689d8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24475f35_e3367822","updated":"2023-06-09 15:47:56.000000000","message":"@tazjin can you set the owner to linus here, so he can submit a new version of the CL?","commit_id":"c35664ae9a797ac0b147b6d6630f72e9321c6dd2"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"694c5878d06dace3e1f8f3e77945c35ca69f4fb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"285610f5_493147eb","in_reply_to":"24475f35_e3367822","updated":"2023-06-11 17:03:04.000000000","message":"No, that is not possible in Gerrit.","commit_id":"c35664ae9a797ac0b147b6d6630f72e9321c6dd2"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"982ca1a62ee638fa3255db255faa113783fe2bb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66ff2e3f_722fdda8","in_reply_to":"285610f5_493147eb","updated":"2023-06-11 17:26:13.000000000","message":"alright, then it\u0027s probably easiest to abandon this CL, and have Linus update this with a new change ID","commit_id":"c35664ae9a797ac0b147b6d6630f72e9321c6dd2"}],"tvix/eval/src/builtins/mod.rs":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"265a26b8489bacd2f2346d76d0129161779a7713","unresolved":true,"context_lines":[{"line_number":874,"context_line":"        } else {"},{"line_number":875,"context_line":"            len as usize"},{"line_number":876,"context_line":"        };"},{"line_number":877,"context_line":"        let end \u003d cmp::min(beg + len, x.as_str().len());"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"        Ok(Value::String(x.as_str()[beg..end].into()))"},{"line_number":880,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"2877ee87_d8a63e26","line":877,"updated":"2023-06-02 12:59:23.000000000","message":"I would propose to instead do:\n\n```\nlet end \u003d if len \u003c 0 {\n  x.as_str().len() as usize\n} else {\n  cmp::min(beg + (len as usize), x.as_str().len())\n};","commit_id":"1882133cdb0d20b7c11a1a23e9995c5a54572a17"},{"author":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"change_message_id":"baf122e6f94edfc2d8783498088edcac39dd006d","unresolved":true,"context_lines":[{"line_number":874,"context_line":"        } else {"},{"line_number":875,"context_line":"            len as usize"},{"line_number":876,"context_line":"        };"},{"line_number":877,"context_line":"        let end \u003d cmp::min(beg + len, x.as_str().len());"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"        Ok(Value::String(x.as_str()[beg..end].into()))"},{"line_number":880,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"76047782_65003379","line":877,"in_reply_to":"2877ee87_d8a63e26","updated":"2023-06-11 20:52:37.000000000","message":"Ack\n\nhttps://cl.tvl.fyi/c/depot/+/8746\\","commit_id":"1882133cdb0d20b7c11a1a23e9995c5a54572a17"}]}