)]}'
{"id":"depot~8692","triplet_id":"depot~canon~I0ad905ea87060796bf9af5bfacaef5f8c522122f","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-06-11 21:03:58.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-06-11 21:03:58.000000000","reason":"Change was abandoned"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-06-11 17:26:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}},"hashtags":[],"change_id":"I0ad905ea87060796bf9af5bfacaef5f8c522122f","subject":"fix(tvix/eval): allow negative substring lengths","status":"ABANDONED","created":"2023-06-02 12:57:05.000000000","updated":"2023-06-11 21:03:58.000000000","total_comment_count":8,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"2c3c4de3f020cbf1c60af24ae87609bd0c7d0af4","_number":8692,"virtual_id_number":8692,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:buildkite~result","value":1,"date":"2023-06-02 19:45:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2023-06-02 19:41:03.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-02 12:57:06.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-06-02 13:01:27.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-02 13:07:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"CC"},{"updated":"2023-06-02 19:41:22.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-06-11 20:52:37.000000000","updated_by":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"reviewer":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"state":"CC"}],"messages":[{"id":"c89bcc4d3055331f31fecc5ed8ccc5e391ce3727","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-02 12:57:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d840c1d03ac998fe452b170d47d671f5aa476d34","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 12:57:06.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24877","accounts_in_message":[],"_revision_number":1},{"id":"265a26b8489bacd2f2346d76d0129161779a7713","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-02 12:59:23.000000000","message":"Patch Set 1: Autosubmit+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c5e87229451f1439d61a52ce131292b0bdaba3cd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 13:01:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/24877","accounts_in_message":[],"_revision_number":1},{"id":"64e1394f50c44c9ff20b58bae87d3587e6ba6c20","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-06-02 13:07:43.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0c1cc2e7fa70d19608d3290ced5bf77e30a2cf0c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-02 19:41:03.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f66491b82719429fca425869279c25490b0c9744","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 19:41:04.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/24886","accounts_in_message":[],"_revision_number":2},{"id":"7c00b04507de1eb671a4463a7d60a0ff07ca16de","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-02 19:41:22.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/eval/src/builtins/mod.rs\n* tvix/eval/src/errors.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"1aeef9046b26f8f80990fe7cc5210083bbd1b8e3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 19:45:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/24886","accounts_in_message":[],"_revision_number":2},{"id":"719b5daf6f5fe6fc8f6e9af5dcd9ef8004689d8e","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-06-09 15:47:56.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"694c5878d06dace3e1f8f3e77945c35ca69f4fb2","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-11 17:03:04.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"982ca1a62ee638fa3255db255faa113783fe2bb2","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-06-11 17:26:13.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"baf122e6f94edfc2d8783498088edcac39dd006d","author":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"date":"2023-06-11 20:52:37.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2c3c4de3f020cbf1c60af24ae87609bd0c7d0af4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-11 21:03:58.000000000","message":"Abandoned\n\ncl/8746","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c35664ae9a797ac0b147b6d6630f72e9321c6dd2","revisions":{"1882133cdb0d20b7c11a1a23e9995c5a54572a17":{"kind":"REWORK","_number":1,"created":"2023-06-02 12:57:05.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/92/8692/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/92/8692/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/92/8692/1"}}},"commit":{"parents":[{"commit":"4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b","subject":"docs(nix/buildkite): escape \"release\" in warning","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b"}]}],"author":{"name":"Linus Heckemann","email":"git@sphalerite.org","date":"2023-06-01 19:22:59.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-02 12:57:02.000000000","tz":120},"subject":"fix(tvix/eval): allow negative substring lengths","message":"fix(tvix/eval): allow negative substring lengths\n\nNix uses string::substr without checking the sign of the length[1].\nThe NixOS testing infrastructure relies on this[2], and on the\nimplicit conversion of that to the maximum possible value for a\nsize_t.\n\n[1]: https://github.com/NixOS/nix/blob/ecae62020b64914d9859a71ce197d03688c6133c/src/libexpr/primops.cc#L3597\n[2]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/nixos/lib/testing/driver.nix#L29\n\nChange-Id: I0ad905ea87060796bf9af5bfacaef5f8c522122f\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1882133cdb0d20b7c11a1a23e9995c5a54572a17"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1882133cdb0d20b7c11a1a23e9995c5a54572a17"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b","is_merged_in_target_branch":true,"change_id":"I341c81d862204db06946512428910cada28481ca","change_number":8690,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c35664ae9a797ac0b147b6d6630f72e9321c6dd2":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-06-02 19:41:03.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/92/8692/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/92/8692/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/92/8692/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/92/8692/2"}}},"commit":{"parents":[{"commit":"d6e8a743d504b17410817a809bb8ae589e614152","subject":"refactor(tvix/eval): don\u0027t track idx twice in compile_param_pattern","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd6e8a743d504b17410817a809bb8ae589e614152"}]}],"author":{"name":"Linus Heckemann","email":"git@sphalerite.org","date":"2023-06-01 19:22:59.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-02 19:40:32.000000000","tz":120},"subject":"fix(tvix/eval): allow negative substring lengths","message":"fix(tvix/eval): allow negative substring lengths\n\nNix uses string::substr without checking the sign of the length[1].\nThe NixOS testing infrastructure relies on this[2], and on the\nimplicit conversion of that to the maximum possible value for a\nsize_t.\n\n[1]: https://github.com/NixOS/nix/blob/ecae62020b64914d9859a71ce197d03688c6133c/src/libexpr/primops.cc#L3597\n[2]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/nixos/lib/testing/driver.nix#L29\n\nChange-Id: I0ad905ea87060796bf9af5bfacaef5f8c522122f\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc35664ae9a797ac0b147b6d6630f72e9321c6dd2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc35664ae9a797ac0b147b6d6630f72e9321c6dd2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d6e8a743d504b17410817a809bb8ae589e614152","is_merged_in_target_branch":false,"change_id":"I27f9105ddb20d84342550b2a73b479a7764ee3fe","change_number":8699,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}