)]}'
{"id":"depot~8696","triplet_id":"depot~canon~Ibf6790d2484dc9cce8e424feeb5886664d498dc3","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-06-11 17:05:14.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},"1000076":{"account":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"last_update":"2023-06-11 20:59:34.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibf6790d2484dc9cce8e424feeb5886664d498dc3","subject":"fix(tvix/eval): emit only warnings on shadowed outputs","status":"MERGED","created":"2023-06-02 13:04:27.000000000","updated":"2023-06-11 20:59:34.000000000","submitted":"2023-06-11 20:59:34.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8696","meta_rev_id":"3b111b7f0157bcb44e8ab0acad2bd5e714182ba1","_number":8696,"virtual_id_number":8696,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-11 20:59:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-11 20:59:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-11 20:59:34.000000000","_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"}],"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-02 13:04:28.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-06-02 13:08:51.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-03 11:05:36.000000000","updated_by":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"reviewer":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"state":"CC"},{"updated":"2023-06-11 20:59:34.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fd22796f8d05f527fe6121788ca70f20e62fe978","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-02 13:04:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ffa124413a10dcb759b3a7834c626aea1ddd184","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 13:04:28.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24881","accounts_in_message":[],"_revision_number":1},{"id":"1e7d6dcf6e42c388302ab7b3e52a35267af0b82b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-02 13:08:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/24881","accounts_in_message":[],"_revision_number":1},{"id":"cf0a99253a27b3b405dc7cb2df8a21f447575c66","author":{"_account_id":1000076,"name":"Linus Heckemann","email":"git@sphalerite.org","username":"lheckemann"},"date":"2023-06-03 11:05:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"db3074ba8ec28121f2e642a9e30b39bdb3c16e25","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-11 17:05:14.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now explicitly code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/cli/src/derivation.rs\n* tvix/cli/src/errors.rs\n* tvix/eval/src/vm/generators.rs\n* tvix/eval/src/warnings.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"4301cd4a93101771ac339d5b1ed1d4d83a0affcf","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-11 17:05:36.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"19bb18612a5108b7b57916692cec09827072eb23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-06-11 20:53:32.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0f236101c70628cd68416e40cd4436f25fbd0d65","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-11 20:53:33.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/25083","accounts_in_message":[],"_revision_number":2},{"id":"13a5e2d9265d04e1c07c4fd5f120f3a58351f5db","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-11 20:59:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/25083","accounts_in_message":[],"_revision_number":2},{"id":"3b111b7f0157bcb44e8ab0acad2bd5e714182ba1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-06-11 20:59:34.000000000","message":"Change has been successfully rebased and submitted as 2b4ad47c16dc0fb114be0fd03526ffb871aa1875\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2b4ad47c16dc0fb114be0fd03526ffb871aa1875","revisions":{"c62f3856c9e34a2b533bec80df30455421be45e5":{"kind":"REWORK","_number":1,"created":"2023-06-02 13:04:27.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/96/8696/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/96/8696/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/96/8696/1"}}},"commit":{"parents":[{"commit":"4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b","subject":"docs(nix/buildkite): escape \"release\" in warning","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b"}]}],"author":{"name":"Linus Heckemann","email":"git@sphalerite.org","date":"2023-06-01 19:21:23.000000000","tz":120},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-06-02 13:04:22.000000000","tz":180},"subject":"fix(tvix/eval): emit only warnings on shadowed outputs","message":"fix(tvix/eval): emit only warnings on shadowed outputs\n\nUnfortunately, nixpkgs has at least one case[1] where the out environment\nvariable is shadowed -- though it doesn\u0027t cause a problem, since it\u0027s\nshadowed with the correct value, odd as this may be!\n\n[1]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/pkgs/development/python-modules/pybind11/default.nix#L19\n\nChange-Id: Ibf6790d2484dc9cce8e424feeb5886664d498dc3\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc62f3856c9e34a2b533bec80df30455421be45e5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc62f3856c9e34a2b533bec80df30455421be45e5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4cf0ee8ea302e070d12526bb42937e8c7e8c8f7b","is_merged_in_target_branch":true,"change_id":"I341c81d862204db06946512428910cada28481ca","change_number":8690,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5c4eb73fd06c2cb03065d506856ab0a0d8619712":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-06-11 20:53:32.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/96/8696/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/96/8696/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/96/8696/2"}}},"commit":{"parents":[{"commit":"7604833d2ae2a26f6262f17593e2748e978c410d","subject":"fix(views/kit): provide `lib` argument to lazy-deps","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7604833d2ae2a26f6262f17593e2748e978c410d"}]}],"author":{"name":"Linus Heckemann","email":"git@sphalerite.org","date":"2023-06-01 19:21:23.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-06-11 20:53:32.000000000","tz":0},"subject":"fix(tvix/eval): emit only warnings on shadowed outputs","message":"fix(tvix/eval): emit only warnings on shadowed outputs\n\nUnfortunately, nixpkgs has at least one case[1] where the out environment\nvariable is shadowed -- though it doesn\u0027t cause a problem, since it\u0027s\nshadowed with the correct value, odd as this may be!\n\n[1]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/pkgs/development/python-modules/pybind11/default.nix#L19\n\nChange-Id: Ibf6790d2484dc9cce8e424feeb5886664d498dc3\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5c4eb73fd06c2cb03065d506856ab0a0d8619712"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5c4eb73fd06c2cb03065d506856ab0a0d8619712"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7604833d2ae2a26f6262f17593e2748e978c410d","is_merged_in_target_branch":true,"change_id":"I6687bda77a3160b922156de9045d5f8565be0a61","change_number":8744,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"2b4ad47c16dc0fb114be0fd03526ffb871aa1875":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-06-11 20:59:34.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/96/8696/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/96/8696/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/96/8696/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/96/8696/3"}}},"commit":{"parents":[{"commit":"7604833d2ae2a26f6262f17593e2748e978c410d","subject":"fix(views/kit): provide `lib` argument to lazy-deps","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7604833d2ae2a26f6262f17593e2748e978c410d"}]}],"author":{"name":"Linus Heckemann","email":"git@sphalerite.org","date":"2023-06-01 19:21:23.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-06-11 20:59:34.000000000","tz":0},"subject":"fix(tvix/eval): emit only warnings on shadowed outputs","message":"fix(tvix/eval): emit only warnings on shadowed outputs\n\nUnfortunately, nixpkgs has at least one case[1] where the out environment\nvariable is shadowed -- though it doesn\u0027t cause a problem, since it\u0027s\nshadowed with the correct value, odd as this may be!\n\n[1]: https://github.com/NixOS/nixpkgs/blob/c7c298471676ac1c7789ab3c424fbcebecaa6791/pkgs/development/python-modules/pybind11/default.nix#L19\n\nChange-Id: Ibf6790d2484dc9cce8e424feeb5886664d498dc3\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8696\nAutosubmit: tazjin \u003ctazjin@tvl.su\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b4ad47c16dc0fb114be0fd03526ffb871aa1875"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b4ad47c16dc0fb114be0fd03526ffb871aa1875"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7604833d2ae2a26f6262f17593e2748e978c410d","is_merged_in_target_branch":true,"change_id":"I6687bda77a3160b922156de9045d5f8565be0a61","change_number":8744,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}