)]}'
{"id":"depot~8705","triplet_id":"depot~canon~Ic04fb80ec671a2ba11fa645090769c335fb7f58b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-06-20 10:07:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-06-15 19:40:30.000000000","reason":"Removed by \u003cGERRIT_ACCOUNT_1000034\u003e by clicking the attention icon","reason_account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}},"hashtags":[],"change_id":"Ic04fb80ec671a2ba11fa645090769c335fb7f58b","subject":"fix(tvix/eval): only finalise formal arguments if defaulting","status":"MERGED","created":"2023-06-03 00:12:48.000000000","updated":"2023-06-20 10:07:44.000000000","submitted":"2023-06-20 10:07:44.000000000","submitter":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8705","meta_rev_id":"5cc35e26b2581bf39d7771c4f988cbf743c98205","_number":8705,"virtual_id_number":8705,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-06-20 10:07:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-20 10:07:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-06-20 10:07:44.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-03 00:12:49.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-06-03 00:16:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-06-07 15:22:53.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"CC"},{"updated":"2023-06-20 10:02:41.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"912cfab0d3bc05deafd018b283f716c6defda15d","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-03 00:12:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4051cc473fad429c6079cbb311b1a89ab4f6f3b8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-03 00:12:49.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/24899","accounts_in_message":[],"_revision_number":1},{"id":"0f50906d7794a4e0ece919b3220b75388793b5ff","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-03 00:16:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/24899","accounts_in_message":[],"_revision_number":1},{"id":"2c8dd60bb56e7c99327bf9f26f604b33816961bf","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-03 00:18:25.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"07525912435d2cd6a15e52bde561270791a5db0d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-03 00:18:26.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/24900","accounts_in_message":[],"_revision_number":2},{"id":"3020f5d03e286a05d6d2bcd48977428fe6f94474","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-03 00:22:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/24900","accounts_in_message":[],"_revision_number":2},{"id":"9f3e8609a6d72666515dd72ae82c41f3a03a07c0","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-07 13:28:48.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e1b73aa50a6bff8474f6fb1f6e1913f0956651a0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:28:52.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/24965","accounts_in_message":[],"_revision_number":3},{"id":"8d10b24ce30169438d5498d1040f0ea5ccbbed45","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-07 13:31:36.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"9de599a98725f3c386dc4d9217ae3be057140999","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:31:37.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/24966","accounts_in_message":[],"_revision_number":4},{"id":"721d13aefa1c54b001364e97b1baa2a575a875ca","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:33:17.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/24965","accounts_in_message":[],"_revision_number":3},{"id":"2dd2f4ee1bc88cbb5779753e2510c635a06b0c34","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-07 13:33:37.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"1fcf66b5aca19ac0ac66ee9c80f4e1457cdcfa45","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:33:40.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/24967","accounts_in_message":[],"_revision_number":5},{"id":"113440d3e4c08ff247b44c5e5ab6a6be2d0d0814","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:35:54.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/24966","accounts_in_message":[],"_revision_number":4},{"id":"2cdcd7dc0d3fd1f397961f2f6d3f62c687510462","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-07 13:37:54.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/24967","accounts_in_message":[],"_revision_number":5},{"id":"f0bc3fe873aa97a546e40cde2921a00efd19ce06","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-07 15:22:53.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"153161960c30faf7eaeda62e7f01927097f1a510","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-11 16:22:06.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"cd85b5f166f6dec35fc3558f0d283b2565345feb","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-13 13:22:23.000000000","message":"Uploaded patch set 6: Autosubmit+1: Patch Set 5 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"0610d592064109bf50190e4d6fec14c03306d7a0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 13:22:24.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/25176","accounts_in_message":[],"_revision_number":6},{"id":"eba78e08c7e369033a01f274aef72f5bd28315c4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 13:27:09.000000000","message":"Patch Set 6: Verified-1\n\nBuild of patchset 6 failed: https://buildkite.com/tvl/depot/builds/25176","accounts_in_message":[],"_revision_number":6},{"id":"88ecd18dfb4c66d39d239c5e8beed97aa254b796","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-13 17:20:50.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"9b61bb929aeb754328e7fc3c7e8f531cef890fe5","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 17:20:51.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/25183","accounts_in_message":[],"_revision_number":7},{"id":"6eb140ba8c796fc5f01f69bb074f17ab4dcfe742","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-13 17:21:24.000000000","message":"Patch Set 7:\n\n(3 comments)","accounts_in_message":[],"_revision_number":7},{"id":"5d3c66201769d26d253c73778a20a96d5ee23b7d","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-13 17:26:06.000000000","message":"Uploaded patch set 8.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n","accounts_in_message":[],"_revision_number":8},{"id":"b916a410280759ef1d1eaaa9d234d18f502a2058","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 17:26:08.000000000","message":"Patch Set 8:\n\nStarted build for patchset #8 on: https://buildkite.com/tvl/depot/builds/25184","accounts_in_message":[],"_revision_number":8},{"id":"972a1dac08c9f1e4e0f6067e35c1128cd5e77524","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 17:26:16.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/25183","accounts_in_message":[],"_revision_number":7},{"id":"5819cd780fd8c1ec8082164ea398aae7a1558c03","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 17:32:07.000000000","message":"Patch Set 8: Verified+1\n\nBuild of patchset 8 passed: https://buildkite.com/tvl/depot/builds/25184","accounts_in_message":[],"_revision_number":8},{"id":"ad9dfb5dfb0726222ceeb4d87deee493880307d5","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-13 20:29:26.000000000","message":"Uploaded patch set 9: Patch Set 8 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"cb2d6bee30d73b8a95c14a3f8cf8df4d8b7e4b71","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 20:29:28.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/25195","accounts_in_message":[],"_revision_number":9},{"id":"040478d787c0395923353dc92d1bf6b1afb90e61","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-13 20:33:53.000000000","message":"Patch Set 9: Verified+1\n\nBuild of patchset 9 passed: https://buildkite.com/tvl/depot/builds/25195","accounts_in_message":[],"_revision_number":9},{"id":"bb2addf19d17d3ada7c58747b6e0fbec55048933","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-14 13:20:54.000000000","message":"Uploaded patch set 10: Patch Set 9 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":10},{"id":"19c06bcbbc3b4abce80db67c4fcc11b8d3b4f8a5","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-14 13:20:54.000000000","message":"Patch Set 10:\n\nStarted build for patchset #10 on: https://buildkite.com/tvl/depot/builds/25223","accounts_in_message":[],"_revision_number":10},{"id":"9335aef1de5548767b4f6bfe3335d6d0b2181699","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-14 13:23:17.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/25223","accounts_in_message":[],"_revision_number":10},{"id":"2b57f0127f5000448b7b375d7593af0cc5a231d5","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-15 17:16:13.000000000","message":"Uploaded patch set 11: Patch Set 10 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":11},{"id":"dc9c5891fbe1f7ac6d3123617093a1d10216cf57","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-15 17:16:16.000000000","message":"Patch Set 11:\n\nStarted build for patchset #11 on: https://buildkite.com/tvl/depot/builds/25271","accounts_in_message":[],"_revision_number":11},{"id":"9900fbdfc6d17f529887ad871dfc513a45dde95b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-15 17:17:31.000000000","message":"Patch Set 11: Verified-1\n\nBuild of patchset 11 failed: https://buildkite.com/tvl/depot/builds/25271","accounts_in_message":[],"_revision_number":11},{"id":"3ebf0eefc11d18baaa78ff29ef390df163a8dce6","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-15 18:40:07.000000000","message":"Uploaded patch set 12: Patch Set 11 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":12},{"id":"64f8fb031af32a1784386e3998306b5d85772279","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-15 18:40:10.000000000","message":"Patch Set 12:\n\nStarted build for patchset #12 on: https://buildkite.com/tvl/depot/builds/25282","accounts_in_message":[],"_revision_number":12},{"id":"ac8173086ea7505ec35e862837a508be60607260","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-15 18:46:13.000000000","message":"Patch Set 12: Verified+1\n\nBuild of patchset 12 passed: https://buildkite.com/tvl/depot/builds/25282","accounts_in_message":[],"_revision_number":12},{"id":"19534eeab34b829f6bd3d61a2a179bb3255f5ff1","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-19 22:13:57.000000000","message":"Uploaded patch set 13.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":13},{"id":"d9a417df89bca032c30511428d8704bfc7cbc0bc","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-19 22:13:58.000000000","message":"Patch Set 13:\n\nStarted build for patchset #13 on: https://buildkite.com/tvl/depot/builds/25347","accounts_in_message":[],"_revision_number":13},{"id":"6c4bd4a01ba11de61a5beea806f4eda2000561a0","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-19 22:14:33.000000000","message":"Patch Set 13:\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":13},{"id":"f0a5fbc285c68fb78848155fe38c5ca9156a9f57","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-06-19 22:18:47.000000000","message":"Patch Set 13: Verified+1\n\nBuild of patchset 13 passed: https://buildkite.com/tvl/depot/builds/25347","accounts_in_message":[],"_revision_number":13},{"id":"2f27b49db79f42a1e5490153c7814b7abb4a981d","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-06-20 10:02:41.000000000","message":"Patch Set 13: Code-Review+2\n\n(1 comment)\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tvix/cli/default.nix\n* tvix/eval/docs/known-optimisation-potential.md\n* tvix/eval/src/builtins/to_xml.rs\n* tvix/eval/src/compiler/mod.rs\n* tvix/eval/src/opcode.rs\n* tvix/eval/src/tests/tvix_tests/eval-okay-formals-miscompilation-b-261-regression.exp\n* tvix/eval/src/tests/tvix_tests/eval-okay-formals-miscompilation-b-261-regression.nix\n* tvix/eval/src/value/json.rs\n* tvix/eval/src/value/mod.rs\n* tvix/eval/src/vm/mod.rs\n* tvix/serde/src/de.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":13},{"id":"5cc35e26b2581bf39d7771c4f988cbf743c98205","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-06-20 10:07:44.000000000","message":"Change has been successfully rebased and submitted as 4516cd09c51b7a19707de0a5ba171c9592241a18","accounts_in_message":[],"_revision_number":14}],"current_revision_number":14,"current_revision":"4516cd09c51b7a19707de0a5ba171c9592241a18","revisions":{"0bd994e4fc950f297197a2861791f7372eee2dc5":{"kind":"REWORK","_number":1,"created":"2023-06-03 00:12:48.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/1"}}},"commit":{"parents":[{"commit":"fd2d87775082bbc91211a951d177e5ff4f1ef46c","subject":"fix(tvix/eval): use normal thunking behavior for default in formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfd2d87775082bbc91211a951d177e5ff4f1ef46c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nWe track whether we need to finalise `idx` by storing a boolean in the\nphantom `needs_finalise_idx`. This is of course quite ugly. If we want\nto continue on this road, we should at least add an internal sentinel\nvalue for this purpose.\n\nCode needs to be cleaned up, can we avoid having an extra local on the\nstack for every default expression?\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0bd994e4fc950f297197a2861791f7372eee2dc5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0bd994e4fc950f297197a2861791f7372eee2dc5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fd2d87775082bbc91211a951d177e5ff4f1ef46c","is_merged_in_target_branch":false,"change_id":"I64acbff2f251423eb72ce43e56a0603379305e1d","change_number":8704,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4dd9933ba2a09ba102902bdc0637fc54306dca2e":{"kind":"REWORK","_number":2,"created":"2023-06-03 00:18:25.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/2"}}},"commit":{"parents":[{"commit":"fd2d87775082bbc91211a951d177e5ff4f1ef46c","subject":"fix(tvix/eval): use normal thunking behavior for default in formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfd2d87775082bbc91211a951d177e5ff4f1ef46c"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:18:21.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nWe track whether we need to finalise `idx` by storing a boolean in the\nphantom `needs_finalise_idx`. This is of course quite ugly. If we want\nto continue on this road, we should at least add an internal sentinel\nvalue for this purpose.\n\nCode needs to be cleaned up, can we avoid having an extra local on the\nstack for every default expression?\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4dd9933ba2a09ba102902bdc0637fc54306dca2e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4dd9933ba2a09ba102902bdc0637fc54306dca2e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fd2d87775082bbc91211a951d177e5ff4f1ef46c","is_merged_in_target_branch":false,"change_id":"I64acbff2f251423eb72ce43e56a0603379305e1d","change_number":8704,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"db636cb57c90405f5b6c3ffa7c3db70a98dc9251":{"kind":"REWORK","_number":3,"created":"2023-06-07 13:28:48.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/3"}}},"commit":{"parents":[{"commit":"408df020a0a9482c3377328d21a49d8ba9be22ce","subject":"fix(tvix/eval): use normal thunking behavior for default in formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d408df020a0a9482c3377328d21a49d8ba9be22ce"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-07 13:28:35.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nWe track whether we need to finalise `idx` by storing a boolean in the\nphantom `needs_finalise_idx`. This is of course quite ugly. If we want\nto continue on this road, we should at least add an internal sentinel\nvalue for this purpose.\n\nCode needs to be cleaned up, can we avoid having an extra local on the\nstack for every default expression?\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddb636cb57c90405f5b6c3ffa7c3db70a98dc9251"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddb636cb57c90405f5b6c3ffa7c3db70a98dc9251"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"408df020a0a9482c3377328d21a49d8ba9be22ce","is_merged_in_target_branch":false,"change_id":"I64acbff2f251423eb72ce43e56a0603379305e1d","change_number":8704,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f6ae0ba62369b1a51ca2ee9bc3d413ebec199e82":{"kind":"REWORK","_number":4,"created":"2023-06-07 13:31:36.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/4"}}},"commit":{"parents":[{"commit":"408df020a0a9482c3377328d21a49d8ba9be22ce","subject":"fix(tvix/eval): use normal thunking behavior for default in formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d408df020a0a9482c3377328d21a49d8ba9be22ce"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-07 13:31:24.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df6ae0ba62369b1a51ca2ee9bc3d413ebec199e82"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df6ae0ba62369b1a51ca2ee9bc3d413ebec199e82"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"408df020a0a9482c3377328d21a49d8ba9be22ce","is_merged_in_target_branch":false,"change_id":"I64acbff2f251423eb72ce43e56a0603379305e1d","change_number":8704,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b15c16f905d731a51e15353384711ac0c554bbd5":{"kind":"REWORK","_number":5,"created":"2023-06-07 13:33:37.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/5"}}},"commit":{"parents":[{"commit":"408df020a0a9482c3377328d21a49d8ba9be22ce","subject":"fix(tvix/eval): use normal thunking behavior for default in formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d408df020a0a9482c3377328d21a49d8ba9be22ce"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-07 13:33:35.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db15c16f905d731a51e15353384711ac0c554bbd5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db15c16f905d731a51e15353384711ac0c554bbd5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"408df020a0a9482c3377328d21a49d8ba9be22ce","is_merged_in_target_branch":false,"change_id":"I64acbff2f251423eb72ce43e56a0603379305e1d","change_number":8704,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"fdcf4a019340d35565f8572a9725f6d59d38f85f":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2023-06-13 13:22:23.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/6"}}},"commit":{"parents":[{"commit":"7aa503679e7bcd62c8b6d2af923e60fafaad80d1","subject":"fix(tvix/eval): make tvix display values like nix-instantiate(1)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7aa503679e7bcd62c8b6d2af923e60fafaad80d1"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-13 13:22:18.000000000","tz":120},"subject":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand","message":"fix(tvix/eval): PoC fix for b/261 by finalising only on demand\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfdcf4a019340d35565f8572a9725f6d59d38f85f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfdcf4a019340d35565f8572a9725f6d59d38f85f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"7aa503679e7bcd62c8b6d2af923e60fafaad80d1","is_merged_in_target_branch":false,"change_id":"I1d534434b02e470bf5475b3758920ea81e3420dc","change_number":8760,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"988f898ed285d4401378a6a42ef92800876eebe4":{"kind":"REWORK","_number":7,"created":"2023-06-13 17:20:50.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/7"}}},"commit":{"parents":[{"commit":"8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56","subject":"fix(views/tvix): add fuse dependencies to external shell view","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-13 17:20:29.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d988f898ed285d4401378a6a42ef92800876eebe4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d988f898ed285d4401378a6a42ef92800876eebe4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56","is_merged_in_target_branch":true,"change_id":"Ie7b8c5b983e5b41bffe0748d0047ffcfd82072e8","change_number":8759,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1fab713c100cfedbf8d41e2f5ede4f60c39cdc75":{"kind":"REWORK","_number":8,"created":"2023-06-13 17:26:06.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/8"}}},"commit":{"parents":[{"commit":"8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56","subject":"fix(views/tvix): add fuse dependencies to external shell view","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-13 17:26:03.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fab713c100cfedbf8d41e2f5ede4f60c39cdc75"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1fab713c100cfedbf8d41e2f5ede4f60c39cdc75"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8d632af36e76df1bfaa7cfb2f04e4ca75a37ee56","is_merged_in_target_branch":true,"change_id":"Ie7b8c5b983e5b41bffe0748d0047ffcfd82072e8","change_number":8759,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0560ec9c4addf2dd964f6a37ec927ba09d70fdd4":{"kind":"TRIVIAL_REBASE","_number":9,"created":"2023-06-13 20:29:26.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/9"}}},"commit":{"parents":[{"commit":"151fe8acc37d0293fcd344bcbd39ecd71a7db95d","subject":"fix(tvix/eval): don\u0027t thunk home relative paths","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d151fe8acc37d0293fcd344bcbd39ecd71a7db95d"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-13 20:29:13.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0560ec9c4addf2dd964f6a37ec927ba09d70fdd4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0560ec9c4addf2dd964f6a37ec927ba09d70fdd4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"151fe8acc37d0293fcd344bcbd39ecd71a7db95d","is_merged_in_target_branch":false,"change_id":"Ie4b9dc68f62c86d6c7fd5f1c9460c850d97ed1ca","change_number":7041,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"68f6f87dea92e6ffa10b777c63334bde07d513c5":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2023-06-14 13:20:54.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/10"}}},"commit":{"parents":[{"commit":"8e5551329a4b13e516259126559d7d52ac998a5a","subject":"fix(tvix/eval): don\u0027t thunk home relative paths","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8e5551329a4b13e516259126559d7d52ac998a5a"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-14 13:20:26.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d68f6f87dea92e6ffa10b777c63334bde07d513c5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d68f6f87dea92e6ffa10b777c63334bde07d513c5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8e5551329a4b13e516259126559d7d52ac998a5a","is_merged_in_target_branch":true,"change_id":"Ie4b9dc68f62c86d6c7fd5f1c9460c850d97ed1ca","change_number":7041,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"45b05157c15ba235e706f425ad744fb45856475a":{"kind":"TRIVIAL_REBASE","_number":11,"created":"2023-06-15 17:16:13.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/11"}}},"commit":{"parents":[{"commit":"9ef0c67103e5fe73227e15bf834b94261778aa4f","subject":"chore(tvix/eval): fix markdown labeled link syntax","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ef0c67103e5fe73227e15bf834b94261778aa4f"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-15 17:16:09.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d45b05157c15ba235e706f425ad744fb45856475a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d45b05157c15ba235e706f425ad744fb45856475a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9ef0c67103e5fe73227e15bf834b94261778aa4f","is_merged_in_target_branch":false,"change_id":"I639dc0801090eaba56b61858e28204b5a0e631b6","change_number":8784,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8c80506926a1e592f024f27faddc938e9a81d330":{"kind":"TRIVIAL_REBASE","_number":12,"created":"2023-06-15 18:40:07.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/12"}}},"commit":{"parents":[{"commit":"2f5c1f58734d455e70f7d14fed98a8207f1badb2","subject":"chore(tvix/eval): fix markdown labeled link syntax","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2f5c1f58734d455e70f7d14fed98a8207f1badb2"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-15 18:39:47.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c80506926a1e592f024f27faddc938e9a81d330"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c80506926a1e592f024f27faddc938e9a81d330"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2f5c1f58734d455e70f7d14fed98a8207f1badb2","is_merged_in_target_branch":false,"change_id":"I639dc0801090eaba56b61858e28204b5a0e631b6","change_number":8784,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3ff65bf4ba5502815f04f345ce21a1c3d7f1f5fb":{"kind":"REWORK","_number":13,"created":"2023-06-19 22:13:57.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/13","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/13","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/13"}}},"commit":{"parents":[{"commit":"ad687ccaf49f6cfd3b23083ddd543a840c2212ae","subject":"chore(tvix/store/pathinfosvc): clippy","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dad687ccaf49f6cfd3b23083ddd543a840c2212ae"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-19 21:14:05.000000000","tz":120},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nWhen dealing with a formal argument in a function argument pattern that\nhas a default expression, there are two different things that can happen\nat runtime: Either we select its value from the passed attribute\nsuccessfully or we need to use the default expression. Both of these may\nbe thunks and both of these may need finalisers. However, in the former\ncase this is taken care of elsewhere, the value will always be finalised\nalready if necessary. In the latter case we may need to finalise the\nthunk resulting from the default expression. However, the thunk\ncorresponding to the expression may never end up in the local\u0027s stack\nslot. Since finalisation goes by stack slot (and not constants), we need\nto prevent a case where we don\u0027t fall back to the default expression,\nbut finalise anyways.\n\nPreviously, we worked around this by making `OpFinalise` ignore\nnon-thunks. Since finalisation of already evaluated thunks still\ncrashed, the faulty compilation of function pattern arguments could\nstill cause a crash.\n\nAs a new approach, we reinstate the old behavior of `OpFinalise` to\ncrash whenever encountering something that is either not a thunk or\ndoesn\u0027t need finalisation. This can also help catching (similar)\nmiscompilations in the future. To then prevent the crash, we need to\ntrack whether we have fallen back or not at runtime. This is done using\nan additional phantom on the stack that holds a new `FinaliseRequest`\nvalue. When it comes to finalisation we check this value and\nconditionally execute `OpFinalise` based on its value.\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ff65bf4ba5502815f04f345ce21a1c3d7f1f5fb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ff65bf4ba5502815f04f345ce21a1c3d7f1f5fb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ad687ccaf49f6cfd3b23083ddd543a840c2212ae","is_merged_in_target_branch":true,"change_id":"Ied4bed08e989791f832922da8776d2104035e28a","change_number":8812,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4516cd09c51b7a19707de0a5ba171c9592241a18":{"kind":"REWORK","_number":14,"created":"2023-06-20 10:07:44.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/05/8705/14","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/05/8705/14","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/05/8705/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/05/8705/14"}}},"commit":{"parents":[{"commit":"6656b865b608f7417b5a4b5df1e20811f48c7a82","subject":"docs(tvix/store): correct some cargo doc warnings","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6656b865b608f7417b5a4b5df1e20811f48c7a82"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-03 00:10:31.000000000","tz":120},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2023-06-20 10:07:44.000000000","tz":0},"subject":"fix(tvix/eval): only finalise formal arguments if defaulting","message":"fix(tvix/eval): only finalise formal arguments if defaulting\n\nWhen dealing with a formal argument in a function argument pattern that\nhas a default expression, there are two different things that can happen\nat runtime: Either we select its value from the passed attribute\nsuccessfully or we need to use the default expression. Both of these may\nbe thunks and both of these may need finalisers. However, in the former\ncase this is taken care of elsewhere, the value will always be finalised\nalready if necessary. In the latter case we may need to finalise the\nthunk resulting from the default expression. However, the thunk\ncorresponding to the expression may never end up in the local\u0027s stack\nslot. Since finalisation goes by stack slot (and not constants), we need\nto prevent a case where we don\u0027t fall back to the default expression,\nbut finalise anyways.\n\nPreviously, we worked around this by making `OpFinalise` ignore\nnon-thunks. Since finalisation of already evaluated thunks still\ncrashed, the faulty compilation of function pattern arguments could\nstill cause a crash.\n\nAs a new approach, we reinstate the old behavior of `OpFinalise` to\ncrash whenever encountering something that is either not a thunk or\ndoesn\u0027t need finalisation. This can also help catching (similar)\nmiscompilations in the future. To then prevent the crash, we need to\ntrack whether we have fallen back or not at runtime. This is done using\nan additional phantom on the stack that holds a new `FinaliseRequest`\nvalue. When it comes to finalisation we check this value and\nconditionally execute `OpFinalise` based on its value.\n\nResolves b/261 and b/265 (partially).\n\nChange-Id: Ic04fb80ec671a2ba11fa645090769c335fb7f58b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8705\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4516cd09c51b7a19707de0a5ba171c9592241a18"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4516cd09c51b7a19707de0a5ba171c9592241a18"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6656b865b608f7417b5a4b5df1e20811f48c7a82","is_merged_in_target_branch":true,"change_id":"I5053e3f7dcea01e75baa933e4986396583ff22e8","change_number":8831,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}