)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"7ffd80bee36bc5003d346dddfcb06118285cc11e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- To get around the fact that different people might have the depot"},{"line_number":20,"context_line":"  cloned in different places, and not everyone is going to have it"},{"line_number":21,"context_line":"  exported on their NIX_PATH, this uses a horrifically impure `toString"},{"line_number":22,"context_line":"  ../..` to embed the clone path of the depot inside of the built shell"},{"line_number":23,"context_line":"  script. This feels fine to *me* but if other people feel uncomfortable"},{"line_number":24,"context_line":"  with it I could be convinced that just expecting people to have the"},{"line_number":25,"context_line":"  depot on their `NIX_PATH` is the way to go"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"21fb6f72_0a9e829f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":71},"updated":"2020-07-03 23:23:12.000000000","message":"I think this bullet point doesn\u0027t apply anymore :)","commit_id":"a70edf58ca0522ee5e8c5cb154024648555560c8"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"ebcffa5cfa304a25a63df817db9768fe6a0f7748","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- To get around the fact that different people might have the depot"},{"line_number":20,"context_line":"  cloned in different places, and not everyone is going to have it"},{"line_number":21,"context_line":"  exported on their NIX_PATH, this uses a horrifically impure `toString"},{"line_number":22,"context_line":"  ../..` to embed the clone path of the depot inside of the built shell"},{"line_number":23,"context_line":"  script. This feels fine to *me* but if other people feel uncomfortable"},{"line_number":24,"context_line":"  with it I could be convinced that just expecting people to have the"},{"line_number":25,"context_line":"  depot on their `NIX_PATH` is the way to go"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3459ada8_b6673626","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":71},"in_reply_to":"21fb6f72_0a9e829f","updated":"2020-07-03 23:34:13.000000000","message":"Done","commit_id":"a70edf58ca0522ee5e8c5cb154024648555560c8"}],"bin/__dispatch.sh":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"69dd59ff31563cb5d434c7d5d89c6f89169b757d","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  hash-password)"},{"line_number":53,"context_line":"    attr\u003d\"tools.hash-password\""},{"line_number":54,"context_line":"    ;;"},{"line_number":55,"context_line":"  install-system)"},{"line_number":56,"context_line":"    attr\u003d\"ops.nixos.install-system\""},{"line_number":57,"context_line":"    ;;"},{"line_number":58,"context_line":"  *)"}],"source_content_type":"text/x-sh","patch_set":13,"id":"11d55729_22f967f7","line":55,"range":{"start_line":55,"start_character":2,"end_line":55,"end_character":9},"updated":"2020-07-05 15:43:24.000000000","message":"I think I would still name this `rebuild-system`. Other than that it LGTM","commit_id":"8bca963c269c385b8d34b329f8b34af108edee5b"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"ede7ba673b5f9a27402f90c0221bbbbf97ed9fe8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  hash-password)"},{"line_number":53,"context_line":"    attr\u003d\"tools.hash-password\""},{"line_number":54,"context_line":"    ;;"},{"line_number":55,"context_line":"  install-system)"},{"line_number":56,"context_line":"    attr\u003d\"ops.nixos.install-system\""},{"line_number":57,"context_line":"    ;;"},{"line_number":58,"context_line":"  *)"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9218f1fd_241f578e","line":55,"range":{"start_line":55,"start_character":2,"end_line":55,"end_character":9},"in_reply_to":"11d55729_22f967f7","updated":"2020-07-06 15:16:08.000000000","message":"Done","commit_id":"8bca963c269c385b8d34b329f8b34af108edee5b"}],"ci-builds.nix":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"f5f22f5b50e6246827f6ca9b162ad573a268683b","unresolved":true,"context_lines":[{"line_number":102,"context_line":"  ];"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  glittershark \u003d with depot.users.glittershark; ["},{"line_number":105,"context_line":"    system.system.chupacabraSystem"},{"line_number":106,"context_line":"    xanthous"},{"line_number":107,"context_line":"  ];"},{"line_number":108,"context_line":"})"}],"source_content_type":"text/x-nix","patch_set":10,"id":"a51b7791_e6d0801e","line":105,"range":{"start_line":105,"start_character":18,"end_line":105,"end_character":34},"updated":"2020-07-03 23:24:33.000000000","message":"should this also be done with systemFor maybe? (also my machines)","commit_id":"a70edf58ca0522ee5e8c5cb154024648555560c8"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"ebcffa5cfa304a25a63df817db9768fe6a0f7748","unresolved":false,"context_lines":[{"line_number":102,"context_line":"  ];"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  glittershark \u003d with depot.users.glittershark; ["},{"line_number":105,"context_line":"    system.system.chupacabraSystem"},{"line_number":106,"context_line":"    xanthous"},{"line_number":107,"context_line":"  ];"},{"line_number":108,"context_line":"})"}],"source_content_type":"text/x-nix","patch_set":10,"id":"f8a25d51_3ea2f7b7","line":105,"range":{"start_line":105,"start_character":18,"end_line":105,"end_character":34},"in_reply_to":"a51b7791_e6d0801e","updated":"2020-07-03 23:34:13.000000000","message":"Done","commit_id":"a70edf58ca0522ee5e8c5cb154024648555560c8"}],"ops/nixos/all-systems.nix":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b4cb4e7e89837c13238327dbb5648d59ea2426e5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"}],"source_content_type":"text/x-nix","patch_set":3,"id":"ba3a8c0d_7338db6c","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":8},"updated":"2020-07-03 14:54:50.000000000","message":"missing whitby","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"ca5f7bcd79c92ac9593eac361f35884aeac839f6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"}],"source_content_type":"text/x-nix","patch_set":3,"id":"8153bfe1_df0113a7","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":8},"in_reply_to":"506e3dcb_945c30aa","updated":"2020-07-03 22:25:56.000000000","message":"lets not bikeshed, and rather just change whitby to support it :-)","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"409cf42190e805f6626cabb4abb08ba37fc74b3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"}],"source_content_type":"text/x-nix","patch_set":3,"id":"1d52282c_e2245712","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":8},"in_reply_to":"8153bfe1_df0113a7","updated":"2020-07-03 22:59:00.000000000","message":"Done","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"3ca2e0a0c2ec21743021f4e5f33ee7acaa4f5dd1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"}],"source_content_type":"text/x-nix","patch_set":3,"id":"506e3dcb_945c30aa","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":8},"in_reply_to":"ba3a8c0d_7338db6c","updated":"2020-07-03 15:38:23.000000000","message":"yeah, whitby is a little more tightly coupled to returning a system rather than a nixos configuration, so I wanted to get a round of bikeshedding in before I refactored that to support this. I\u0027ll make sure to add it before submitting.","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b4cb4e7e89837c13238327dbb5648d59ea2426e5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"},{"line_number":5,"context_line":"  frog"},{"line_number":6,"context_line":"]) ++"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"(with depot.users.glittershark.system.system; ["}],"source_content_type":"text/x-nix","patch_set":3,"id":"3411dbe5_cc8e6dd2","line":5,"range":{"start_line":4,"start_character":2,"end_line":5,"end_character":6},"updated":"2020-07-03 14:54:50.000000000","message":"Is this right? (camden vs. camdenSystem etc.)","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"3ca2e0a0c2ec21743021f4e5f33ee7acaa4f5dd1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"},{"line_number":5,"context_line":"  frog"},{"line_number":6,"context_line":"]) ++"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"(with depot.users.glittershark.system.system; ["}],"source_content_type":"text/x-nix","patch_set":3,"id":"49f46e5d_102578d4","line":5,"range":{"start_line":4,"start_character":2,"end_line":5,"end_character":6},"in_reply_to":"3411dbe5_cc8e6dd2","updated":"2020-07-03 15:38:23.000000000","message":"yes - in order to look into the hostname we need the full nixos configuration set (to then call `.config.networking.hostName` on) - the build itself then calls `.system` on these.","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"ca5f7bcd79c92ac9593eac361f35884aeac839f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ depot, ... }:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"(with depot.users.tazjin.nixos; ["},{"line_number":4,"context_line":"  camden"},{"line_number":5,"context_line":"  frog"},{"line_number":6,"context_line":"]) ++"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"(with depot.users.glittershark.system.system; ["}],"source_content_type":"text/x-nix","patch_set":3,"id":"17530e34_1952e687","line":5,"range":{"start_line":4,"start_character":2,"end_line":5,"end_character":6},"in_reply_to":"49f46e5d_102578d4","updated":"2020-07-03 22:25:56.000000000","message":"Ack","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"}],"ops/nixos/default.nix":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"dddc147def118b2c71038dce42f682462c2cffa7","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    echo \"Rebuilding NixOS for $HOSTNAME\""},{"line_number":40,"context_line":"    system\u003d$(nix-build -E \"((import ${toString ../..} {}).ops.nixos.findSystem \\\"$HOSTNAME\\\").system\" --no-out-link --show-trace)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    nix-env -p /nix/var/nix/profiles/system --set $system"},{"line_number":43,"context_line":"    $system/bin/switch-to-configuration switch"}],"source_content_type":"text/x-nix","patch_set":3,"id":"7d6bd5d8_cd47cca4","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":52},"updated":"2020-07-03 22:30:21.000000000","message":"take the passed in `depotPath` instead, this way - if we change this to a saner mechanism of passing the path - it\u0027ll be easier to update","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"409cf42190e805f6626cabb4abb08ba37fc74b3f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    echo \"Rebuilding NixOS for $HOSTNAME\""},{"line_number":40,"context_line":"    system\u003d$(nix-build -E \"((import ${toString ../..} {}).ops.nixos.findSystem \\\"$HOSTNAME\\\").system\" --no-out-link --show-trace)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    nix-env -p /nix/var/nix/profiles/system --set $system"},{"line_number":43,"context_line":"    $system/bin/switch-to-configuration switch"}],"source_content_type":"text/x-nix","patch_set":3,"id":"92b1f745_0326fc23","line":40,"range":{"start_line":40,"start_character":47,"end_line":40,"end_character":52},"in_reply_to":"7d6bd5d8_cd47cca4","updated":"2020-07-03 22:59:00.000000000","message":"Done","commit_id":"dadd6ca6c84c6249b4166825657aa44d1fa06d52"}]}