)]}'
{"id":"depot~8974","triplet_id":"depot~canon~I821016d9a58ec441ee081b0b9f01c9240723af0b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-07-21 19:01:49.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-07-21 19:01:49.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-07-21 19:01:49.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I821016d9a58ec441ee081b0b9f01c9240723af0b","subject":"refactor(tvix/store): use bytes for node names and symlink targets","status":"MERGED","created":"2023-07-18 19:52:46.000000000","updated":"2023-07-21 19:01:49.000000000","submitted":"2023-07-21 19:01:49.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"8974","meta_rev_id":"c0e302742f40abdb9acb63465bb873c9bf0873e8","_number":8974,"virtual_id_number":8974,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-07-21 19:01:49.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-21 19:01:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-07-21 19:01:49.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-18 19:52:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2023-07-18 19:52:46.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-07-18 19:52:50.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-07-18 19:57:34.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-07-21 17:46:38.000000000","updated_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-07-21 19:01:49.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9045e54a2567ac57dc276ea0e7bff3f4f848c0f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 19:52:46.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"59bd90cb1c40a462d915cc7c107d7f8951fe46bc","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 19:52:46.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/cli/src/nix_compat.rs\n* tvix/cli/src/tvix_io.rs\n* tvix/eval/src/builtins/impure.rs\n* tvix/eval/src/io.rs\n* tvix/eval/src/vm/generators.rs\n* tvix/nix-compat/src/nar/writer/mod.rs\n* tvix/store/protos/castore.pb.go\n* tvix/store/protos/castore.proto\n* tvix/store/src/bin/tvix-store.rs\n* tvix/store/src/directoryservice/traverse.rs\n* tvix/store/src/fuse/inode_tracker.rs\n* tvix/store/src/fuse/inodes.rs\n* tvix/store/src/fuse/mod.rs\n* tvix/store/src/fuse/tests.rs\n* tvix/store/src/import.rs\n* tvix/store/src/nar/mod.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n* tvix/store/src/proto/mod.rs\n* tvix/store/src/proto/tests/directory.rs\n* tvix/store/src/proto/tests/directory_nodes_iterator.rs\n* tvix/store/src/proto/tests/grpc_directoryservice.rs\n* tvix/store/src/proto/tests/grpc_pathinfoservice.rs\n* tvix/store/src/proto/tests/pathinfo.rs\n* tvix/store/src/store_io.rs\n* tvix/store/src/tests/fixtures.rs\n* tvix/store/src/tests/import.rs\n* tvix/store/src/tests/nar_renderer.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"5cb6dd2a50a46b944a3d8e5d1fc59d049b24c5b7","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 19:52:46.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* tvix/cli/src/nix_compat.rs\n* tvix/cli/src/tvix_io.rs\n* tvix/eval/src/builtins/impure.rs\n* tvix/eval/src/io.rs\n* tvix/eval/src/vm/generators.rs\n* tvix/nix-compat/src/nar/writer/mod.rs\n* tvix/store/protos/castore.pb.go\n* tvix/store/protos/castore.proto\n* tvix/store/src/bin/tvix-store.rs\n* tvix/store/src/directoryservice/traverse.rs\n* tvix/store/src/fuse/inode_tracker.rs\n* tvix/store/src/fuse/inodes.rs\n* tvix/store/src/fuse/mod.rs\n* tvix/store/src/fuse/tests.rs\n* tvix/store/src/import.rs\n* tvix/store/src/nar/mod.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n* tvix/store/src/proto/mod.rs\n* tvix/store/src/proto/tests/directory.rs\n* tvix/store/src/proto/tests/directory_nodes_iterator.rs\n* tvix/store/src/proto/tests/grpc_directoryservice.rs\n* tvix/store/src/proto/tests/grpc_pathinfoservice.rs\n* tvix/store/src/proto/tests/pathinfo.rs\n* tvix/store/src/store_io.rs\n* tvix/store/src/tests/fixtures.rs\n* tvix/store/src/tests/import.rs\n* tvix/store/src/tests/nar_renderer.rs\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"367d6899334414aa93bae01cff6b9189cb3c3901","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 19:52:50.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/25758","accounts_in_message":[],"_revision_number":1},{"id":"81c988fef0dd42361907dba7dc704fb40bf4c13e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 19:57:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/25758","accounts_in_message":[],"_revision_number":1},{"id":"4f62258ecb9e9b7a06828306809ad7e2e1120dad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 20:03:29.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"216c51cba85c7d0ead179259648dc3b0141f4ceb","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:03:33.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/25761","accounts_in_message":[],"_revision_number":2},{"id":"08758dae90030e5ecb7ed7ee4c56b4c292facb22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 20:05:37.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n","accounts_in_message":[],"_revision_number":3},{"id":"96070f77110fba866ddf5629039118c05c35e4dd","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:05:41.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/25764","accounts_in_message":[],"_revision_number":3},{"id":"8428a9daf95738acd1f384e3d7eab04a2fc06484","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:07:38.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/25761","accounts_in_message":[],"_revision_number":2},{"id":"d4324793805f9b1678b9cf0f11db12abaa3dc90c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:10:02.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/25764","accounts_in_message":[],"_revision_number":3},{"id":"b6b7d1b28168517758a70216546b2594f84b1346","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 20:11:27.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"ea77dee94b661cc036d26e059e8fa30b8f85cebc","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:11:28.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/25765","accounts_in_message":[],"_revision_number":4},{"id":"753c577714d5d8def7e492d1e9bbf7028312792c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 20:13:37.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n","accounts_in_message":[],"_revision_number":5},{"id":"8d6d1b44e985fe2af9814ab59e581c6bdcd257d3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:13:39.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/25767","accounts_in_message":[],"_revision_number":5},{"id":"bae6fee296ecf766ca88df2a3488c6166a8a45fd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:15:22.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/25765","accounts_in_message":[],"_revision_number":4},{"id":"7aa0b062c786c3ead9294bb9298300d342f45033","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-18 20:16:01.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/25767","accounts_in_message":[],"_revision_number":5},{"id":"0ad647e6f5ccc4a1e1e800b12b0c1a6b53908308","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-18 20:56:25.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"affc9869b319c7490b3eca1ebf413500c0540b37","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-19 15:27:39.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"929945f42e7f05b51617f51f9e357412cc3fc428","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-19 15:27:44.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"ebf82ff26242cf976baef84c1d819f3dd054cb95","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-19 15:27:47.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/25770","accounts_in_message":[],"_revision_number":6},{"id":"258d696e856bf657896c11b828b3d9372070f964","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-19 15:32:00.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/25770","accounts_in_message":[],"_revision_number":6},{"id":"2d6037d70cb8bf1ece39212df11a29eee3dce5b3","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-07-20 10:25:28.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6},{"id":"82d044cef5c80bd27dcb9337687aa3353dccfb93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-20 11:40:13.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"5557e6489910331b6c1bc72b8f927b5eda36098d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-20 11:40:16.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/25777","accounts_in_message":[],"_revision_number":7},{"id":"db007ec1d67e863be6e2fe1e91f177d1ad0c54c3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-20 11:44:38.000000000","message":"Patch Set 7: Verified-1\n\nBuild of patchset 7 failed: https://buildkite.com/tvl/depot/builds/25777","accounts_in_message":[],"_revision_number":7},{"id":"690fbff1a15b261fd214ac61c3a21f41eab69bdd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-20 11:46:25.000000000","message":"Uploaded patch set 8.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":8},{"id":"d720ef950369dfc6c23e785050ebdb055c4095b9","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-20 11:46:25.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"3675c64766652547dd7287dfb319a660e0d1513f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-20 11:46:27.000000000","message":"Patch Set 8:\n\nStarted build for patchset #8 on: https://buildkite.com/tvl/depot/builds/25781","accounts_in_message":[],"_revision_number":8},{"id":"bccdd7015bbb1b76c7419ba27564d993f1a14530","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-20 11:47:58.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"e527a497485e4a4c83f0ae3c7f1211cdfe784b5b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-20 11:50:46.000000000","message":"Patch Set 8: Verified+1\n\nBuild of patchset 8 passed: https://buildkite.com/tvl/depot/builds/25781","accounts_in_message":[],"_revision_number":8},{"id":"4a82b3412ca2284428b5d02e217945979a31c6a8","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2023-07-21 17:46:38.000000000","message":"Patch Set 8: Code-Review+2","accounts_in_message":[],"_revision_number":8},{"id":"89808ade7047d5a79ddd843a20965d90f7063263","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-07-21 18:55:18.000000000","message":"Uploaded patch set 9.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Code-Review+2 (copy condition: \"((is:ANY AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"0c95939d5ddfb395290970e7b4fe3eead64d9842","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-21 18:55:19.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/25801","accounts_in_message":[],"_revision_number":9},{"id":"5cd561eb3c273f5aca785cb339332b132e93ff4f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-07-21 19:00:35.000000000","message":"Patch Set 9: Verified+1\n\nBuild of patchset 9 passed: https://buildkite.com/tvl/depot/builds/25801","accounts_in_message":[],"_revision_number":9},{"id":"c0e302742f40abdb9acb63465bb873c9bf0873e8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-07-21 19:01:49.000000000","message":"Change has been successfully rebased and submitted as 72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e\n\n8 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e","revisions":{"cde892ba89b3c125c9f22e0605dda4719620514d":{"kind":"REWORK","_number":1,"created":"2023-07-18 19:52:46.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/1"}}},"commit":{"parents":[{"commit":"e865c67289d992caeacd479885858642b7bdd12e","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de865c67289d992caeacd479885858642b7bdd12e"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 19:52:34.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcde892ba89b3c125c9f22e0605dda4719620514d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcde892ba89b3c125c9f22e0605dda4719620514d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e865c67289d992caeacd479885858642b7bdd12e","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9bbe5c2399e360592e92b662ae46e6833fb7417b":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-07-18 20:03:29.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/2"}}},"commit":{"parents":[{"commit":"a8c6196db310ae26974dc93528b7bc29b85f4ff0","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da8c6196db310ae26974dc93528b7bc29b85f4ff0"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 20:03:23.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9bbe5c2399e360592e92b662ae46e6833fb7417b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9bbe5c2399e360592e92b662ae46e6833fb7417b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a8c6196db310ae26974dc93528b7bc29b85f4ff0","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"77e49f0bbb4254956866ed8657cb6e8ae635e76c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-18 20:05:37.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/3"}}},"commit":{"parents":[{"commit":"dddf48ff1266425795793272f9717c03abd9d886","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddddf48ff1266425795793272f9717c03abd9d886"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 20:05:21.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77e49f0bbb4254956866ed8657cb6e8ae635e76c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77e49f0bbb4254956866ed8657cb6e8ae635e76c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"dddf48ff1266425795793272f9717c03abd9d886","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"74739d7d59e9fcf6c7f35d7ffc4f50405a8f67cb":{"kind":"REWORK","_number":4,"created":"2023-07-18 20:11:27.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/4"}}},"commit":{"parents":[{"commit":"dddf48ff1266425795793272f9717c03abd9d886","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddddf48ff1266425795793272f9717c03abd9d886"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 20:11:24.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d74739d7d59e9fcf6c7f35d7ffc4f50405a8f67cb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d74739d7d59e9fcf6c7f35d7ffc4f50405a8f67cb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"dddf48ff1266425795793272f9717c03abd9d886","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"fe76d04666e20ed98e44e8c38d79fe855ab10af6":{"kind":"REWORK","_number":5,"created":"2023-07-18 20:13:37.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/5"}}},"commit":{"parents":[{"commit":"084661bca1538f366626e4acb13bd69e7a776375","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d084661bca1538f366626e4acb13bd69e7a776375"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 20:13:32.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe76d04666e20ed98e44e8c38d79fe855ab10af6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe76d04666e20ed98e44e8c38d79fe855ab10af6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"084661bca1538f366626e4acb13bd69e7a776375","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"38f6264f7b258d5a8f2f9ef18ac29ec63d0d4217":{"kind":"REWORK","_number":6,"created":"2023-07-19 15:27:44.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/6"}}},"commit":{"parents":[{"commit":"b18beda38b68503beb10ba3a4ea0e64f46ba923d","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db18beda38b68503beb10ba3a4ea0e64f46ba923d"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-19 15:26:48.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d38f6264f7b258d5a8f2f9ef18ac29ec63d0d4217"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d38f6264f7b258d5a8f2f9ef18ac29ec63d0d4217"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b18beda38b68503beb10ba3a4ea0e64f46ba923d","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"be0b6cd43ae18eb6d67dafb527417144a99ea8f9":{"kind":"REWORK","_number":7,"created":"2023-07-20 11:40:13.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/7"}}},"commit":{"parents":[{"commit":"9fee443bc08ecca9d48eee59abf4f5cc74644d44","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9fee443bc08ecca9d48eee59abf4f5cc74644d44"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-20 11:34:10.000000000","tz":180},"subject":"feat(tvix/store): use bytes for node names and symlink targets","message":"feat(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbe0b6cd43ae18eb6d67dafb527417144a99ea8f9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbe0b6cd43ae18eb6d67dafb527417144a99ea8f9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9fee443bc08ecca9d48eee59abf4f5cc74644d44","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c30d26cd84334831bc7a4cdf2cd4abc004f7621a":{"kind":"REWORK","_number":8,"created":"2023-07-20 11:46:25.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/8"}}},"commit":{"parents":[{"commit":"67b2007fc0446894e9eddef4701a375ec0e6b68c","subject":"feat(tvix/nix-compat): have StorePath accept bytes","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d67b2007fc0446894e9eddef4701a375ec0e6b68c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-20 11:46:03.000000000","tz":180},"subject":"refactor(tvix/store): use bytes for node names and symlink targets","message":"refactor(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc30d26cd84334831bc7a4cdf2cd4abc004f7621a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc30d26cd84334831bc7a4cdf2cd4abc004f7621a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"67b2007fc0446894e9eddef4701a375ec0e6b68c","is_merged_in_target_branch":false,"change_id":"I6b4e62a6fa5c4bec13b535279e73444f0b83ad35","change_number":8973,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a93ceb530659b5f5ceed72b569996b6e42584c01":{"kind":"REWORK","_number":9,"created":"2023-07-21 18:55:18.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/74/8974/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/9"}}},"commit":{"parents":[{"commit":"638f3e874d5eb6c157ffd065e593ee1a8a14d3e0","subject":"feat(tvix/store/fuse): implement open explicitly","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d638f3e874d5eb6c157ffd065e593ee1a8a14d3e0"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-21 18:55:04.000000000","tz":180},"subject":"refactor(tvix/store): use bytes for node names and symlink targets","message":"refactor(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da93ceb530659b5f5ceed72b569996b6e42584c01"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da93ceb530659b5f5ceed72b569996b6e42584c01"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"638f3e874d5eb6c157ffd065e593ee1a8a14d3e0","is_merged_in_target_branch":true,"change_id":"I9c19448df6831a3537252f99210374f2126ecfc0","change_number":8886,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e":{"kind":"NO_CODE_CHANGE","_number":10,"created":"2023-07-21 19:01:49.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/74/8974/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/74/8974/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/74/8974/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/74/8974/10"}}},"commit":{"parents":[{"commit":"638f3e874d5eb6c157ffd065e593ee1a8a14d3e0","subject":"feat(tvix/store/fuse): implement open explicitly","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d638f3e874d5eb6c157ffd065e593ee1a8a14d3e0"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-07-18 16:37:25.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-07-21 19:01:49.000000000","tz":0},"subject":"refactor(tvix/store): use bytes for node names and symlink targets","message":"refactor(tvix/store): use bytes for node names and symlink targets\n\nSome paths might use names that are not valid UTF-8. We should be able\nto represent them.\n\nWe don\u0027t actually need to touch the PathInfo structures, as they need to\nrepresent StorePaths, which come with their own harder restrictions,\nwhich can\u0027t encode non-UTF8 data.\n\nWhile this doesn\u0027t change any of the wire format of the gRPC messages,\nit does however change the interface of tvix_eval::EvalIO - its\nread_dir() method does now return a list of Vec\u003cu8\u003e, rather than\nSmolStr. Maybe this should be OsString instead?\n\nChange-Id: I821016d9a58ec441ee081b0b9f01c9240723af0b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/8974\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72e82ffcb11b1aaf1f1cc8db4189ced5ec0aa42e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"638f3e874d5eb6c157ffd065e593ee1a8a14d3e0","is_merged_in_target_branch":true,"change_id":"I9c19448df6831a3537252f99210374f2126ecfc0","change_number":8886,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}