)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"85fe4befa11cc398db3d15c58a1cbc3ff12ec845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8a6c3201_8c0ee8a2","updated":"2023-07-21 18:02:51.000000000","message":"Modulo trait impl for easier .into()","commit_id":"712501c83a59252a6db344d8c9afe1064ab5694e"}],"tvix/store/build.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"54e21a42e51c08b8439266c24091c8ad46486271","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    // https://github.com/hyperium/tonic/issues/908"},{"line_number":16,"context_line":"    let mut config \u003d prost_build::Config::new();"},{"line_number":17,"context_line":"    config.bytes(\u0026[\".\"]);"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    builder"},{"line_number":20,"context_line":"        .build_server(true)"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"c4e8c06b_88b375d8","line":17,"updated":"2023-07-19 15:57:22.000000000","message":"We might want to explicitly select fields, and might also want to change B3Digest to internally use Bytes.","commit_id":"d5f17e4d5235023c035c25f26a83da2007138e9c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"997e1d1c0b4c0cdac70fc2fbb5acff71b681e635","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    // https://github.com/hyperium/tonic/issues/908"},{"line_number":16,"context_line":"    let mut config \u003d prost_build::Config::new();"},{"line_number":17,"context_line":"    config.bytes(\u0026[\".\"]);"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    builder"},{"line_number":20,"context_line":"        .build_server(true)"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"0aca6f73_7a772d8c","line":17,"in_reply_to":"c4e8c06b_88b375d8","updated":"2023-07-20 14:18:48.000000000","message":"B3Digest is switched to bytes::Bytes in cl/8978, and I\u0027m not too sure about explicitly selecting fields anymore.","commit_id":"d5f17e4d5235023c035c25f26a83da2007138e9c"}],"tvix/store/src/directoryservice/grpc.rs":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"85fe4befa11cc398db3d15c58a1cbc3ff12ec845","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                let s \u003d grpc_client"},{"line_number":168,"context_line":"                    .get(proto::GetDirectoryRequest {"},{"line_number":169,"context_line":"                        recursive: true,"},{"line_number":170,"context_line":"                        by_what: Some(ByWhat::Digest(root_directory_digest_cpy.into())),"},{"line_number":171,"context_line":"                    })"},{"line_number":172,"context_line":"                    .await?"},{"line_number":173,"context_line":"                    .into_inner();"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"4465a5a4_2693d4ed","line":170,"updated":"2023-07-21 18:02:51.000000000","message":"you should probably have Into\u003cByWhat\u003e for B3Digest?","commit_id":"712501c83a59252a6db344d8c9afe1064ab5694e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"c89bfa2ca2665b8bb1e887cee9387debac2de889","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                let s \u003d grpc_client"},{"line_number":168,"context_line":"                    .get(proto::GetDirectoryRequest {"},{"line_number":169,"context_line":"                        recursive: true,"},{"line_number":170,"context_line":"                        by_what: Some(ByWhat::Digest(root_directory_digest_cpy.into())),"},{"line_number":171,"context_line":"                    })"},{"line_number":172,"context_line":"                    .await?"},{"line_number":173,"context_line":"                    .into_inner();"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"f38b8958_21456e5c","line":170,"in_reply_to":"16307887_0f0b6be7","updated":"2023-07-21 19:01:15.000000000","message":"Ack","commit_id":"712501c83a59252a6db344d8c9afe1064ab5694e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"677c6aca123955f9286f70d841370f9eb67d4572","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                let s \u003d grpc_client"},{"line_number":168,"context_line":"                    .get(proto::GetDirectoryRequest {"},{"line_number":169,"context_line":"                        recursive: true,"},{"line_number":170,"context_line":"                        by_what: Some(ByWhat::Digest(root_directory_digest_cpy.into())),"},{"line_number":171,"context_line":"                    })"},{"line_number":172,"context_line":"                    .await?"},{"line_number":173,"context_line":"                    .into_inner();"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"16307887_0f0b6be7","line":170,"in_reply_to":"4465a5a4_2693d4ed","updated":"2023-07-21 18:51:12.000000000","message":"Uuh, I\u0027d like this request type to be specific. We might end up having other request types, and just because we\u0027re holding a blake3 digest here, doesn\u0027t necessarily mean it\u0027s this specific request type.","commit_id":"712501c83a59252a6db344d8c9afe1064ab5694e"}]}
