)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2229784f_b6838427","updated":"2023-07-31 21:18:50.000000000","message":"we have gone on the review in realtime, so most of items are solved in further CLs","commit_id":"a9f93801b05668bcfe7f4df29c8323b5d60f8814"}],"tvix/nix-compat/Cargo.toml":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[dependencies]"},{"line_number":9,"context_line":"anyhow \u003d \"1.0.68\""},{"line_number":10,"context_line":"bstr \u003d { version \u003d \"1.6.0\", features \u003d [\"std\", \"alloc\", \"unicode\", \"serde\"] }"},{"line_number":11,"context_line":"data-encoding \u003d \"2.3.3\""},{"line_number":12,"context_line":"glob \u003d \"0.3.0\""},{"line_number":13,"context_line":"serde \u003d { version \u003d \"1.0\", features \u003d [\"derive\"] }"}],"source_content_type":"text/x-toml","patch_set":3,"id":"b5e664f3_d5e9164f","line":10,"updated":"2023-07-31 21:18:50.000000000","message":"cut down on `std` ?","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[dependencies]"},{"line_number":9,"context_line":"anyhow \u003d \"1.0.68\""},{"line_number":10,"context_line":"bstr \u003d { version \u003d \"1.6.0\", features \u003d [\"std\", \"alloc\", \"unicode\", \"serde\"] }"},{"line_number":11,"context_line":"data-encoding \u003d \"2.3.3\""},{"line_number":12,"context_line":"glob \u003d \"0.3.0\""},{"line_number":13,"context_line":"serde \u003d { version \u003d \"1.0\", features \u003d [\"derive\"] }"}],"source_content_type":"text/x-toml","patch_set":3,"id":"5873e391_788db536","line":10,"in_reply_to":"b5e664f3_d5e9164f","updated":"2023-07-31 21:33:01.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"}],"tvix/nix-compat/src/derivation/mod.rs":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    ///"},{"line_number":47,"context_line":"    /// The only errors returns are these when writing to the passed writer."},{"line_number":48,"context_line":"    pub fn serialize(\u0026self, writer: \u0026mut impl std::io::Write) -\u003e Result\u003c(), std::io::Error\u003e {"},{"line_number":49,"context_line":"        write::write_str(writer, write::DERIVATION_PREFIX)?;"},{"line_number":50,"context_line":"        write::write_char(writer, write::PAREN_OPEN)?;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        write::write_outputs(writer, \u0026self.outputs)?;"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"8f349236_89d84502","line":49,"updated":"2023-07-31 21:18:50.000000000","message":"local `use write::*;` seems OK here","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    ///"},{"line_number":47,"context_line":"    /// The only errors returns are these when writing to the passed writer."},{"line_number":48,"context_line":"    pub fn serialize(\u0026self, writer: \u0026mut impl std::io::Write) -\u003e Result\u003c(), std::io::Error\u003e {"},{"line_number":49,"context_line":"        write::write_str(writer, write::DERIVATION_PREFIX)?;"},{"line_number":50,"context_line":"        write::write_char(writer, write::PAREN_OPEN)?;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        write::write_outputs(writer, \u0026self.outputs)?;"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"cfcea5c8_350d6eb7","line":49,"in_reply_to":"8f349236_89d84502","updated":"2023-07-31 21:33:01.000000000","message":"Agreed. It\u0027s in a followup CL.","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"}],"tvix/nix-compat/src/derivation/tests/mod.rs":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#[test_resources(\"src/derivation/tests/derivation_tests/*.drv\")]"},{"line_number":26,"context_line":"fn check_serizaliation(path_to_drv_file: \u0026str) {"},{"line_number":27,"context_line":"    let data \u003d read_file(\u0026format!(\"{}.json\", path_to_drv_file));"},{"line_number":28,"context_line":"    let derivation: Derivation \u003d serde_json::from_str(\u0026data).expect(\"JSON was not well-formatted\");"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"5f248780_515d4011","side":"PARENT","line":26,"updated":"2023-07-31 21:18:50.000000000","message":"check_serialization","commit_id":"108bd801f3bd0a2f9aaa3a15d7be263b70257c9d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":23,"context_line":"}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#[test_resources(\"src/derivation/tests/derivation_tests/*.drv\")]"},{"line_number":26,"context_line":"fn check_serizaliation(path_to_drv_file: \u0026str) {"},{"line_number":27,"context_line":"    let data \u003d read_file(\u0026format!(\"{}.json\", path_to_drv_file));"},{"line_number":28,"context_line":"    let derivation: Derivation \u003d serde_json::from_str(\u0026data).expect(\"JSON was not well-formatted\");"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"3689129d_70cd5f4b","side":"PARENT","line":26,"in_reply_to":"5f248780_515d4011","updated":"2023-07-31 21:33:01.000000000","message":"Done in followup CL.","commit_id":"108bd801f3bd0a2f9aaa3a15d7be263b70257c9d"}],"tvix/nix-compat/src/derivation/write.rs":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"pub(crate) fn write_char(writer: \u0026mut impl Write, c: char) -\u003e io::Result\u003c()\u003e {"},{"line_number":23,"context_line":"    let mut buf \u003d [0; 4];"},{"line_number":24,"context_line":"    let b \u003d c.encode_utf8(\u0026mut buf).as_bytes();"},{"line_number":25,"context_line":"    io::copy(\u0026mut Cursor::new(b), writer)?;"},{"line_number":26,"context_line":"    Ok(())"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"7de9c10a_c49091a7","line":25,"updated":"2023-07-31 21:18:50.000000000","message":"`writer.write(buf)` ?","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"a7a50ec60e2f243c639eace4358f55c572f21bc6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"pub(crate) fn write_char(writer: \u0026mut impl Write, c: char) -\u003e io::Result\u003c()\u003e {"},{"line_number":23,"context_line":"    let mut buf \u003d [0; 4];"},{"line_number":24,"context_line":"    let b \u003d c.encode_utf8(\u0026mut buf).as_bytes();"},{"line_number":25,"context_line":"    io::copy(\u0026mut Cursor::new(b), writer)?;"},{"line_number":26,"context_line":"    Ok(())"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"8cc30f3e_2ab8b424","line":25,"in_reply_to":"7de9c10a_c49091a7","updated":"2023-07-31 21:37:45.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":22,"context_line":"pub(crate) fn write_char(writer: \u0026mut impl Write, c: char) -\u003e io::Result\u003c()\u003e {"},{"line_number":23,"context_line":"    let mut buf \u003d [0; 4];"},{"line_number":24,"context_line":"    let b \u003d c.encode_utf8(\u0026mut buf).as_bytes();"},{"line_number":25,"context_line":"    io::copy(\u0026mut Cursor::new(b), writer)?;"},{"line_number":26,"context_line":"    Ok(())"},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"dcecc3d3_f0be8fe8","line":25,"in_reply_to":"7de9c10a_c49091a7","updated":"2023-07-31 21:33:01.000000000","message":"cl/8997","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    quote: bool,"},{"line_number":38,"context_line":"    open: \u0026str,"},{"line_number":39,"context_line":"    closing: \u0026str,"},{"line_number":40,"context_line":"    elements: \u0026[BString],"},{"line_number":41,"context_line":") -\u003e Result\u003c(), io::Error\u003e {"},{"line_number":42,"context_line":"    write_str(writer, open)?;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"9ded6145_6e3a299d","line":40,"updated":"2023-07-31 21:18:50.000000000","message":"`elements: \u0026[\u0026BString]`","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"a7a50ec60e2f243c639eace4358f55c572f21bc6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    quote: bool,"},{"line_number":38,"context_line":"    open: \u0026str,"},{"line_number":39,"context_line":"    closing: \u0026str,"},{"line_number":40,"context_line":"    elements: \u0026[BString],"},{"line_number":41,"context_line":") -\u003e Result\u003c(), io::Error\u003e {"},{"line_number":42,"context_line":"    write_str(writer, open)?;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"4d9f7ec0_4edb902a","line":40,"in_reply_to":"9ded6145_6e3a299d","updated":"2023-07-31 21:37:45.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    quote: bool,"},{"line_number":38,"context_line":"    open: \u0026str,"},{"line_number":39,"context_line":"    closing: \u0026str,"},{"line_number":40,"context_line":"    elements: \u0026[BString],"},{"line_number":41,"context_line":") -\u003e Result\u003c(), io::Error\u003e {"},{"line_number":42,"context_line":"    write_str(writer, open)?;"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"19bb82e4_10c88481","line":40,"in_reply_to":"9ded6145_6e3a299d","updated":"2023-07-31 21:33:01.000000000","message":"Subsequent CLs changed this to\n\n```rust\nfn write_array_elements\u003cS: AsRef\u003c[u8]\u003e\u003e(\n    writer: \u0026mut impl Write,\n    elements: \u0026[S],\n) -\u003e Result\u003c(), io::Error\u003e {\n```","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        \u0026BRACKET_CLOSE.to_string(),"},{"line_number":158,"context_line":"        \u0026input_sources"},{"line_number":159,"context_line":"            .iter()"},{"line_number":160,"context_line":"            .map(|s| s.as_bytes().to_vec().into())"},{"line_number":161,"context_line":"            .collect::\u003cVec\u003cBString\u003e\u003e(),"},{"line_number":162,"context_line":"    )?;"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"1a1c05c4_a9efb15a","line":160,"updated":"2023-07-31 21:18:50.000000000","message":"`.map(BString::from)`\nhttps://docs.rs/bstr/latest/bstr/struct.BString.html#impl-From%3CString%3E-for-BString","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"a7a50ec60e2f243c639eace4358f55c572f21bc6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0026BRACKET_CLOSE.to_string(),"},{"line_number":158,"context_line":"        \u0026input_sources"},{"line_number":159,"context_line":"            .iter()"},{"line_number":160,"context_line":"            .map(|s| s.as_bytes().to_vec().into())"},{"line_number":161,"context_line":"            .collect::\u003cVec\u003cBString\u003e\u003e(),"},{"line_number":162,"context_line":"    )?;"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"1c1dfbb9_0a280384","line":160,"in_reply_to":"1a1c05c4_a9efb15a","updated":"2023-07-31 21:37:45.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0026BRACKET_CLOSE.to_string(),"},{"line_number":158,"context_line":"        \u0026input_sources"},{"line_number":159,"context_line":"            .iter()"},{"line_number":160,"context_line":"            .map(|s| s.as_bytes().to_vec().into())"},{"line_number":161,"context_line":"            .collect::\u003cVec\u003cBString\u003e\u003e(),"},{"line_number":162,"context_line":"    )?;"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"f6d164b1_e19372bc","line":160,"in_reply_to":"1a1c05c4_a9efb15a","updated":"2023-07-31 21:33:01.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"ae72e7d8988b85be1b1103f914e61e6d2589cc0b","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    write_char(writer, COMMA)?;"},{"line_number":199,"context_line":"    write_char(writer, BRACKET_OPEN)?;"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    for (i, (k, v)) in environment.iter().enumerate() {"},{"line_number":202,"context_line":"        if i \u003e 0 {"},{"line_number":203,"context_line":"            write_char(writer, COMMA)?;"},{"line_number":204,"context_line":"        }"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"40657c4e_47d180bc","line":201,"updated":"2023-07-31 21:18:50.000000000","message":"`into_iter`","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"a7a50ec60e2f243c639eace4358f55c572f21bc6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    write_char(writer, COMMA)?;"},{"line_number":199,"context_line":"    write_char(writer, BRACKET_OPEN)?;"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    for (i, (k, v)) in environment.iter().enumerate() {"},{"line_number":202,"context_line":"        if i \u003e 0 {"},{"line_number":203,"context_line":"            write_char(writer, COMMA)?;"},{"line_number":204,"context_line":"        }"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"846c3503_48fe99d5","line":201,"in_reply_to":"40657c4e_47d180bc","updated":"2023-07-31 21:37:45.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b59341cb93caaa6be5f7077343f24e9e3f7aa04","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    write_char(writer, COMMA)?;"},{"line_number":199,"context_line":"    write_char(writer, BRACKET_OPEN)?;"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    for (i, (k, v)) in environment.iter().enumerate() {"},{"line_number":202,"context_line":"        if i \u003e 0 {"},{"line_number":203,"context_line":"            write_char(writer, COMMA)?;"},{"line_number":204,"context_line":"        }"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"bdbd16f3_af3a3144","line":201,"in_reply_to":"40657c4e_47d180bc","updated":"2023-07-31 21:33:01.000000000","message":"Done","commit_id":"a4b6449f0709c0b17634f1d59561514fca7fc90e"}]}