)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"da3c395d7b4308cbc5f0def784f5b3e574e6ab15","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  the top level. This fixes b/296."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* users/grfn: disable builds of xanthous (and dependents) until the"},{"line_number":30,"context_line":"  CLs fixing its build are submitted"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* 3p/overlays: build nixos-option against Nix 2.15, the only version"},{"line_number":33,"context_line":"  with which it builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"e1cf9df2_9879eced","line":30,"updated":"2023-09-06 13:22:34.000000000","message":"where is this change?","commit_id":"78c5ff2b20b89cc0ac9ef42c088092d51306f4c8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"5e291bb6d06c439eb1969ddf26204f062a12a858","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  the top level. This fixes b/296."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* users/grfn: disable builds of xanthous (and dependents) until the"},{"line_number":30,"context_line":"  CLs fixing its build are submitted"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* 3p/overlays: build nixos-option against Nix 2.15, the only version"},{"line_number":33,"context_line":"  with which it builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"ee7bb917_e704f4d5","line":30,"in_reply_to":"30ec343a_701cd254","updated":"2023-09-06 13:32:40.000000000","message":"I\u0027ve 9186 on the channel bumps (the one that *should* fix the builds), lets see what it does. We can move the discussion to that CL.","commit_id":"78c5ff2b20b89cc0ac9ef42c088092d51306f4c8"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"fdc7038f1bc22dcabf4c913bb811b0d67aa9ab64","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  the top level. This fixes b/296."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"* users/grfn: disable builds of xanthous (and dependents) until the"},{"line_number":30,"context_line":"  CLs fixing its build are submitted"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* 3p/overlays: build nixos-option against Nix 2.15, the only version"},{"line_number":33,"context_line":"  with which it builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"30ec343a_701cd254","line":30,"in_reply_to":"e1cf9df2_9879eced","updated":"2023-09-06 13:23:53.000000000","message":"WIP CLs that fix Xanthous are here:\n\n- https://cl.tvl.fyi/c/depot/+/9186/\n- https://cl.tvl.fyi/c/depot/+/9205/","commit_id":"78c5ff2b20b89cc0ac9ef42c088092d51306f4c8"}],"default.nix":[{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"dafc863caa8b26dc161a84103ff984c845d936ae","unresolved":true,"context_lines":[{"line_number":72,"context_line":"  # fetch attributes that were imported by readTree and are buildable."},{"line_number":73,"context_line":"  #"},{"line_number":74,"context_line":"  # Any build target that contains `meta.ci.skip \u003d true` or is marked"},{"line_number":75,"context_line":"  # broken will be skipped."},{"line_number":76,"context_line":"  # Is this tree node eligible for build inclusion?"},{"line_number":77,"context_line":"  eligible \u003d node: (node ? outPath) \u0026\u0026 !(node.meta.ci.skip or (node.meta.broken or false));"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-nix","patch_set":16,"id":"ce8afa9d_da92b5b4","line":75,"updated":"2023-09-06 13:49:16.000000000","message":"should this comment be in the previous change?","commit_id":"110328232ddee8aec755142e3098ba07914b8322"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"a407ed173aae946bde5078677370af84869684bb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"  # fetch attributes that were imported by readTree and are buildable."},{"line_number":73,"context_line":"  #"},{"line_number":74,"context_line":"  # Any build target that contains `meta.ci.skip \u003d true` or is marked"},{"line_number":75,"context_line":"  # broken will be skipped."},{"line_number":76,"context_line":"  # Is this tree node eligible for build inclusion?"},{"line_number":77,"context_line":"  eligible \u003d node: (node ? outPath) \u0026\u0026 !(node.meta.ci.skip or (node.meta.broken or false));"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-nix","patch_set":16,"id":"a2e13dfd_3ce79635","line":75,"in_reply_to":"ce8afa9d_da92b5b4","updated":"2023-09-06 13:50:59.000000000","message":"Yep, but when I noticed it was already submitted.","commit_id":"110328232ddee8aec755142e3098ba07914b8322"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"dafc863caa8b26dc161a84103ff984c845d936ae","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    filter \u003d self.third_party.nixpkgs.lib.cleanSourceFilter;"},{"line_number":104,"context_line":"  };"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Additionally targets can be excluded from CI by adding them to the"},{"line_number":107,"context_line":"  # list below."},{"line_number":108,"context_line":"  ci.excluded \u003d ["},{"line_number":109,"context_line":"    # xanthous and related targets are disabled until cl/9186 is submitted"},{"line_number":110,"context_line":"    self.users.grfn.xanthous"},{"line_number":111,"context_line":"    self.users.grfn.system.system.mugwumpSystem"},{"line_number":112,"context_line":"  ];"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  # List of all buildable targets, for CI purposes."},{"line_number":115,"context_line":"  #"}],"source_content_type":"text/x-nix","patch_set":16,"id":"5527010b_07f3c858","line":112,"range":{"start_line":106,"start_character":2,"end_line":112,"end_character":4},"updated":"2023-09-06 13:49:16.000000000","message":"hmm this is odd. why not do this on the targets themselves?\n\nThis way, I\u0027m not the owner of these changes so I don\u0027t have to review them","commit_id":"110328232ddee8aec755142e3098ba07914b8322"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"1d1cdf0f9365755a6fb23cb4452281eedaab98e7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    filter \u003d self.third_party.nixpkgs.lib.cleanSourceFilter;"},{"line_number":104,"context_line":"  };"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"  # Additionally targets can be excluded from CI by adding them to the"},{"line_number":107,"context_line":"  # list below."},{"line_number":108,"context_line":"  ci.excluded \u003d ["},{"line_number":109,"context_line":"    # xanthous and related targets are disabled until cl/9186 is submitted"},{"line_number":110,"context_line":"    self.users.grfn.xanthous"},{"line_number":111,"context_line":"    self.users.grfn.system.system.mugwumpSystem"},{"line_number":112,"context_line":"  ];"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  # List of all buildable targets, for CI purposes."},{"line_number":115,"context_line":"  #"}],"source_content_type":"text/x-nix","patch_set":16,"id":"9e8d4bef_2bd8bc00","line":112,"range":{"start_line":106,"start_character":2,"end_line":112,"end_character":4},"in_reply_to":"5527010b_07f3c858","updated":"2023-09-06 13:54:46.000000000","message":"That\u0027s the idea of b/296. My honest take is we have to limit how much blockage we accept from `//users`, especially during times of relatively low activity.\n\nOf course sterni and I usually do simple fixes when bumping channels, but with something as complex as this migration (which has been on the horizon for a long time) we need to move forward at some point.\n\nIn many other monorepo setups the solution is instead to not require a \"green trunk\", but I\u0027m not a fan of that. This new mechanism can also be extended to actually do an inverse assertion (i.e. *assert* that the build fails, fail the build if it unexpectedly succeeds) so that we don\u0027t forget to re-enable stuff.","commit_id":"110328232ddee8aec755142e3098ba07914b8322"}],"third_party/overlays/tvl.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"acfc1bae84c83959a20b9781266b58389fc8331c","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # nixos-option only builds against Nix 2.15"},{"line_number":43,"context_line":"  nixos-option \u003d super.nixos-option.override {"},{"line_number":44,"context_line":"    nix \u003d super.nixVersions.nix_2_15;"},{"line_number":45,"context_line":"  };"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  # Too match telega in emacs-overlay or wherever"}],"source_content_type":"text/x-nix","patch_set":14,"id":"391fb8e2_27e421c1","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":15},"updated":"2023-09-06 12:17:56.000000000","message":"should be `self`.","commit_id":"0c9198108581c01acee76dba93d964914116a445"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"3ce2e85ae74222980a8ef089e221e2bf48c7c9f8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # nixos-option only builds against Nix 2.15"},{"line_number":43,"context_line":"  nixos-option \u003d super.nixos-option.override {"},{"line_number":44,"context_line":"    nix \u003d super.nixVersions.nix_2_15;"},{"line_number":45,"context_line":"  };"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  # Too match telega in emacs-overlay or wherever"}],"source_content_type":"text/x-nix","patch_set":14,"id":"8fd09fb5_d433a6a7","line":44,"range":{"start_line":44,"start_character":10,"end_line":44,"end_character":15},"in_reply_to":"391fb8e2_27e421c1","updated":"2023-09-06 13:21:17.000000000","message":"Done","commit_id":"0c9198108581c01acee76dba93d964914116a445"}],"tvix/verify-lang-tests/default.nix":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"fec0aa5f399ff2e4dfc5564a48ca1f9dba6db391","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    # Cycle detection and formatting changed sometime after Nix 2.3"},{"line_number":66,"context_line":"    \"eval-okay-cycle-display-cpp-nix-2.13.nix\" \u003d [ nix ];"},{"line_number":67,"context_line":"    # builtins.replaceStrings becomes lazier in Nix 2.16"},{"line_number":68,"context_line":"    \"eval-okay-replacestrings.nix\" \u003d [ nix /* (assert latestNixIs215; nix_latest) */ ];"},{"line_number":69,"context_line":"    # builtins.readFileType is added in Nix 2.15"},{"line_number":70,"context_line":"    \"eval-okay-readFileType.nix\" \u003d [ nix ];"},{"line_number":71,"context_line":"    # builtins.fromTOML gains support for timestamps in Nix 2.16"}],"source_content_type":"text/x-nix","patch_set":2,"id":"a1ea574b_71ed41dd","line":68,"updated":"2023-08-21 22:15:04.000000000","message":"The commented out code can be deleted completely. They are test cases for behaviour of Nix 2.16 we imported from the C++ Nix test suite. At the time no released Nix version nor tvix (to this day) passed them. Nix 2.16 is the first version that passes them.","commit_id":"23331a365c6f72cd3e524732eb02b704e44d6cab"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"923a70bf9e8dbe9dcf96fce08c2c52d5c7e3d19d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    # Cycle detection and formatting changed sometime after Nix 2.3"},{"line_number":66,"context_line":"    \"eval-okay-cycle-display-cpp-nix-2.13.nix\" \u003d [ nix ];"},{"line_number":67,"context_line":"    # builtins.replaceStrings becomes lazier in Nix 2.16"},{"line_number":68,"context_line":"    \"eval-okay-replacestrings.nix\" \u003d [ nix /* (assert latestNixIs215; nix_latest) */ ];"},{"line_number":69,"context_line":"    # builtins.readFileType is added in Nix 2.15"},{"line_number":70,"context_line":"    \"eval-okay-readFileType.nix\" \u003d [ nix ];"},{"line_number":71,"context_line":"    # builtins.fromTOML gains support for timestamps in Nix 2.16"}],"source_content_type":"text/x-nix","patch_set":2,"id":"623dbc52_30568c9e","line":68,"in_reply_to":"a1ea574b_71ed41dd","updated":"2023-08-22 09:55:55.000000000","message":"Done","commit_id":"23331a365c6f72cd3e524732eb02b704e44d6cab"}]}