)]}'
{"id":"depot~9145","triplet_id":"depot~canon~I3ab3d6b715b32606cf771dabc31d9d4507c8b856","project":"depot","branch":"canon","hashtags":[],"change_id":"I3ab3d6b715b32606cf771dabc31d9d4507c8b856","subject":"fix(emacs-pkgs/term-switcher): switch buffers by object, not name","status":"MERGED","created":"2023-08-23 19:22:55.000000000","updated":"2023-08-23 20:22:25.000000000","submitted":"2023-08-23 20:22:25.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9149","meta_rev_id":"f6b67f29128c3274718b503507b8874a59af0553","_number":9145,"virtual_id_number":9145,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-08-23 20:22:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-08-23 20:22:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-23 19:22:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-08-23 19:26:33.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3046e4e60c47c4ae00221947b949e2c08505f501","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-08-23 19:22:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"33c7bdbc2dd46b15ca75046cba1febc5ee366f89","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-08-23 19:22:56.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/26196","accounts_in_message":[],"_revision_number":1},{"id":"a56114b76b457be1822f8174f0d87b18bcd7bd06","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-08-23 19:26:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/26196","accounts_in_message":[],"_revision_number":1},{"id":"b1c16da7b1b19921134ac8ce382b9b40ceec989a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-08-23 20:19:45.000000000","message":"Patch Set 1: Code-Review+2\n\nBy voting Code-Review+2 the following files are now explicitly code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* tools/emacs-pkgs/term-switcher/term-switcher.el\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"f6b67f29128c3274718b503507b8874a59af0553","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-08-23 20:22:25.000000000","message":"Change has been successfully rebased and submitted as 4b4ec86114bb317184f80e540e1582672a1a2d6f","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b4ec86114bb317184f80e540e1582672a1a2d6f","revisions":{"ff1c8f5e803b562ba3ec2833b4a85183bda54312":{"kind":"REWORK","_number":1,"created":"2023-08-23 19:22:55.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/45/9145/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/9145/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/9145/1"}}},"commit":{"parents":[{"commit":"bde9bc1c1dc21ed565d6728e93e1ff0fc8131794","subject":"fix(ops/nixery): switch nixery.dev to stable nixpkgs channel","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbde9bc1c1dc21ed565d6728e93e1ff0fc8131794"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-08-23 19:20:37.000000000","tz":180},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-08-23 19:20:37.000000000","tz":180},"subject":"fix(emacs-pkgs/term-switcher): switch buffers by object, not name","message":"fix(emacs-pkgs/term-switcher): switch buffers by object, not name\n\nThe terminal switcher uses ivy to select buffers from a list of\nbuffer *names*, however this can cause weird situations if, for\nexample, two `vterm` sessions are in the same folder and buffer name\nuniquification is active.\n\nThis commit implements a corrected solution, which constructs an\nassociation list of buffer names to their actual buffer object, and\nretrieves the buffer object from that list after the user has made\ntheir selection. This way, changes in buffer names during terminal\nselection do not lead to confusing results.\n\nChange-Id: I3ab3d6b715b32606cf771dabc31d9d4507c8b856\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dff1c8f5e803b562ba3ec2833b4a85183bda54312"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dff1c8f5e803b562ba3ec2833b4a85183bda54312"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"bde9bc1c1dc21ed565d6728e93e1ff0fc8131794","is_merged_in_target_branch":true,"change_id":"Id5eb11ebd235928b85c01c178c32da3badea517f","change_number":9126,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4b4ec86114bb317184f80e540e1582672a1a2d6f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-08-23 20:22:25.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/45/9145/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/9145/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/9145/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/9145/2"}}},"commit":{"parents":[{"commit":"bde9bc1c1dc21ed565d6728e93e1ff0fc8131794","subject":"fix(ops/nixery): switch nixery.dev to stable nixpkgs channel","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbde9bc1c1dc21ed565d6728e93e1ff0fc8131794"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-08-23 19:20:37.000000000","tz":180},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2023-08-23 20:22:25.000000000","tz":0},"subject":"fix(emacs-pkgs/term-switcher): switch buffers by object, not name","message":"fix(emacs-pkgs/term-switcher): switch buffers by object, not name\n\nThe terminal switcher uses ivy to select buffers from a list of\nbuffer *names*, however this can cause weird situations if, for\nexample, two `vterm` sessions are in the same folder and buffer name\nuniquification is active.\n\nThis commit implements a corrected solution, which constructs an\nassociation list of buffer names to their actual buffer object, and\nretrieves the buffer object from that list after the user has made\ntheir selection. This way, changes in buffer names during terminal\nselection do not lead to confusing results.\n\nChange-Id: I3ab3d6b715b32606cf771dabc31d9d4507c8b856\nReviewed-on: https://cl.tvl.fyi/c/depot/+/9145\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4b4ec86114bb317184f80e540e1582672a1a2d6f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4b4ec86114bb317184f80e540e1582672a1a2d6f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"bde9bc1c1dc21ed565d6728e93e1ff0fc8131794","is_merged_in_target_branch":true,"change_id":"Id5eb11ebd235928b85c01c178c32da3badea517f","change_number":9126,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}