)]}'
{"id":"depot~9290","triplet_id":"depot~canon~Idcad795105af5d57e6d06de6e232881dccf9110b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000035":{"account":{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},"last_update":"2023-09-10 11:23:33.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-09-10 11:42:40.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-09-10 11:43:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idcad795105af5d57e6d06de6e232881dccf9110b","subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","status":"MERGED","created":"2023-09-10 10:45:44.000000000","updated":"2023-09-10 11:43:29.000000000","submitted":"2023-09-10 11:43:29.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9290","meta_rev_id":"d4ce223c8ec5167126fa4b067ef11629b8256574","_number":9290,"virtual_id_number":9290,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-10 11:43:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-10 11:43:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-10 11:43:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-10 11:43:29.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-10 10:45:44.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-09-10 10:45:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-09-10 10:46:18.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-10 10:47:48.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},"state":"REVIEWER"},{"updated":"2023-09-10 11:43:29.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"21cefb0f5cb24c774eb8da5b476972cf31363362","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-10 10:45:44.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"c47c1f2f8ebc300321d9396e6a59d2b3bab8c5cf","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-10 10:45:44.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* ops/modules/www/code.tvl.fyi.nix\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"1d298b1a25ee1faeb62783a1eaee04ef02464d6f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 10:45:45.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/26424","accounts_in_message":[],"_revision_number":1},{"id":"0876ca7f59302a3e0489a46c153989aef3b6762e","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 10:46:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/26424","accounts_in_message":[],"_revision_number":1},{"id":"71858e4d516c99963b7449c300ba237986491421","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-10 10:47:12.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ac5aa615dc57804bda052b93fa294aed5181f64d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 10:47:13.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/26425","accounts_in_message":[],"_revision_number":2},{"id":"e2f9c13fee600a1d345066eefd8675aac2abab3d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 10:49:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/26425","accounts_in_message":[],"_revision_number":2},{"id":"944e5537e92bb04c209ef0400496978333a9bdf4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-10 11:08:43.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"945693c165c3662771fba6a882e29e9785adcfe2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 11:08:44.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/26426","accounts_in_message":[],"_revision_number":3},{"id":"9663f716b7e9910c44ee5e00674dcc40de95e780","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 11:10:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/26426","accounts_in_message":[],"_revision_number":3},{"id":"678d5994533e0d245c1ac9bb397dc666fa5c8acc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-10 11:19:41.000000000","message":"Uploaded patch set 4: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"e35917dc4456320bfa5f8b0b5a6e7095203c256d","author":{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"},"date":"2023-09-10 11:23:33.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"836da1faf1e007b17d868a661eead96feea7ba72","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-09-10 11:42:40.000000000","message":"Patch Set 4: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000001\u003e:\n* ops/modules/www/code.tvl.fyi.nix\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":4},{"id":"d4ce223c8ec5167126fa4b067ef11629b8256574","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-09-10 11:43:29.000000000","message":"Change has been successfully rebased and submitted as 9786255267671f5a8f1ed856d938283139ccf41d","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"9786255267671f5a8f1ed856d938283139ccf41d","revisions":{"5aaa321b52dc041b2a2130c3eae32761cd8cce02":{"kind":"REWORK","_number":1,"created":"2023-09-10 10:45:44.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/9290/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/9290/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/9290/1"}}},"commit":{"parents":[{"commit":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","subject":"fix(tvix/eval): make compare_strict_eval_tests use Strict","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fa80ecc3def2145b4af0c292ffc0d1b82df3030"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:40:13.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:45:28.000000000","tz":120},"subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","message":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos\n\nThere\u0027s a go.mod in in tvix/store/protos, which sets the module path to\ncode.tvl.fyi/tvix/store/protos.\n\nWhile this path makes kinda sense, it\u0027s currently not possible to `go\nget` it from that location, as we serve the cgit interface from there.\n\nFortunately, `go get` has a mechanism to determine clone URLs for a\ngiven go module path, as documented in https://go.dev/ref/mod#vcs-find.\n\nWe simply need to serve a small HTML file at that path, describing the\nproper clone URL.\n\nThis points the clone URL for code.tvl.fyi/tvix/store/protos to a josh-\nprovided subtree of just :/tvix/store/protos, which will contain the\nroot go.mod file.\n\nAt a later point, we might want to provide this in a more general\nfashion for all go.mod files in the repo.\n\nFixes b/299.\n\nChange-Id: Idcad795105af5d57e6d06de6e232881dccf9110b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5aaa321b52dc041b2a2130c3eae32761cd8cce02"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5aaa321b52dc041b2a2130c3eae32761cd8cce02"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","is_merged_in_target_branch":true,"change_id":"Ia2389a5d30481cd322ed55230731340b795e5d87","change_number":9282,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b11ac8914b5db41272169ddae830b8258684e20e":{"kind":"REWORK","_number":2,"created":"2023-09-10 10:47:12.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/9290/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/9290/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/9290/2"}}},"commit":{"parents":[{"commit":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","subject":"fix(tvix/eval): make compare_strict_eval_tests use Strict","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fa80ecc3def2145b4af0c292ffc0d1b82df3030"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:40:13.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:47:11.000000000","tz":120},"subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","message":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos\n\nThere\u0027s a go.mod in in tvix/store/protos, which sets the module path to\ncode.tvl.fyi/tvix/store/protos.\n\nWhile this path makes kinda sense, it\u0027s currently not possible to `go\nget` it from that location, as we serve the cgit interface from there.\n\nFortunately, `go get` has a mechanism to determine clone URLs for a\ngiven go module path, as documented in https://go.dev/ref/mod#vcs-find.\n\nWe simply need to serve a small HTML file at that path, describing the\nproper clone URL.\n\nThis points the clone URL for code.tvl.fyi/tvix/store/protos to a josh-\nprovided subtree of just :/tvix/store/protos, which will contain the\nroot go.mod file.\n\nAt a later point, we might want to provide this in a more general\nfashion for all go.mod files in the repo.\n\nFixes b/299.\n\nChange-Id: Idcad795105af5d57e6d06de6e232881dccf9110b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db11ac8914b5db41272169ddae830b8258684e20e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db11ac8914b5db41272169ddae830b8258684e20e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","is_merged_in_target_branch":true,"change_id":"Ia2389a5d30481cd322ed55230731340b795e5d87","change_number":9282,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a208a034dd958772251e2d24390ad7c6a1add752":{"kind":"REWORK","_number":3,"created":"2023-09-10 11:08:43.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/9290/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/9290/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/9290/3"}}},"commit":{"parents":[{"commit":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","subject":"fix(tvix/eval): make compare_strict_eval_tests use Strict","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fa80ecc3def2145b4af0c292ffc0d1b82df3030"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:40:13.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 11:08:41.000000000","tz":120},"subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","message":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos\n\nThere\u0027s a go.mod in in tvix/store/protos, which sets the module path to\ncode.tvl.fyi/tvix/store/protos.\n\nWhile this path makes kinda sense, it\u0027s currently not possible to `go\nget` it from that location, as we serve the cgit interface from there.\n\nFortunately, `go get` has a mechanism to determine clone URLs for a\ngiven go module path, as documented in https://go.dev/ref/mod#vcs-find.\n\nWe simply need to serve a small HTML file at that path, describing the\nproper clone URL.\n\nThis points the clone URL for code.tvl.fyi/tvix/store/protos to a josh-\nprovided subtree of just :/tvix/store/protos, which will contain the\nroot go.mod file.\n\nAt a later point, we might want to provide this in a more general\nfashion for all go.mod files in the repo.\n\nFixes b/299.\n\nChange-Id: Idcad795105af5d57e6d06de6e232881dccf9110b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da208a034dd958772251e2d24390ad7c6a1add752"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da208a034dd958772251e2d24390ad7c6a1add752"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","is_merged_in_target_branch":true,"change_id":"Ia2389a5d30481cd322ed55230731340b795e5d87","change_number":9282,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f0d5c5a2b9f6027bced7f0f37f8c93c95db7cf86":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2023-09-10 11:19:41.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/9290/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/9290/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/9290/4"}}},"commit":{"parents":[{"commit":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","subject":"fix(tvix/eval): make compare_strict_eval_tests use Strict","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fa80ecc3def2145b4af0c292ffc0d1b82df3030"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:40:13.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 11:17:54.000000000","tz":120},"subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","message":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos\n\nThere\u0027s a go.mod in in tvix/store/protos, which sets the module path to\ncode.tvl.fyi/tvix/store/protos.\n\nWhile this path makes kinda sense, it\u0027s currently not possible to `go\nget` it from that location, as we serve the cgit interface from there.\n\nFortunately, `go get` has a mechanism to determine clone URLs for a\ngiven go module path, as documented in https://go.dev/ref/mod#vcs-find.\n\nWe simply need to serve a small HTML file at that path, describing the\nproper clone URL.\n\nThis points the clone URL for code.tvl.fyi/tvix/store/protos to a josh-\nprovided subtree of just :/tvix/store/protos, which will contain the\nroot go.mod file.\n\nWe need another layer of indirection as nginx can\u0027t have an `alias`\ndirective inside a conditional block (but can have a redirect).\n\nContrary to https://b.tvl.fyi/issues/299#comment-464, it seems to work\nfor our usecase. It might become a problem if we actually serve `go.mod`\nfiles in a nested fashion at some point, but let\u0027s look at that once we\nget there.\n\nFixes b/299.\n\nChange-Id: Idcad795105af5d57e6d06de6e232881dccf9110b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df0d5c5a2b9f6027bced7f0f37f8c93c95db7cf86"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df0d5c5a2b9f6027bced7f0f37f8c93c95db7cf86"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","is_merged_in_target_branch":true,"change_id":"Ia2389a5d30481cd322ed55230731340b795e5d87","change_number":9282,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9786255267671f5a8f1ed856d938283139ccf41d":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2023-09-10 11:43:29.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/90/9290/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/9290/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/9290/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/9290/5"}}},"commit":{"parents":[{"commit":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","subject":"fix(tvix/eval): make compare_strict_eval_tests use Strict","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6fa80ecc3def2145b4af0c292ffc0d1b82df3030"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-09-10 10:40:13.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-09-10 11:43:29.000000000","tz":0},"subject":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos","message":"feat(ops/modules/code.tvl.fyi): fix go get for tvix store protos\n\nThere\u0027s a go.mod in in tvix/store/protos, which sets the module path to\ncode.tvl.fyi/tvix/store/protos.\n\nWhile this path makes kinda sense, it\u0027s currently not possible to `go\nget` it from that location, as we serve the cgit interface from there.\n\nFortunately, `go get` has a mechanism to determine clone URLs for a\ngiven go module path, as documented in https://go.dev/ref/mod#vcs-find.\n\nWe simply need to serve a small HTML file at that path, describing the\nproper clone URL.\n\nThis points the clone URL for code.tvl.fyi/tvix/store/protos to a josh-\nprovided subtree of just :/tvix/store/protos, which will contain the\nroot go.mod file.\n\nWe need another layer of indirection as nginx can\u0027t have an `alias`\ndirective inside a conditional block (but can have a redirect).\n\nContrary to https://b.tvl.fyi/issues/299#comment-464, it seems to work\nfor our usecase. It might become a problem if we actually serve `go.mod`\nfiles in a nested fashion at some point, but let\u0027s look at that once we\nget there.\n\nFixes b/299.\n\nChange-Id: Idcad795105af5d57e6d06de6e232881dccf9110b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/9290\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nReviewed-by: adisbladis \u003cadisbladis@gmail.com\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9786255267671f5a8f1ed856d938283139ccf41d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9786255267671f5a8f1ed856d938283139ccf41d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6fa80ecc3def2145b4af0c292ffc0d1b82df3030","is_merged_in_target_branch":true,"change_id":"Ia2389a5d30481cd322ed55230731340b795e5d87","change_number":9282,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000035,"name":"adisbladis","email":"adisbladis@gmail.com","username":"adisbladis"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}