)]}'
{"id":"depot~9294","triplet_id":"depot~canon~I4830780d3012207e7628e34610a98bbee66a6e16","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-09-15 20:09:10.000000000","reason":"Change was abandoned"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-09-15 20:09:10.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I4830780d3012207e7628e34610a98bbee66a6e16","subject":"fix(tvix/store/grpc): Use spawn_blocking when calling async-\u003esync","status":"ABANDONED","created":"2023-09-10 21:37:55.000000000","updated":"2023-09-15 20:09:10.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e2b134de15b7c8574a3dedb776917b22e12ed800","_number":9294,"virtual_id_number":9294,"owner":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:buildkite~result","value":1,"date":"2023-09-10 21:50:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-10 21:37:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-09-10 21:41:15.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-09-10 21:41:15.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-09-10 21:41:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7282e7725404e0a755d13d31c4633a404143a0de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-10 21:37:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ffe4aab330006cd0f851b11a4c54c6761c2b389f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 21:37:56.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/26434","accounts_in_message":[],"_revision_number":1},{"id":"8aef6916128e459411b6f3d2bd48793613c23b64","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-10 21:41:15.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* tvix/store/src/proto/grpc_blobservice_wrapper.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n* tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs\n\n\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/store/src/proto/grpc_blobservice_wrapper.rs\n* tvix/store/src/proto/grpc_directoryservice_wrapper.rs\n* tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"94e82d36f4302c85ab890bf677fa18cc1d02be0f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 21:41:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/26434","accounts_in_message":[],"_revision_number":1},{"id":"573278bc632a764aa7884b64fa32aaeb057ecc14","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-10 21:47:13.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"e74a9452b70ddecdc989a82220d99a870dfa0501","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 21:47:14.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/26435","accounts_in_message":[],"_revision_number":2},{"id":"d147e817e962eb8f9d51888c90fd0a0de55d81aa","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-10 21:50:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/26435","accounts_in_message":[],"_revision_number":2},{"id":"e2b134de15b7c8574a3dedb776917b22e12ed800","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-15 20:09:10.000000000","message":"Abandoned\n\nThe asyncification of the blob service is almost done which obsoletes this.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e07c671c8017b332f713dab798f452fe3c994409","revisions":{"9de802f084d31d640ebc73ba31a1e8c46c4de14e":{"kind":"REWORK","_number":1,"created":"2023-09-10 21:37:55.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/94/9294/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/94/9294/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/94/9294/1"}}},"commit":{"parents":[{"commit":"8c53ab531018d390fcea95f44c63f3a643a8d17d","subject":"refactor(tvix/website): remove unused structuredData","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c53ab531018d390fcea95f44c63f3a643a8d17d"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-10 21:33:28.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-10 21:33:28.000000000","tz":-300},"subject":"fix(tvix/store/grpc): Use spawn_blocking when calling async-\u003esync","message":"fix(tvix/store/grpc): Use spawn_blocking when calling async-\u003esync\n\nIn the gRPC server implementations, we are calling potentially long\nblocking sync code from async code. The proper way to do this is to use\na `spawn_blocking` call which will prevent the sync call from locking up\nthe async runtime.\n\nThis happens to also fix the issue where we were having nested async\nruntimes, as it is okay to call `block_on` inside a `spawn_blocking`\nsince the `spawn_blocking` closure is executed in a non-async context.\n\nIssue: https://b.tvl.fyi/issues/304\nChange-Id: I4830780d3012207e7628e34610a98bbee66a6e16\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9de802f084d31d640ebc73ba31a1e8c46c4de14e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9de802f084d31d640ebc73ba31a1e8c46c4de14e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8c53ab531018d390fcea95f44c63f3a643a8d17d","is_merged_in_target_branch":true,"change_id":"I2445b977c5bed3e2d4b90e8ad81119d316b29b50","change_number":9281,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e07c671c8017b332f713dab798f452fe3c994409":{"kind":"REWORK","_number":2,"created":"2023-09-10 21:47:13.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/94/9294/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/94/9294/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/94/9294/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/94/9294/2"}}},"commit":{"parents":[{"commit":"8c53ab531018d390fcea95f44c63f3a643a8d17d","subject":"refactor(tvix/website): remove unused structuredData","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c53ab531018d390fcea95f44c63f3a643a8d17d"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-10 21:33:28.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-10 21:47:08.000000000","tz":-300},"subject":"fix(tvix/store/grpc): Use spawn_blocking when calling async-\u003esync","message":"fix(tvix/store/grpc): Use spawn_blocking when calling async-\u003esync\n\nIn the gRPC server implementations, we are calling potentially long\nblocking sync code from async code. The proper way to do this is to use\na `spawn_blocking` call which will prevent the sync call from locking up\nthe async runtime.\n\nThis happens to also fix the issue where we were having nested async\nruntimes, as it is okay to call `block_on` inside a `spawn_blocking`\nsince the `spawn_blocking` closure is executed in a non-async context.\n\nIssue: https://b.tvl.fyi/issues/304\nChange-Id: I4830780d3012207e7628e34610a98bbee66a6e16\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de07c671c8017b332f713dab798f452fe3c994409"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de07c671c8017b332f713dab798f452fe3c994409"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8c53ab531018d390fcea95f44c63f3a643a8d17d","is_merged_in_target_branch":true,"change_id":"I2445b977c5bed3e2d4b90e8ad81119d316b29b50","change_number":9281,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}