)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b0149f39ce646b2c1b49c26a454e1bcb9050fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"47b9785e_a04de88e","updated":"2023-09-16 14:58:35.000000000","message":"Since cl/9290 it\u0027s now possible to refer to the store protos as a separate go module, so I updated the go.mod to reflect that, and then looped it into CI. As can be seen, the tests need to be refactored too, to pass :-) Will do that in the next few hours.","commit_id":"d4227b5fb7268a1fbe4b90d6f9c1c6e5457d6226"}],"tvix/nar-bridge/default.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d41e09efb868745b4a82d9bb3ef3fff5438089e8","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  name \u003d \"nar-bridge\";"},{"line_number":7,"context_line":"  src \u003d depot.third_party.gitignoreSource ./.;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  vendorHash \u003d \"sha256-ankJbu6mHziF04NTA8opnWH765Jv1wQALYI8SeEst1Q\u003d\";"},{"line_number":10,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"07c5ddee_1e41d560","line":9,"updated":"2023-09-17 11:43:24.000000000","message":"https://cl.tvl.fyi/c/depot/+/7378","commit_id":"59757e9eaf4f35c11fae382d4a6344257790d9b9"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4c2a693617fb90aa11cbb7774165f5cdd79244d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  name \u003d \"nar-bridge\";"},{"line_number":7,"context_line":"  src \u003d depot.third_party.gitignoreSource ./.;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  vendorHash \u003d \"sha256-ankJbu6mHziF04NTA8opnWH765Jv1wQALYI8SeEst1Q\u003d\";"},{"line_number":10,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"88185304_b108e963","line":9,"in_reply_to":"07c5ddee_1e41d560","updated":"2023-09-17 11:45:34.000000000","message":"Done","commit_id":"59757e9eaf4f35c11fae382d4a6344257790d9b9"}],"tvix/nar-bridge/pkg/server/nar_get.go":[{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"e7e9bae4c7a0eb3b33d8e683edfe18cc8d3d0284","unresolved":true,"context_lines":[{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\tnarUrl \u003d \"/nar/{narhash:^([\" + nixbase32.Alphabet + \"]{52}|[\" + nixbase32.Alphabet + \"]{103})$}.nar{compression:(.xz)?}\""},{"line_number":25,"context_line":")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"func renderNar("}],"source_content_type":"text/x-go","patch_set":1,"id":"526239f3_65b1c186","line":24,"updated":"2023-09-15 18:34:24.000000000","message":"Let\u0027s remove the `{compression:(.xz)?}` part for now, I slapped it on there just to make copying from cache.nixos.org work but its hard coded.","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b0149f39ce646b2c1b49c26a454e1bcb9050fbc","unresolved":false,"context_lines":[{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\tnarUrl \u003d \"/nar/{narhash:^([\" + nixbase32.Alphabet + \"]{52}|[\" + nixbase32.Alphabet + \"]{103})$}.nar{compression:(.xz)?}\""},{"line_number":25,"context_line":")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"func renderNar("}],"source_content_type":"text/x-go","patch_set":1,"id":"6983cb30_0b9e3db7","line":24,"in_reply_to":"526239f3_65b1c186","updated":"2023-09-16 14:58:35.000000000","message":"Done","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"dbcaa15b027ca7d019d241f2e66e0523b2c9846b","unresolved":true,"context_lines":[{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\tnarUrl \u003d \"/nar/{narhash:^([\" + nixbase32.Alphabet + \"]{52}|[\" + nixbase32.Alphabet + \"]{103})$}.nar{compression:(.xz)?}\""},{"line_number":25,"context_line":")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"func renderNar("}],"source_content_type":"text/x-go","patch_set":1,"id":"9718c824_e70fc1f4","line":24,"in_reply_to":"6983cb30_0b9e3db7","updated":"2023-09-16 23:40:13.000000000","message":"Looks like there is a trailing `}` after `.nar` that shouldn\u0027t be there. Made me scratch my head for a little bit :)","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"4c2a693617fb90aa11cbb7774165f5cdd79244d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"const ("},{"line_number":24,"context_line":"\tnarUrl \u003d \"/nar/{narhash:^([\" + nixbase32.Alphabet + \"]{52}|[\" + nixbase32.Alphabet + \"]{103})$}.nar{compression:(.xz)?}\""},{"line_number":25,"context_line":")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"func renderNar("}],"source_content_type":"text/x-go","patch_set":1,"id":"56329f9e_3f2eb683","line":24,"in_reply_to":"9718c824_e70fc1f4","updated":"2023-09-17 11:45:34.000000000","message":"This should be correct - our router has this odd {symbbol:regex} notation to parse parts of the URL and add it to the context.","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"}],"tvix/nar-bridge/pkg/server/nar_put.go":[{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"e7e9bae4c7a0eb3b33d8e683edfe18cc8d3d0284","unresolved":true,"context_lines":[{"line_number":39,"context_line":"\t\tdirectoriesUploader :\u003d NewDirectoriesUploader(ctx, s.directoryServiceClient)"},{"line_number":40,"context_line":"\t\tdefer directoriesUploader.Done() //nolint:errcheck"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\t\tuncompressed, err :\u003d xz.NewReader(r.Body)"},{"line_number":43,"context_line":"\t\tif err !\u003d nil {"},{"line_number":44,"context_line":"\t\t\tlog.Errorf(\"error during NAR import: %v\", err)"},{"line_number":45,"context_line":"\t\t\tw.WriteHeader(http.StatusInternalServerError)"}],"source_content_type":"text/x-go","patch_set":1,"id":"fb230f36_4dd0d0b8","line":42,"updated":"2023-09-15 18:34:24.000000000","message":"This is the part that I hardcoded for the XZ stuff, we should remove this as well.\n\nWe can add better support for various compressions as a followup I think.","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5b0149f39ce646b2c1b49c26a454e1bcb9050fbc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"\t\tdirectoriesUploader :\u003d NewDirectoriesUploader(ctx, s.directoryServiceClient)"},{"line_number":40,"context_line":"\t\tdefer directoriesUploader.Done() //nolint:errcheck"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"\t\tuncompressed, err :\u003d xz.NewReader(r.Body)"},{"line_number":43,"context_line":"\t\tif err !\u003d nil {"},{"line_number":44,"context_line":"\t\t\tlog.Errorf(\"error during NAR import: %v\", err)"},{"line_number":45,"context_line":"\t\t\tw.WriteHeader(http.StatusInternalServerError)"}],"source_content_type":"text/x-go","patch_set":1,"id":"0231270d_f8d818f1","line":42,"in_reply_to":"fb230f36_4dd0d0b8","updated":"2023-09-16 14:58:35.000000000","message":"Done","commit_id":"562ef0523f7b9549bcf18c3c3959ee161d3aa68a"}]}