)]}'
{"id":"depot~9364","triplet_id":"depot~canon~I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-10 14:16:21.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-12-10 14:15:52.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d","subject":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug","status":"MERGED","created":"2023-09-18 10:51:10.000000000","updated":"2023-12-10 14:16:21.000000000","submitted":"2023-12-10 14:16:21.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9364","meta_rev_id":"5a4566544ddc090e4d9f79c83acf45ba9d979de4","_number":9364,"virtual_id_number":9364,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-10 14:16:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-10 14:16:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-10 14:16:21.000000000","_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-18 10:51:10.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-09-18 10:52:11.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-09-18 10:56:39.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-10 14:16:21.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"17dbaf97760c69ade9a998c6ce70fa60620f0686","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-09-18 10:51:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89ce1e4469382e420e4136229b9097486f28a43e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-18 10:51:10.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/26593","accounts_in_message":[],"_revision_number":1},{"id":"6e1dd1d14f4a603c60bd61145a70112fb56120dd","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-09-18 10:52:11.000000000","message":"Patch Set 1: Autosubmit+1\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"6f0510c4ba56e19f1ca94f8560f43ef8aeaed62b","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-09-18 10:52:11.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/cli/src/known_paths.rs\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"e8b1198ef9a82dd1b4df9c9b9df6ab6e87666e6f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-18 10:56:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/26593","accounts_in_message":[],"_revision_number":1},{"id":"d76bf9d8ceda53f052f9f40afae7658758e52046","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-09-18 10:57:09.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR is:ANY\")\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"57d0386b2408c5f894cbc5ffe9110adcbc25c7d0","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-18 11:51:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e279a620670d7356fe42e71aa36be122d3473c45","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-09-18 23:20:16.000000000","message":"Patch Set 2: Autosubmit+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"34112eb5af30388896f000d94aa4d6c3cbee66ef","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-19 08:44:28.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f79dea623e82346ba45d58bcf56adb52fd6cfcfd","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-19 08:46:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"602589068deac5477bd94d3fc9f06eb960800f1f","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-10-06 09:37:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"597e79ffb7caf4851a494e2b8fc82a00ac4c3cda","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-10-06 09:40:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"21ef96ee91d44a0eff5ca6096676e979fa5062c1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-11-25 02:36:20.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"e4a122437d2dda28453e741f764e0404e544d59d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-25 02:36:21.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28340","accounts_in_message":[],"_revision_number":3},{"id":"1aa1bb7daf404cfbef7a135561957a927bc04139","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-11-25 02:36:37.000000000","message":"Patch Set 3: Autosubmit+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"ffe1d53408ff57d052394be92ec0e34d544d87c3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-25 02:40:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/28340","accounts_in_message":[],"_revision_number":3},{"id":"4886e43620bcba4f87129b577db4ffa2ccf25f36","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-25 13:23:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"6d54e17e1fd411d12f2bce4f3aabf13d6d8ba8dd","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-09 03:30:12.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"14bc051a2d53ce00537763512d544e4840b23a92","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-10 14:15:52.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"5a4566544ddc090e4d9f79c83acf45ba9d979de4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-10 14:16:21.000000000","message":"Change has been successfully rebased and submitted as 2b4920c35582cddf0a8063e7d82d4de2e250732c","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2b4920c35582cddf0a8063e7d82d4de2e250732c","revisions":{"4f097a8e88a5a5b57cc3db5a35f72ddbff0aa939":{"kind":"REWORK","_number":1,"created":"2023-09-18 10:51:10.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/64/9364/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/9364/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/9364/1"}}},"commit":{"parents":[{"commit":"3de96017640b6dc25f1544a1bafd4b370bb1cea0","subject":"feat(users/Profpatsch/whatcd-resolver): add executable","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3de96017640b6dc25f1544a1bafd4b370bb1cea0"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:47:29.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:47:29.000000000","tz":-420},"subject":"fix(tvix/cli): panic on root cause of the fetcurl(non-boot) bug","message":"fix(tvix/cli): panic on root cause of the fetcurl(non-boot) bug\n\nCurrently we produce wrong drvPaths for a large number of packages\nthat use fetchurl (but not fetchurlBoot, which is what stdenv uses).\nA simple reproducer is `pkgs.perl538`.\n\nI debugged this down to the root cause, which is the fact that tvix\ndoesn\u0027t realize that the mapping from FOD-paths to outputHash is\n*NOT* a 1:1 mapping.  It is a many-to-one mapping.  You can have\nlots of different FODs with the same outputHash or even the same\noutPath.  For example, perl538.src and perldevel.src use the same\nsource tarball but a different `version`.\n\nAnyways, I have found the root cause but have run out of time for a\nwhile, so I\u0027ve added a panic!() to in the spot where we have a logic\nbug in order to call it out.\n\nChange-Id: I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4f097a8e88a5a5b57cc3db5a35f72ddbff0aa939"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4f097a8e88a5a5b57cc3db5a35f72ddbff0aa939"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3de96017640b6dc25f1544a1bafd4b370bb1cea0","is_merged_in_target_branch":true,"change_id":"I28f5c26443b9a878f8f374af2c7935831d17ab12","change_number":9355,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b56e9fb91087c2e98002618aadc8f9343841d963":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-09-18 10:57:09.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/64/9364/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/9364/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/9364/2"}}},"commit":{"parents":[{"commit":"3de96017640b6dc25f1544a1bafd4b370bb1cea0","subject":"feat(users/Profpatsch/whatcd-resolver): add executable","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3de96017640b6dc25f1544a1bafd4b370bb1cea0"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:47:29.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:55:44.000000000","tz":-420},"subject":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug","message":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug\n\nCurrently we produce wrong drvPaths for a large number of packages\nthat use fetchurl (but not fetchurlBoot, which is what stdenv uses).\nA simple reproducer is `pkgs.perl538`.\n\nI debugged this down to the root cause, which is the fact that tvix\ndoesn\u0027t realize that the mapping from FOD-paths to outputHash is\n*NOT* a 1:1 mapping.  It is a many-to-one mapping.  You can have\nlots of different FODs with the same outputHash or even the same\noutPath.  For example, perl538.src and perldevel.src use the same\nsource tarball but a different `version`.\n\nAnyways, I have found the root cause but have run out of time for a\nwhile, so I\u0027ve added a panic!() to in the spot where we have a logic\nbug in order to call it out.\n\nChange-Id: I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db56e9fb91087c2e98002618aadc8f9343841d963"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db56e9fb91087c2e98002618aadc8f9343841d963"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3de96017640b6dc25f1544a1bafd4b370bb1cea0","is_merged_in_target_branch":true,"change_id":"I28f5c26443b9a878f8f374af2c7935831d17ab12","change_number":9355,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c7bac83b7bc1a6646f80b542dcce7909c941ae1d":{"kind":"REWORK","_number":3,"created":"2023-11-25 02:36:20.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/64/9364/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/9364/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/9364/3"}}},"commit":{"parents":[{"commit":"875bb26fc314b22f4a6fa2e457cf7ec5a44e7954","subject":"fix(tvix/castore): correctly flag unreachable code","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d875bb26fc314b22f4a6fa2e457cf7ec5a44e7954"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:47:29.000000000","tz":-420},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-11-25 02:34:42.000000000","tz":-480},"subject":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug","message":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug\n\nCurrently we produce wrong drvPaths for a large number of packages\nthat use fetchurl (but not fetchurlBoot, which is what stdenv uses).\nA simple reproducer is `pkgs.perl538`.\n\nI debugged this down to the root cause, which is the fact that tvix\ndoesn\u0027t realize that the mapping from FOD-paths to outputHash is\n*NOT* a 1:1 mapping.  It is a many-to-one mapping.  You can have\nlots of different FODs with the same outputHash or even the same\noutPath.  For example, perl538.src and perldevel.src use the same\nsource tarball but a different `version`.\n\nAnyways, I have found the root cause but have run out of time for a\nwhile, so I\u0027ve added a panic!() to in the spot where we have a logic\nbug in order to call it out.\n\nChange-Id: I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc7bac83b7bc1a6646f80b542dcce7909c941ae1d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc7bac83b7bc1a6646f80b542dcce7909c941ae1d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"875bb26fc314b22f4a6fa2e457cf7ec5a44e7954","is_merged_in_target_branch":true,"change_id":"Id09afa4b77c3c70fb5695f253f6df4aa88b61e19","change_number":10113,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2b4920c35582cddf0a8063e7d82d4de2e250732c":{"kind":"REWORK","_number":4,"created":"2023-12-10 14:16:21.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/64/9364/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/64/9364/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/64/9364/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/64/9364/4"}}},"commit":{"parents":[{"commit":"efaff795848a5ab20ded471f63bc02e5d1fb916a","subject":"feat(tvix): make clippy stricter","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003defaff795848a5ab20ded471f63bc02e5d1fb916a"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-09-18 10:47:29.000000000","tz":-420},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-10 14:16:21.000000000","tz":0},"subject":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug","message":"fix(tvix/cli): panic on root cause of the fetchurl(non-boot) bug\n\nCurrently we produce wrong drvPaths for a large number of packages\nthat use fetchurl (but not fetchurlBoot, which is what stdenv uses).\nA simple reproducer is `pkgs.perl538`.\n\nI debugged this down to the root cause, which is the fact that tvix\ndoesn\u0027t realize that the mapping from FOD-paths to outputHash is\n*NOT* a 1:1 mapping.  It is a many-to-one mapping.  You can have\nlots of different FODs with the same outputHash or even the same\noutPath.  For example, perl538.src and perldevel.src use the same\nsource tarball but a different `version`.\n\nAnyways, I have found the root cause but have run out of time for a\nwhile, so I\u0027ve added a panic!() to in the spot where we have a logic\nbug in order to call it out.\n\nChange-Id: I9766b39cfe2fe7eafec84945b2ad6cc28f9c4b7d\nReviewed-on: https://cl.tvl.fyi/c/depot/+/9364\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nAutosubmit: Adam Joseph \u003cadam@westernsemico.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b4920c35582cddf0a8063e7d82d4de2e250732c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b4920c35582cddf0a8063e7d82d4de2e250732c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"efaff795848a5ab20ded471f63bc02e5d1fb916a","is_merged_in_target_branch":true,"change_id":"Ide9f1bc9f565333072afb918c391c7930b658f41","change_number":10234,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}