)]}'
{"id":"depot~9429","triplet_id":"depot~canon~I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2023-09-25 17:41:37.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-09-23 08:20:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-09-25 12:46:42.000000000","reason":"\u003cGERRIT_ACCOUNT_1000073\u003e replied on the change","reason_account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}},"hashtags":[],"change_id":"I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb","subject":"feat(tvix/store): Support listening on UNIX domain sockets","status":"MERGED","created":"2023-09-23 00:49:21.000000000","updated":"2023-09-25 17:41:37.000000000","submitted":"2023-09-25 17:41:37.000000000","submitter":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9429","meta_rev_id":"2d078aadf371f79eae905bffbca9edc0e5a70eeb","_number":9429,"virtual_id_number":9429,"owner":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-25 17:41:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-09-25 17:41:37.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-09-25 17:41:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-23 00:49:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-09-23 00:52:06.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-09-23 00:56:34.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-23 08:20:07.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"}],"messages":[{"id":"db5cf99459c3b9fdf7f162ddd0b6bd2a417ba89d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 00:49:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"052e8d5189656adf75739a50265681219b11f35d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-23 00:49:23.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/26718","accounts_in_message":[],"_revision_number":1},{"id":"cf7bd10fe38ba6475d7d36bdd27093ed4680ffe6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 00:51:50.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"709b2269a60c8cc2ffef4ffa05a4ead20a825b5f","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 00:52:06.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* tvix/Cargo.lock\n* tvix/Cargo.nix\n* tvix/store/Cargo.toml\n* tvix/store/src/bin/tvix-store.rs\n* tvix/store/src/lib.rs\n* tvix/store/src/listener/mod.rs\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":2},{"id":"233d8c81d9beb6fd80dceeb2aae25d07c814a7c1","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-23 00:56:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/26718","accounts_in_message":[],"_revision_number":1},{"id":"ba9fe4bf9193e42baad115ceb11f45d0ed8f6f90","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 00:56:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9186fb53e28963bcb90bf57dfc669c58b3dfe833","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2023-09-23 12:47:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"72a2a2e99b50f918c98941ad2f96e1784edb7a2d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 22:12:08.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5a084314228e240e4a0c1718e8ff854f3d118b1b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-23 22:12:08.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/26732","accounts_in_message":[],"_revision_number":3},{"id":"e68d02ac3a4285f9f6a68cd8c50b441bfdb5b79d","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-23 22:12:39.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"eccd6b40f935400b48c5c1df0d97e2c2cfc74e09","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-09-23 22:15:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/26732","accounts_in_message":[],"_revision_number":3},{"id":"590628b307c262e2bf88733dcec508f6126449eb","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2023-09-25 12:46:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"713bbefa5ace45e9cfba04f98dbbdb7daf3c44da","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-25 12:51:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8dd714baa2db15a291a8ef2dacb01e5351ef7c57","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-09-25 12:51:51.000000000","message":"Patch Set 3: Code-Review+2\n\nBy voting Code-Review+2 the following files are now code-owner approved by \u003cGERRIT_ACCOUNT_1000036\u003e:\n* tvix/Cargo.lock\n* tvix/Cargo.nix\n* tvix/store/Cargo.toml\n* tvix/store/src/bin/tvix-store.rs\n* tvix/store/src/lib.rs\n* tvix/store/src/listener/mod.rs\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":3},{"id":"2d078aadf371f79eae905bffbca9edc0e5a70eeb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2023-09-25 17:41:37.000000000","message":"Change has been successfully rebased and submitted as f8746fcab0d6cbd6d9e7a49ce2217f858151a476","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f8746fcab0d6cbd6d9e7a49ce2217f858151a476","revisions":{"3f213201c4d5de51bd6dbe03645578716fac12a8":{"kind":"REWORK","_number":1,"created":"2023-09-23 00:49:21.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/29/9429/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/9429/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/9429/1"}}},"commit":{"parents":[{"commit":"8de0d6ad48a4974abc1cd22300e982dd2dab72a7","subject":"chore(ops/glesys): point nixery.dev to nixery-01.tvl.fyi","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8de0d6ad48a4974abc1cd22300e982dd2dab72a7"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:45:01.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:49:13.000000000","tz":-300},"subject":"feat(tvix/store): Support listening on UNIX domain sockets","message":"feat(tvix/store): Support listening on UNIX domain sockets\n\nThis adds support for listening on UNIX domain sockets via the\ntokio-listener crate. The crate will automatically determine whether to\nstart a TCP or UNIX domain socket server based on the listen address.\n\nUnfortunately, it\u0027s not compatible with tonic right out of the box so I\nadded some wrapper types to implement the necessary traits to make\nthings work. We should investigate upstreaming a `tonic` option to the\ntokio-listener crate which implements the relevant `tonic` traits.\n\nChange-Id: I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3f213201c4d5de51bd6dbe03645578716fac12a8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3f213201c4d5de51bd6dbe03645578716fac12a8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8de0d6ad48a4974abc1cd22300e982dd2dab72a7","is_merged_in_target_branch":true,"change_id":"I0bfa713511f1565bd2fa9b3c1989fda16e8dfa4a","change_number":9428,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8a9e7060e635695e96ab858b5ddeecc151effed4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-09-23 00:51:50.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/29/9429/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/9429/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/9429/2"}}},"commit":{"parents":[{"commit":"8de0d6ad48a4974abc1cd22300e982dd2dab72a7","subject":"chore(ops/glesys): point nixery.dev to nixery-01.tvl.fyi","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8de0d6ad48a4974abc1cd22300e982dd2dab72a7"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:45:01.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:50:02.000000000","tz":-300},"subject":"feat(tvix/store): Support listening on UNIX domain sockets","message":"feat(tvix/store): Support listening on UNIX domain sockets\n\nThis adds support for listening on UNIX domain sockets via the\ntokio-listener crate. The crate will automatically determine whether to\nstart a TCP or UNIX domain socket server based on the listen address.\n\nUnfortunately, it\u0027s not compatible with tonic right out of the box so I\nadded some wrapper types to implement the necessary traits to make\nthings work. We should investigate upstreaming a `tonic` option to the\ntokio-listener crate which implements the relevant `tonic` traits.\n\nExample:\n```\n$ tvix-store daemon -l /run/tvix-store.sock\nINFO tvix_store: tvix-store listening on /run/tvix-store.sock\n\n$ tvix-store mount -l /mnt/tvix --blob-service-addr grpc+unix:///run/tvix-store.sock --directory-service-addr grpc+unix:///run/tvix-store.sock --path-info-service-addr grpc+unix:///run/tvix-store.sock\n\n$ ls /mnt/tvix\n```\n\nChange-Id: I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a9e7060e635695e96ab858b5ddeecc151effed4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a9e7060e635695e96ab858b5ddeecc151effed4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8de0d6ad48a4974abc1cd22300e982dd2dab72a7","is_merged_in_target_branch":true,"change_id":"I0bfa713511f1565bd2fa9b3c1989fda16e8dfa4a","change_number":9428,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d57c1bed978601f85b2d6786f155c9de7937f458":{"kind":"REWORK","_number":3,"created":"2023-09-23 22:12:08.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/29/9429/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/9429/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/9429/3"}}},"commit":{"parents":[{"commit":"e5f22818566b4cc49ce9b089c59921f5a054c48c","subject":"feat(tvix/cli/derivation): reject derivations with empty names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de5f22818566b4cc49ce9b089c59921f5a054c48c"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:45:01.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 22:12:01.000000000","tz":-300},"subject":"feat(tvix/store): Support listening on UNIX domain sockets","message":"feat(tvix/store): Support listening on UNIX domain sockets\n\nThis adds support for listening on UNIX domain sockets via the\ntokio-listener crate. The crate will automatically determine whether to\nstart a TCP or UNIX domain socket server based on the listen address.\n\nUnfortunately, it\u0027s not compatible with tonic right out of the box so I\nadded some wrapper types to implement the necessary traits to make\nthings work. We should investigate upstreaming a `tonic` option to the\ntokio-listener crate which implements the relevant `tonic` traits.\n\nExample:\n```\n$ tvix-store daemon -l /run/tvix-store.sock\nINFO tvix_store: tvix-store listening on /run/tvix-store.sock\n\n$ tvix-store mount -l /mnt/tvix --blob-service-addr grpc+unix:///run/tvix-store.sock --directory-service-addr grpc+unix:///run/tvix-store.sock --path-info-service-addr grpc+unix:///run/tvix-store.sock\n\n$ ls /mnt/tvix\n```\n\nChange-Id: I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd57c1bed978601f85b2d6786f155c9de7937f458"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd57c1bed978601f85b2d6786f155c9de7937f458"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e5f22818566b4cc49ce9b089c59921f5a054c48c","is_merged_in_target_branch":true,"change_id":"I0e9743cee98dbfa69e9caa2a58352176270f15bd","change_number":9448,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f8746fcab0d6cbd6d9e7a49ce2217f858151a476":{"kind":"REWORK","_number":4,"created":"2023-09-25 17:41:37.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/29/9429/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/9429/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/9429/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/9429/4"}}},"commit":{"parents":[{"commit":"1b3d6975ed8c2a19f1e7f4f39a564cdfa387f0b6","subject":"chore(tvix/tests): rename to //tvix/boot","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1b3d6975ed8c2a19f1e7f4f39a564cdfa387f0b6"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-23 00:45:01.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2023-09-25 17:41:37.000000000","tz":0},"subject":"feat(tvix/store): Support listening on UNIX domain sockets","message":"feat(tvix/store): Support listening on UNIX domain sockets\n\nThis adds support for listening on UNIX domain sockets via the\ntokio-listener crate. The crate will automatically determine whether to\nstart a TCP or UNIX domain socket server based on the listen address.\n\nUnfortunately, it\u0027s not compatible with tonic right out of the box so I\nadded some wrapper types to implement the necessary traits to make\nthings work. We should investigate upstreaming a `tonic` option to the\ntokio-listener crate which implements the relevant `tonic` traits.\n\nExample:\n```\n$ tvix-store daemon -l /run/tvix-store.sock\nINFO tvix_store: tvix-store listening on /run/tvix-store.sock\n\n$ tvix-store mount -l /mnt/tvix --blob-service-addr grpc+unix:///run/tvix-store.sock --directory-service-addr grpc+unix:///run/tvix-store.sock --path-info-service-addr grpc+unix:///run/tvix-store.sock\n\n$ ls /mnt/tvix\n```\n\nChange-Id: I91c4a4b0c5a177b3b90e6c01a4e5d263130e6bdb\nReviewed-on: https://cl.tvl.fyi/c/depot/+/9429\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8746fcab0d6cbd6d9e7a49ce2217f858151a476"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8746fcab0d6cbd6d9e7a49ce2217f858151a476"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1b3d6975ed8c2a19f1e7f4f39a564cdfa387f0b6","is_merged_in_target_branch":true,"change_id":"I1d22cd68bf5af095bc11dd9d7117b62956c7f7f2","change_number":9465,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
