)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a91ffd49954b8e789212c0440bbad2f9cb95e58d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"upstream currently doesn\u0027t work with MacFuse. It also sets the default"},{"line_number":13,"context_line":"FUSE thread count on MacOS to 1 because otherwise the mount command will"},{"line_number":14,"context_line":"hang when shutting down as only one thread gets ENODEV and all the others"},{"line_number":15,"context_line":"just keep blocking."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ifb3c4268caf296c487049c1dc4618acb32497f44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5488661c_8a9f92fb","line":15,"updated":"2023-10-02 14:12:21.000000000","message":"You can also probably refer to https://b.tvl.fyi/issues/312 here. It\u0027s not fixing it entirely, but at least the fuse bits.","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"},{"author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"change_message_id":"babc731723438584ad2ce887fb7e1e4016311845","unresolved":true,"context_lines":[{"line_number":12,"context_line":"upstream currently doesn\u0027t work with MacFuse. It also sets the default"},{"line_number":13,"context_line":"FUSE thread count on MacOS to 1 because otherwise the mount command will"},{"line_number":14,"context_line":"hang when shutting down as only one thread gets ENODEV and all the others"},{"line_number":15,"context_line":"just keep blocking."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ifb3c4268caf296c487049c1dc4618acb32497f44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d98c7de7_e08426cc","line":15,"in_reply_to":"5488661c_8a9f92fb","updated":"2023-10-02 14:21:23.000000000","message":"You want me to add it as a link? The commit message starts with \"This partially fixes b/312 and gets FUSE to work again on MacOS.\" and I thought that was enough reference to b/312.","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2c183504dfda4c8cce63a75f0eedb114897aa6c8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"upstream currently doesn\u0027t work with MacFuse. It also sets the default"},{"line_number":13,"context_line":"FUSE thread count on MacOS to 1 because otherwise the mount command will"},{"line_number":14,"context_line":"hang when shutting down as only one thread gets ENODEV and all the others"},{"line_number":15,"context_line":"just keep blocking."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ifb3c4268caf296c487049c1dc4618acb32497f44"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4c4855b0_d2db34c1","line":15,"in_reply_to":"d98c7de7_e08426cc","updated":"2023-10-02 15:45:58.000000000","message":"Erf, yes, you\u0027re right. Thanks :-D","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"}],"tvix/Cargo.lock":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"f25f47de6fb1467f9eccbc9694884240860811f5","unresolved":true,"context_lines":[{"line_number":773,"context_line":"[[package]]"},{"line_number":774,"context_line":"name \u003d \"fuse-backend-rs\""},{"line_number":775,"context_line":"version \u003d \"0.10.5\""},{"line_number":776,"context_line":"source \u003d \"git+https://github.com/griff/fuse-backend-rs?branch\u003dmacfuse-fix#70b835cada7e1f18e5cbb13f6c4b698ba203c820\""},{"line_number":777,"context_line":"dependencies \u003d ["},{"line_number":778,"context_line":" \"arc-swap\","},{"line_number":779,"context_line":" \"bitflags\","}],"source_content_type":"application/octet-stream","patch_set":2,"id":"42d69a02_429346d5","line":776,"updated":"2023-10-02 14:05:33.000000000","message":"How does https://github.com/cloud-hypervisor/fuse-backend-rs/pull/158 relate to this? Is it needed as well, or not?","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"},{"author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"change_message_id":"babc731723438584ad2ce887fb7e1e4016311845","unresolved":false,"context_lines":[{"line_number":773,"context_line":"[[package]]"},{"line_number":774,"context_line":"name \u003d \"fuse-backend-rs\""},{"line_number":775,"context_line":"version \u003d \"0.10.5\""},{"line_number":776,"context_line":"source \u003d \"git+https://github.com/griff/fuse-backend-rs?branch\u003dmacfuse-fix#70b835cada7e1f18e5cbb13f6c4b698ba203c820\""},{"line_number":777,"context_line":"dependencies \u003d ["},{"line_number":778,"context_line":" \"arc-swap\","},{"line_number":779,"context_line":" \"bitflags\","}],"source_content_type":"application/octet-stream","patch_set":2,"id":"dfa381d0_1fc66a15","line":776,"in_reply_to":"42d69a02_429346d5","updated":"2023-10-02 14:21:23.000000000","message":"That PR is not needed for this CL but if we want to support fuse-t we need it. I have tested fuse-t and got it working with just that PR, this CL and an extra feature flag.","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2c183504dfda4c8cce63a75f0eedb114897aa6c8","unresolved":false,"context_lines":[{"line_number":773,"context_line":"[[package]]"},{"line_number":774,"context_line":"name \u003d \"fuse-backend-rs\""},{"line_number":775,"context_line":"version \u003d \"0.10.5\""},{"line_number":776,"context_line":"source \u003d \"git+https://github.com/griff/fuse-backend-rs?branch\u003dmacfuse-fix#70b835cada7e1f18e5cbb13f6c4b698ba203c820\""},{"line_number":777,"context_line":"dependencies \u003d ["},{"line_number":778,"context_line":" \"arc-swap\","},{"line_number":779,"context_line":" \"bitflags\","}],"source_content_type":"application/octet-stream","patch_set":2,"id":"2302a9b0_9dbe312a","line":776,"in_reply_to":"dfa381d0_1fc66a15","updated":"2023-10-02 15:45:58.000000000","message":"Nice, thanks for the context. Then this is obviously fine to keep in a followup CL.","commit_id":"2f83233e77e590518f6927f29d8850b6d9904293"}],"tvix/store/src/bin/tvix-store.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"05ec36f87851cfdfd87d554fc5a151080819ed25","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        .map(|threads| threads.into())"},{"line_number":146,"context_line":"        .unwrap_or(4)"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":"#[cfg(all(feature \u003d \"fuse\", target_os \u003d \"macos\"))]"},{"line_number":149,"context_line":"fn default_threads() -\u003e usize {"},{"line_number":150,"context_line":"    1"},{"line_number":151,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"624c2dcc_93e4d15b","line":148,"updated":"2023-10-02 12:41:59.000000000","message":"can you add a comment describing the why for this? also, could this be a sign for an an upstream bug? we should probably open an issue with our observations upstream and link to it from here in a comment.","commit_id":"388587ace91b319a6bf6361a5220e96cc2d058eb"},{"author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"change_message_id":"bc9cc7afb8735b343a512bf33ea8e5613b70440b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        .map(|threads| threads.into())"},{"line_number":146,"context_line":"        .unwrap_or(4)"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":"#[cfg(all(feature \u003d \"fuse\", target_os \u003d \"macos\"))]"},{"line_number":149,"context_line":"fn default_threads() -\u003e usize {"},{"line_number":150,"context_line":"    1"},{"line_number":151,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"5bf77244_2adf88b5","line":148,"in_reply_to":"624c2dcc_93e4d15b","updated":"2023-10-02 14:03:07.000000000","message":"Done","commit_id":"388587ace91b319a6bf6361a5220e96cc2d058eb"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"f25f47de6fb1467f9eccbc9694884240860811f5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        .map(|threads| threads.into())"},{"line_number":146,"context_line":"        .unwrap_or(4)"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":"#[cfg(all(feature \u003d \"fuse\", target_os \u003d \"macos\"))]"},{"line_number":149,"context_line":"fn default_threads() -\u003e usize {"},{"line_number":150,"context_line":"    1"},{"line_number":151,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4608d928_cfdeccae","line":148,"in_reply_to":"624c2dcc_93e4d15b","updated":"2023-10-02 14:05:33.000000000","message":"thanks!","commit_id":"388587ace91b319a6bf6361a5220e96cc2d058eb"}]}