)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"71ca49d5fbef987a4de1013bfde4bacd284e284d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36e7359e_1d039ad8","updated":"2023-10-17 02:39:49.000000000","message":"I had a test for this, but I couldn\u0027t get it to fail every time, only intermittently. It ingested docs 100+ times (in parallel) and used some injected latency via `tower_fault`. Since I couldn\u0027t get it to consistently catch this issue, I decided not to add the test, but happy to add it back if that sounds valuable.","commit_id":"e08aefe36f90bd4f6f6f1390da0a2ad33df60140"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"cf2d55b2cfa9487269fedc3f8d7c51e9362e7e88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6954825_ad7a31b3","in_reply_to":"36e7359e_1d039ad8","updated":"2023-10-17 06:59:30.000000000","message":"I think we can keep this on the back burner. Having some scenarios written down that we can then run on a simulated bad connection, and ensure it still works with that connection is a nice thing to have in our toolkit, but it\u0027s not gonna give predictable results, so probably should not be a plain unit test.","commit_id":"e08aefe36f90bd4f6f6f1390da0a2ad33df60140"}],"tvix/castore/src/import.rs":[{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"e4c988ae93784205e5b6769146266e3d28d91f89","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if entry.depth() \u003d\u003d 0 {"},{"line_number":192,"context_line":"            // Make sure all the directories are flushed."},{"line_number":193,"context_line":"            if entry.file_type().is_dir() {"},{"line_number":194,"context_line":"                directory_putter.close().await?;"},{"line_number":195,"context_line":"            }"},{"line_number":196,"context_line":"            return Ok(node);"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"d2911aa2_2c6a338b","line":193,"updated":"2023-10-17 02:51:43.000000000","message":"This is a bit awkward. The `directory_putter` errors out if you call close on it without having put any directories. In the case of ingesting a single file or symlink we won\u0027t have put any dirs, so we don\u0027t close in that case.\n\nThe close also returns the digest of the last directory that was put, but we don\u0027t rely on that here.\n\nWithout having too much context, maybe the putter shouldn\u0027t return a digest and closing a putter without having put anything is not an error. Then we rely on the caller to keep track of digests and the root node like we already do here.","commit_id":"7813d3c708282fa24ab928a27ca8a4dfbc350dfe"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"cf2d55b2cfa9487269fedc3f8d7c51e9362e7e88","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if entry.depth() \u003d\u003d 0 {"},{"line_number":192,"context_line":"            // Make sure all the directories are flushed."},{"line_number":193,"context_line":"            if entry.file_type().is_dir() {"},{"line_number":194,"context_line":"                directory_putter.close().await?;"},{"line_number":195,"context_line":"            }"},{"line_number":196,"context_line":"            return Ok(node);"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"73365c3d_7eb5ff31","line":193,"in_reply_to":"d2911aa2_2c6a338b","updated":"2023-10-17 06:59:30.000000000","message":"We probably shouldn\u0027t be creating the DirectoryPutter in first place, if there\u0027s no directories to put, but that\u0027s currently not possible, as the current interface of process_entry forces us to provide some.\n\nThat\u0027s probably something to keep in mind while working on further followups to cl/9606, but fine for now.","commit_id":"7813d3c708282fa24ab928a27ca8a4dfbc350dfe"}]}