)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"b77214ca0d25b0ddedacb4af4e1aa5d5ee218605","unresolved":true,"context_lines":[{"line_number":21,"context_line":"the .pb.go files."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The code.tvl.fyi webserver config is updated to the new source code"},{"line_number":24,"context_line":"path. I\u0027m still unsure if we want to also update the go.mod name. While"},{"line_number":25,"context_line":"being a backwards-incompatible change, it\u0027ll probbaly make it easier"},{"line_number":26,"context_line":"where to find these files, and the amount of external consumers is still"},{"line_number":27,"context_line":"low enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fc5d155c_1bd38e3a","line":24,"updated":"2023-10-17 13:12:52.000000000","message":"Thoughts on this?","commit_id":"3390ab99937151ac74daffb77c7cbbc92135d96f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"6db1d39cf7037a1985405173091dbbbbc36a28ec","unresolved":false,"context_lines":[{"line_number":21,"context_line":"the .pb.go files."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The code.tvl.fyi webserver config is updated to the new source code"},{"line_number":24,"context_line":"path. I\u0027m still unsure if we want to also update the go.mod name. While"},{"line_number":25,"context_line":"being a backwards-incompatible change, it\u0027ll probbaly make it easier"},{"line_number":26,"context_line":"where to find these files, and the amount of external consumers is still"},{"line_number":27,"context_line":"low enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"353dd8a1_b6319976","line":24,"in_reply_to":"a671247c_408111e1","updated":"2023-10-17 19:51:18.000000000","message":"Ok, I\u0027ll do it in a followup CL. Moving things would clear +2\u0027s again, and this alone is already an improvement.","commit_id":"3390ab99937151ac74daffb77c7cbbc92135d96f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"41c367056ada9992aebae2edf53ae19305a9866a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"the .pb.go files."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"The code.tvl.fyi webserver config is updated to the new source code"},{"line_number":24,"context_line":"path. I\u0027m still unsure if we want to also update the go.mod name. While"},{"line_number":25,"context_line":"being a backwards-incompatible change, it\u0027ll probbaly make it easier"},{"line_number":26,"context_line":"where to find these files, and the amount of external consumers is still"},{"line_number":27,"context_line":"low enough."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a671247c_408111e1","line":24,"in_reply_to":"fc5d155c_1bd38e3a","updated":"2023-10-17 19:30:58.000000000","message":"I think a breaking change now is okay, since you probably know all the people relying on this today. I agree having it named something different from where it is actually located in the repo will be a little confusing. Now is the best time to change it if we want to.","commit_id":"3390ab99937151ac74daffb77c7cbbc92135d96f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"ca41e3355c14980480999f9e8cbbee2371b7a9c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"067580ce_e526ae03","updated":"2023-10-17 13:57:57.000000000","message":"I think splitting them out makes sense","commit_id":"3390ab99937151ac74daffb77c7cbbc92135d96f"}],"ops/modules/www/code.tvl.fyi.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"168c71d1747b4258714057c985c51acced3fc823","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        location \u003d /go-get/tvix/castore/protos {"},{"line_number":24,"context_line":"            alias ${pkgs.writeText \"go-import-metadata.html\" \u0027\u0027\u003chtml\u003e\u003cmeta name\u003d\"go-import\" content\u003d\"code.tvl.fyi/tvix/castore/protos git https://code.tvl.fyi/depot.git:/tvix/castore-go.git\"\u003e\u003c/html\u003e\u0027\u0027};"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        location \u003d /go-get/tvix/store/protos {"}],"source_content_type":"text/x-nix","patch_set":3,"id":"dbc7696b_c1b4be4f","line":24,"updated":"2023-10-17 11:23:37.000000000","message":"Until merged, you can test this by using the josh `@` syntax:\n\n```\ngit clone https://code.tvl.fyi/depot.git@refs/changes/87/9787/3:/tvix/castore-go.git\n```","commit_id":"d7f2b66e39d3752a4bcfb03673c6a2214cfaf895"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"7fadc769166d2902dc58817369ef7f72bf9907d0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        location \u003d /go-get/tvix/castore/protos {"},{"line_number":24,"context_line":"            alias ${pkgs.writeText \"go-import-metadata.html\" \u0027\u0027\u003chtml\u003e\u003cmeta name\u003d\"go-import\" content\u003d\"code.tvl.fyi/tvix/castore/protos git https://code.tvl.fyi/depot.git:/tvix/castore-go.git\"\u003e\u003c/html\u003e\u0027\u0027};"},{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        location \u003d /go-get/tvix/store/protos {"}],"source_content_type":"text/x-nix","patch_set":3,"id":"75a31824_a980d338","line":24,"in_reply_to":"dbc7696b_c1b4be4f","updated":"2023-10-17 18:44:19.000000000","message":"Resvolved.","commit_id":"d7f2b66e39d3752a4bcfb03673c6a2214cfaf895"}]}
