)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0a881896113c3e672de6003f01dccd30a7e039ed","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dc44bb38_315e0cae","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":24},"updated":"2023-11-01 15:08:23.000000000","message":"use the repository\n\nOr is it more like the version shipped in the nixpkgs shipped with tvl-kit, if we\u0027re talking about tvl-kit?\n\nThat can still be anything, if a nixpkgs is passed in, (which it likely is), and in that case, you don\u0027t have a unified experience either.","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"9e99f3c7eb771bd936c280eea4823f28452019f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8b774_30bccf6b","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":24},"in_reply_to":"24be1c17_767ef036","updated":"2023-11-02 14:09:31.000000000","message":"Done","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"fa2884dcce8064f4ae5771d06a7fe3611cff8064","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"24be1c17_767ef036","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":24},"in_reply_to":"348cef69_fce2acbb","updated":"2023-11-02 12:18:47.000000000","message":"Pushed an update to the commit message to clarify this.","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"347e9f67f313cf7916a1654665d5b31c8c4d0711","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"348cef69_fce2acbb","line":9,"range":{"start_line":9,"start_character":21,"end_line":9,"end_character":24},"in_reply_to":"dc44bb38_315e0cae","updated":"2023-11-02 12:15:42.000000000","message":"It depends on how tvl-kit is instantiated in the parent repository. Since `pkgs` attribute is optional, it can be either parent repository pinned nix version (as I have in the Resoptima repository) or it can be the one coming with tvl-kit (as I have in another project repo).\n\nWhile it can be anything between repositories, it still is will be unified for all users of one specific tvl-kit instance, which is what I\u0027m aiming here for. Otherwise it\u0027s random per user, and cannot be controlled globally without lazy-dispatch.\n\nThe fact that consistency of magrathea depends on lazy-dispatch is wrong. The tool that\u0027s using some dependencies under the hood shouldn\u0027t provide users random results based on their personal environment.","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0a881896113c3e672de6003f01dccd30a7e039ed","unresolved":true,"context_lines":[{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"},{"line_number":13,"context_line":"packages and versions installed on their system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"69d03662_234772b6","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":19},"updated":"2023-11-01 15:08:23.000000000","message":"pursuit","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"347e9f67f313cf7916a1654665d5b31c8c4d0711","unresolved":true,"context_lines":[{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"},{"line_number":13,"context_line":"packages and versions installed on their system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bbced1c3_5c4d4287","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":19},"in_reply_to":"69d03662_234772b6","updated":"2023-11-02 12:15:42.000000000","message":"Thanks 😊","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"9e99f3c7eb771bd936c280eea4823f28452019f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix(tools/magrathea): isolate from environment packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes magrathea use repostory version of nix and git. This is"},{"line_number":10,"context_line":"done in the persuit of enforcing guaranteed unified experience of"},{"line_number":11,"context_line":"magrathea tool across any user of `tvl-kit`-based"},{"line_number":12,"context_line":"repositories. Especially among ubuntu users with uncontrolled set of"},{"line_number":13,"context_line":"packages and versions installed on their system."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7749bf1e_d92efcce","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":19},"in_reply_to":"bbced1c3_5c4d4287","updated":"2023-11-02 14:09:31.000000000","message":"Done","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0a881896113c3e672de6003f01dccd30a7e039ed","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Not having this fix was giving build problems for `mg build` for one"},{"line_number":16,"context_line":"of the users as he had 2.17 version of nix that had inconsistent hash"},{"line_number":17,"context_line":"computation with 2.3."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I3182faf4c545ac61f6cc1cc862dc23d51c1cd397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"84a09441_3fb51902","line":17,"updated":"2023-11-01 15:08:23.000000000","message":"Can you isolate this example and add it to https://pad.lassul.us/-WyxSazPSsCMHWmffbETfA ?","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"9e99f3c7eb771bd936c280eea4823f28452019f1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Not having this fix was giving build problems for `mg build` for one"},{"line_number":16,"context_line":"of the users as he had 2.17 version of nix that had inconsistent hash"},{"line_number":17,"context_line":"computation with 2.3."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I3182faf4c545ac61f6cc1cc862dc23d51c1cd397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fd5a8707_73610a56","line":17,"in_reply_to":"0105c99f_930d3b16","updated":"2023-11-02 14:09:31.000000000","message":"Acknowledged","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"347e9f67f313cf7916a1654665d5b31c8c4d0711","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Not having this fix was giving build problems for `mg build` for one"},{"line_number":16,"context_line":"of the users as he had 2.17 version of nix that had inconsistent hash"},{"line_number":17,"context_line":"computation with 2.3."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I3182faf4c545ac61f6cc1cc862dc23d51c1cd397"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0105c99f_930d3b16","line":17,"in_reply_to":"84a09441_3fb51902","updated":"2023-11-02 12:15:42.000000000","message":"Will do as soon as I have time","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"}],"tools/magrathea/default.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"0a881896113c3e672de6003f01dccd30a7e039ed","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  \u0027\u0027;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  fixupPhase \u003d \u0027\u0027"},{"line_number":37,"context_line":"    wrapProgram $out/bin/mg --set PATH ${lib.makeBinPath [ nix git ]}"},{"line_number":38,"context_line":"  \u0027\u0027;"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"c54c5a45_72fdc8b0","line":37,"updated":"2023-11-01 15:08:23.000000000","message":"I\u0027m not a fan of this. At least git is something you bring with yourself (you already checked-out the repo after all).\n\nNix could potentially work, though I\u0027m a bit worried about incompatibilities between different Nix versions on daemons vs clients (already seen these)","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"9e99f3c7eb771bd936c280eea4823f28452019f1","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  \u0027\u0027;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  fixupPhase \u003d \u0027\u0027"},{"line_number":37,"context_line":"    wrapProgram $out/bin/mg --set PATH ${lib.makeBinPath [ nix git ]}"},{"line_number":38,"context_line":"  \u0027\u0027;"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"7d97147d_4081730e","line":37,"in_reply_to":"6a8b4508_84d909e0","updated":"2023-11-02 14:09:31.000000000","message":"It makes sense that magrathea uses the Nix version of whatever repo instantiates it.","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"85855e3c941384e9ff25b99d0137d062956deaef","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  \u0027\u0027;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  fixupPhase \u003d \u0027\u0027"},{"line_number":37,"context_line":"    wrapProgram $out/bin/mg --set PATH ${lib.makeBinPath [ nix git ]}"},{"line_number":38,"context_line":"  \u0027\u0027;"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"b8e11de9_4ea2b2da","line":37,"in_reply_to":"7d97147d_4081730e","updated":"2023-11-03 13:54:33.000000000","message":"Acknowledged","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"},{"author":{"_account_id":1000038,"name":"ezemtsov","email":"eugene.zemtsov@gmail.com","username":"ezemtsov"},"change_message_id":"4aacd26795bf180f552576a24d5b95dda45f895d","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  \u0027\u0027;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  fixupPhase \u003d \u0027\u0027"},{"line_number":37,"context_line":"    wrapProgram $out/bin/mg --set PATH ${lib.makeBinPath [ nix git ]}"},{"line_number":38,"context_line":"  \u0027\u0027;"},{"line_number":39,"context_line":"}"}],"source_content_type":"text/x-nix","patch_set":3,"id":"6a8b4508_84d909e0","line":37,"in_reply_to":"c54c5a45_72fdc8b0","updated":"2023-11-02 12:16:01.000000000","message":"Removed pinned git from the PATH","commit_id":"9fd701cdaba0ee10fa1b9a1be2b2ac60e73a537d"}]}