)]}'
{"id":"depot~9908","triplet_id":"depot~canon~I080ed3d1825ab23790666486840f301f00856277","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-11-04 15:18:44.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-11-04 15:18:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I080ed3d1825ab23790666486840f301f00856277","subject":"refactor(tvix): move tvix glue code into glue crate","status":"MERGED","created":"2023-11-03 12:09:20.000000000","updated":"2023-11-04 15:18:44.000000000","submitted":"2023-11-04 15:18:44.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9908","meta_rev_id":"beb60aae3e40b102bbcaa19e11aef8ddf68e1bff","_number":9908,"virtual_id_number":9908,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-04 15:18:44.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-04 15:18:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-04 15:18:44.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-03 12:09:20.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-11-03 12:09:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-03 12:10:31.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-04 15:15:24.000000000","updated_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-11-04 15:18:44.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4a255da7ad4c72e20c33b14b52c4031db3116444","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-03 12:09:20.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"5c4dee8cf649927f5cab1efdf756e6c2a7bea7e6","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-03 12:09:20.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/Cargo.lock`\n* `tvix/Cargo.toml`\n* `tvix/cli/Cargo.toml`\n* `tvix/cli/src/.skip-subtree`\n* `tvix/cli/src/derivation.nix`\n* `tvix/cli/src/derivation.rs`\n* `tvix/cli/src/errors.rs`\n* `tvix/cli/src/fetchurl.nix`\n* `tvix/cli/src/known_paths.rs`\n* `tvix/cli/src/main.rs`\n* `tvix/cli/src/refscan.rs`\n* `tvix/cli/src/tvix_io.rs`\n* `tvix/cli/src/tvix_store_io.rs`\n* `tvix/glue/Cargo.toml`\n* `tvix/glue/default.nix`\n* `tvix/glue/src/.skip-subtree`\n* `tvix/glue/src/derivation.nix`\n* `tvix/glue/src/derivation.rs`\n* `tvix/glue/src/errors.rs`\n* `tvix/glue/src/fetchurl.nix`\n* `tvix/glue/src/known_paths.rs`\n* `tvix/glue/src/lib.rs`\n* `tvix/glue/src/refscan.rs`\n* `tvix/glue/src/tvix_io.rs`\n* `tvix/glue/src/tvix_store_io.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"f65d84124597e4a047db3e41d649d62346a6a9e8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-03 12:09:21.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/27847","accounts_in_message":[],"_revision_number":1},{"id":"ef577d2abf90f0ed4e6ce5e76c82eddb697df64f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-03 12:10:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/27847","accounts_in_message":[],"_revision_number":1},{"id":"402504fd22a219201bfb856e2668a5b3970855cd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-03 12:45:05.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2f9777aeba1bcc8a14baa438215315e0c322fc6a","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-03 12:45:06.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/27850","accounts_in_message":[],"_revision_number":2},{"id":"d0086b0fdc9a40a76074cef7efa3c3058a411923","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-03 12:48:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/27850","accounts_in_message":[],"_revision_number":2},{"id":"45fb42611368f12900065dc1ba91ce31b7d5432d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-03 16:23:08.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"13c848664ce3ebd17a3443a8ff2f35cb5d227ef4","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2023-11-04 15:15:24.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b84866d44cc1df6a7ccb94f888591ced387931e3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"real_author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-11-04 15:15:41.000000000","message":"Patch Set 4: Patch Set 3 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000036\u003e\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":4},{"id":"75245f426344c77b5734d3836d45af2a7890b0e2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-04 15:15:42.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/27868","accounts_in_message":[],"_revision_number":4},{"id":"2bac472a76a6019f12b9dcdc9cbbcdfc599a835d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-04 15:18:30.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/27868","accounts_in_message":[],"_revision_number":4},{"id":"beb60aae3e40b102bbcaa19e11aef8ddf68e1bff","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-11-04 15:18:44.000000000","message":"Change has been successfully rebased and submitted as 3196fe0143b6ff729c177fa5d17fa03c9e9627c9\n\n3 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"3196fe0143b6ff729c177fa5d17fa03c9e9627c9","revisions":{"4e1dbc8954044005f254cdf416e76639708aeadd":{"kind":"REWORK","_number":1,"created":"2023-11-03 12:09:20.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/08/9908/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/08/9908/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/08/9908/1"}}},"commit":{"parents":[{"commit":"99f618bcb4301c2265122d21bc00dbb1f148c37c","subject":"refactor(tvix/eval): delay allocation when comparing attr values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d99f618bcb4301c2265122d21bc00dbb1f148c37c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 11:34:37.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 12:01:09.000000000","tz":120},"subject":"chore(tvix): move tvix glue code into glue crate","message":"chore(tvix): move tvix glue code into glue crate\n\nThere\u0027s various bits and pieces in tvix-cli that use both the store and\nevaluator, as well as nix-compat. For example, builtins.derivation, as\nwell as the reference scanning implementation.\n\nThis \"glue code\" currently isn\u0027t accessible from anywhere else, but it\u0027d\nbe very useful if it were.\n\nMove it out into a `glue` crate, and make `tvix-cli` a consumer of it.\n\nAll the KnownPaths setup and passing around, as well as NIX_PATH\nhandling is also something that should probably be moved into the glue\ncrate as well, but that\u0027s something left for a future CL.\n\nChange-Id: I080ed3d1825ab23790666486840f301f00856277\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e1dbc8954044005f254cdf416e76639708aeadd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e1dbc8954044005f254cdf416e76639708aeadd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"99f618bcb4301c2265122d21bc00dbb1f148c37c","is_merged_in_target_branch":true,"change_id":"I7d68c27d7a0fbcdcc387db7c092bce50ca4b94ea","change_number":9900,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e77c65962a63ab7c4ed1c30959a22d7f7f3412d0":{"kind":"REWORK","_number":2,"created":"2023-11-03 12:45:05.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/08/9908/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/08/9908/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/08/9908/2"}}},"commit":{"parents":[{"commit":"99f618bcb4301c2265122d21bc00dbb1f148c37c","subject":"refactor(tvix/eval): delay allocation when comparing attr values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d99f618bcb4301c2265122d21bc00dbb1f148c37c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 11:34:37.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 12:44:58.000000000","tz":120},"subject":"chore(tvix): move tvix glue code into glue crate","message":"chore(tvix): move tvix glue code into glue crate\n\nThere\u0027s various bits and pieces in tvix-cli that use both the store and\nevaluator, as well as nix-compat. For example, builtins.derivation, as\nwell as the reference scanning implementation.\n\nThis \"glue code\" currently isn\u0027t accessible from anywhere else, but it\u0027d\nbe very useful if it were.\n\nMove it out into a `glue` crate, and make `tvix-cli` a consumer of it.\n\nAll the KnownPaths setup and passing around, as well as NIX_PATH\nhandling is also something that should probably be moved into the glue\ncrate as well, but that\u0027s something left for a future CL.\n\nChange-Id: I080ed3d1825ab23790666486840f301f00856277\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de77c65962a63ab7c4ed1c30959a22d7f7f3412d0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de77c65962a63ab7c4ed1c30959a22d7f7f3412d0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"99f618bcb4301c2265122d21bc00dbb1f148c37c","is_merged_in_target_branch":true,"change_id":"I7d68c27d7a0fbcdcc387db7c092bce50ca4b94ea","change_number":9900,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3c6d52f11e7029162091a873a70eeffc06da84ee":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-11-03 16:23:08.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/08/9908/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/08/9908/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/08/9908/3"}}},"commit":{"parents":[{"commit":"99f618bcb4301c2265122d21bc00dbb1f148c37c","subject":"refactor(tvix/eval): delay allocation when comparing attr values","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d99f618bcb4301c2265122d21bc00dbb1f148c37c"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 11:34:37.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 16:22:48.000000000","tz":120},"subject":"refactor(tvix): move tvix glue code into glue crate","message":"refactor(tvix): move tvix glue code into glue crate\n\nThere\u0027s various bits and pieces in tvix-cli that use both the store and\nevaluator, as well as nix-compat. For example, builtins.derivation, as\nwell as the reference scanning implementation.\n\nThis \"glue code\" currently isn\u0027t accessible from anywhere else, but it\u0027d\nbe very useful if it were.\n\nMove it out into a `glue` crate, and make `tvix-cli` a consumer of it.\n\nAll the KnownPaths setup and passing around, as well as NIX_PATH\nhandling is also something that should probably be moved into the glue\ncrate as well, but that\u0027s something left for a future CL.\n\nChange-Id: I080ed3d1825ab23790666486840f301f00856277\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c6d52f11e7029162091a873a70eeffc06da84ee"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c6d52f11e7029162091a873a70eeffc06da84ee"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"99f618bcb4301c2265122d21bc00dbb1f148c37c","is_merged_in_target_branch":true,"change_id":"I7d68c27d7a0fbcdcc387db7c092bce50ca4b94ea","change_number":9900,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"849fbc7ddbce803de147bb6cad613dff9a14b1e3":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-11-04 15:15:41.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"real_uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/08/9908/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/08/9908/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/08/9908/4"}}},"commit":{"parents":[{"commit":"a51d277764d73582bc9bf816f6f4163d2df7f9c4","subject":"chore(users/grfn): fonts.fonts -\u003e fonts.packages","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da51d277764d73582bc9bf816f6f4163d2df7f9c4"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 11:34:37.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2023-11-04 15:15:41.000000000","tz":0},"subject":"refactor(tvix): move tvix glue code into glue crate","message":"refactor(tvix): move tvix glue code into glue crate\n\nThere\u0027s various bits and pieces in tvix-cli that use both the store and\nevaluator, as well as nix-compat. For example, builtins.derivation, as\nwell as the reference scanning implementation.\n\nThis \"glue code\" currently isn\u0027t accessible from anywhere else, but it\u0027d\nbe very useful if it were.\n\nMove it out into a `glue` crate, and make `tvix-cli` a consumer of it.\n\nAll the KnownPaths setup and passing around, as well as NIX_PATH\nhandling is also something that should probably be moved into the glue\ncrate as well, but that\u0027s something left for a future CL.\n\nChange-Id: I080ed3d1825ab23790666486840f301f00856277\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d849fbc7ddbce803de147bb6cad613dff9a14b1e3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d849fbc7ddbce803de147bb6cad613dff9a14b1e3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a51d277764d73582bc9bf816f6f4163d2df7f9c4","is_merged_in_target_branch":true,"change_id":"Iaf223e238713a48f8c50b0c58a8800a82ba24eed","change_number":9913,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"},"3196fe0143b6ff729c177fa5d17fa03c9e9627c9":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2023-11-04 15:18:44.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/08/9908/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/08/9908/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/08/9908/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/08/9908/5"}}},"commit":{"parents":[{"commit":"a51d277764d73582bc9bf816f6f4163d2df7f9c4","subject":"chore(users/grfn): fonts.fonts -\u003e fonts.packages","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da51d277764d73582bc9bf816f6f4163d2df7f9c4"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-03 11:34:37.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-11-04 15:18:44.000000000","tz":0},"subject":"refactor(tvix): move tvix glue code into glue crate","message":"refactor(tvix): move tvix glue code into glue crate\n\nThere\u0027s various bits and pieces in tvix-cli that use both the store and\nevaluator, as well as nix-compat. For example, builtins.derivation, as\nwell as the reference scanning implementation.\n\nThis \"glue code\" currently isn\u0027t accessible from anywhere else, but it\u0027d\nbe very useful if it were.\n\nMove it out into a `glue` crate, and make `tvix-cli` a consumer of it.\n\nAll the KnownPaths setup and passing around, as well as NIX_PATH\nhandling is also something that should probably be moved into the glue\ncrate as well, but that\u0027s something left for a future CL.\n\nChange-Id: I080ed3d1825ab23790666486840f301f00856277\nReviewed-on: https://cl.tvl.fyi/c/depot/+/9908\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3196fe0143b6ff729c177fa5d17fa03c9e9627c9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3196fe0143b6ff729c177fa5d17fa03c9e9627c9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a51d277764d73582bc9bf816f6f4163d2df7f9c4","is_merged_in_target_branch":true,"change_id":"Iaf223e238713a48f8c50b0c58a8800a82ba24eed","change_number":9913,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}